Skip to content

Commit 0e4de77

Browse files
authored
Merge branch 'main' into feature/pre-commit-hook_support_1138
2 parents fe386b2 + 3442a4e commit 0e4de77

17 files changed

Lines changed: 166 additions & 56 deletions

src/docker-outside-of-docker/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "docker-outside-of-docker",
3-
"version": "1.6.2",
3+
"version": "1.6.3",
44
"name": "Docker (docker-outside-of-docker)",
55
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/docker-outside-of-docker",
66
"description": "Re-use the host docker socket, adding the Docker CLI to a container. Feature invokes a script to enable using a forwarded Docker socket within a container to run Docker commands.",

src/docker-outside-of-docker/install.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ INSTALL_DOCKER_BUILDX="${INSTALLDOCKERBUILDX:-"true"}"
2020
INSTALL_DOCKER_COMPOSE_SWITCH="${INSTALLDOCKERCOMPOSESWITCH:-"true"}"
2121

2222
MICROSOFT_GPG_KEYS_URI="https://packages.microsoft.com/keys/microsoft.asc"
23-
DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy noble"
24-
DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy noble"
23+
DOCKER_MOBY_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal jammy noble plucky"
24+
DOCKER_LICENSED_ARCHIVE_VERSION_CODENAMES="bookworm buster bullseye bionic focal hirsute impish jammy noble plucky"
2525

2626
set -e
2727

src/dotnet/devcontainer-feature.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "dotnet",
3-
"version": "2.2.1",
3+
"version": "2.3.0",
44
"name": "Dotnet CLI",
55
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/dotnet",
66
"description": "This Feature installs the latest .NET SDK, which includes the .NET CLI and the shared runtime. Options are provided to choose a different version or additional versions.",
@@ -11,6 +11,7 @@
1111
"latest",
1212
"lts",
1313
"none",
14+
"10.0-preview",
1415
"8.0",
1516
"7.0",
1617
"6.0"

src/dotnet/install.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,9 @@ done
108108
check_packages wget ca-certificates icu-devtools
109109

110110
for version in "${versions[@]}"; do
111-
install_sdk "$version"
111+
# Remove '-preview' from version if suffixed with the version label
112+
clean_version="$(echo "$version" | sed 's/-preview$//')"
113+
install_sdk "$clean_version"
112114
done
113115

114116
for version in "${dotnetRuntimeVersions[@]}"; do

src/dotnet/scripts/vendor/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ dotnet-install.sh [--version latest] --channel 6.0 [--quality GA]
2323
dotnet-install.sh [--version latest] --channel 6.0.4xx [--quality GA]
2424
dotnet-install.sh [--version latest] --channel 8.0 --quality preview
2525
dotnet-install.sh [--version latest] --channel 8.0 --quality daily
26+
dotnet-install.sh [--version latest] --channel 10.0 --quality preview
2627
dotnet-install.sh --version 6.0.413
2728
```

src/node/devcontainer-feature.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "node",
3-
"version": "1.6.2",
3+
"version": "1.6.3",
44
"name": "Node.js (via nvm), yarn and pnpm",
55
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
66
"description": "Installs Node.js, nvm, yarn, pnpm, and needed dependencies.",
@@ -11,9 +11,8 @@
1111
"lts",
1212
"latest",
1313
"none",
14-
"18",
15-
"16",
16-
"14"
14+
"22",
15+
"20"
1716
],
1817
"default": "lts",
1918
"description": "Select or enter a Node.js version to install"

test/dotnet/install_dotnet_multiple_versions.sh

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,8 @@ is_dotnet_sdk_version_installed "8.0"
2222
check ".NET SDK 7.0 installed" \
2323
is_dotnet_sdk_version_installed "7.0"
2424

25-
check ".NET SDK 6.0 installed" \
26-
is_dotnet_sdk_version_installed "6.0"
27-
28-
check ".NET SDK 5.0 installed" \
29-
is_dotnet_sdk_version_installed "5.0"
30-
31-
check ".NET Core SDK 3.1 installed" \
32-
is_dotnet_sdk_version_installed "3.1"
25+
check ".NET SDK 10.0 installed" \
26+
is_dotnet_sdk_version_installed "10.0"
3327

3428
check "Build example class library" \
3529
dotnet build projects/multitargeting
@@ -43,14 +37,8 @@ dotnet run --project projects/net8.0
4337
check "Build and run .NET 7.0 project" \
4438
dotnet run --project projects/net7.0
4539

46-
check "Build and run .NET 6.0 project" \
47-
dotnet run --project projects/net6.0
48-
49-
check "Build and run .NET 5.0 project" \
50-
dotnet run --project projects/net5.0
51-
52-
check "Build and run .NET Core 3.1 project" \
53-
dotnet run --project projects/netcoreapp3.1
40+
check "Build and run .NET 10.0 project" \
41+
dotnet run --project projects/net10.0
5442

5543
# Report results
5644
# If any of the checks above exited with a non-zero exit code, the test will fail.
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
# Optional: Import test library bundled with the devcontainer CLI
6+
# See https://github.com/devcontainers/cli/blob/HEAD/docs/features/test.md#dev-container-features-test-lib
7+
# Provides the 'check' and 'reportResults' commands.
8+
source dev-container-features-test-lib
9+
10+
# Feature-specific tests
11+
# The 'check' command comes from the dev-container-features-test-lib. Syntax is...
12+
# check <LABEL> <cmd> [args...]
13+
source dotnet_env.sh
14+
source dotnet_helpers.sh
15+
16+
check ".NET SDK 9.0 installed" \
17+
is_dotnet_sdk_version_installed "9.0"
18+
19+
check ".NET SDK 8.0 installed" \
20+
is_dotnet_sdk_version_installed "8.0"
21+
22+
check ".NET SDK 7.0 installed" \
23+
is_dotnet_sdk_version_installed "7.0"
24+
25+
check ".NET SDK 10.0 installed" \
26+
is_dotnet_sdk_version_installed "10.0"
27+
28+
check "Build example class library" \
29+
dotnet build projects/multitargeting
30+
31+
check "Build and run .NET 9.0 project" \
32+
dotnet run --project projects/net9.0
33+
34+
check "Build and run .NET 8.0 project" \
35+
dotnet run --project projects/net8.0
36+
37+
check "Build and run .NET 7.0 project" \
38+
dotnet run --project projects/net7.0
39+
40+
check "Build and run .NET 10.0 project" \
41+
dotnet run --project projects/net10.0
42+
43+
# Report results
44+
# If any of the checks above exited with a non-zero exit code, the test will fail.
45+
reportResults
46+
47+

test/dotnet/install_dotnet_specific_release.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ source dev-container-features-test-lib
1313
source dotnet_env.sh
1414
source dotnet_helpers.sh
1515

16-
expected=$(fetch_latest_version_in_channel "3.1")
16+
expected=$(fetch_latest_version_in_channel "8.0")
1717

18-
check ".NET Core SDK 3.1 installed" \
18+
check ".NET Core SDK 8.0 installed" \
1919
is_dotnet_sdk_version_installed "$expected"
2020

2121
check "Build and run example project" \
22-
dotnet run --project projects/netcoreapp3.1
22+
dotnet run --project projects/net8.0
2323

2424
# Report results
2525
# If any of the checks above exited with a non-zero exit code, the test will fail.

test/dotnet/install_dotnet_specific_release_and_feature_band.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ source dev-container-features-test-lib
1313
source dotnet_env.sh
1414
source dotnet_helpers.sh
1515

16-
check ".NET SDK 5.0.3xx installed" \
17-
is_dotnet_sdk_version_installed "5.0.3"
16+
check ".NET SDK 8.0.3xx installed" \
17+
is_dotnet_sdk_version_installed "8.0.3"
1818

1919
check "Build and run example project" \
20-
dotnet run --project projects/net5.0
20+
dotnet run --project projects/net8.0
2121

2222
# Report results
2323
# If any of the checks above exited with a non-zero exit code, the test will fail.

0 commit comments

Comments
 (0)