Skip to content

Commit 0292aee

Browse files
update docker-compose version to latest and add new test scenarios (#1571)
* update docker-compose version to latest and add new test scenarios * Fix JSON formatting in devcontainer-feature.json * Update default docker-compose version to 'latest' * Update default docker-compose version to 'latest' * Version bump * symlink --------- Co-authored-by: Kaniska <[email protected]>
1 parent 372e2d2 commit 0292aee

6 files changed

Lines changed: 42 additions & 5 deletions

File tree

src/docker-outside-of-docker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Re-use the host docker socket, adding the Docker CLI to a container. Feature inv
2020
| version | Select or enter a Docker/Moby CLI version. (Availability can vary by OS version.) | string | latest |
2121
| moby | Install OSS Moby build instead of Docker CE | boolean | true |
2222
| mobyBuildxVersion | Install a specific version of moby-buildx when using Moby | string | latest |
23-
| dockerDashComposeVersion | Compose version to use for docker-compose (v1 or v2 or none) | string | v2 |
23+
| dockerDashComposeVersion | Compose version to use for docker-compose (v1 or v2 or none or latest) | string | latest |
2424
| installDockerBuildx | Install Docker Buildx | boolean | true |
2525
| installDockerComposeSwitch | Install Compose Switch (provided docker compose is available) which is a replacement to the Compose V1 docker-compose (python) executable. It translates the command line into Compose V2 docker compose then runs the latter. | boolean | true |
2626

src/docker-outside-of-docker/devcontainer-feature.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
2+
23
"id": "docker-outside-of-docker",
3-
"version": "1.8.0",
4+
"version": "1.9.0",
45
"name": "Docker (docker-outside-of-docker)",
56
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/docker-outside-of-docker",
67
"description": "Re-use the host docker socket, adding the Docker CLI to a container. Feature invokes a script to enable using a forwarded Docker socket within a container to run Docker commands.",
@@ -29,11 +30,12 @@
2930
"type": "string",
3031
"enum": [
3132
"none",
33+
"latest",
3234
"v1",
3335
"v2"
3436
],
35-
"default": "v2",
36-
"description": "Compose version to use for docker-compose (v1 or v2 or none)"
37+
"default": "latest",
38+
"description": "Compose version to use for docker-compose (v1 or v2 or none or latest)"
3739
},
3840
"installDockerBuildx": {
3941
"type": "boolean",

src/docker-outside-of-docker/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
DOCKER_VERSION="${VERSION:-"latest"}"
1111
USE_MOBY="${MOBY:-"true"}"
1212
MOBY_BUILDX_VERSION="${MOBYBUILDXVERSION:-"latest"}"
13-
DOCKER_DASH_COMPOSE_VERSION="${DOCKERDASHCOMPOSEVERSION:-"v2"}" # v1 or v2 or none
13+
DOCKER_DASH_COMPOSE_VERSION="${DOCKERDASHCOMPOSEVERSION:-"latest"}" # v1 or v2 or none or latest
1414

1515
ENABLE_NONROOT_DOCKER="${ENABLE_NONROOT_DOCKER:-"true"}"
1616
SOURCE_SOCKET="${SOURCE_SOCKET:-"/var/run/docker-host.sock"}"
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
docker_dash_compose_latest_no_moby.sh
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#!/bin/bash
2+
3+
set -e
4+
5+
# Optional: Import test library
6+
source dev-container-features-test-lib
7+
8+
# Definition specific tests
9+
check "docker compose" bash -c "docker compose version | grep -E '5.[0-9]+.[0-9]+'"
10+
check "docker-compose" bash -c "docker-compose --version | grep -E '5.[0-9]+.[0-9]+'"
11+
check "installs compose-switch as docker-compose" bash -c "[[ -f /usr/local/bin/docker-compose ]]"
12+
13+
# Report result
14+
reportResults

test/docker-outside-of-docker/scenarios.json

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,5 +180,25 @@
180180
"moby": false
181181
}
182182
}
183+
},
184+
"docker_dash_compose_latest_moby": {
185+
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-24.04",
186+
"features": {
187+
"docker-outside-of-docker": {
188+
"moby": true,
189+
"dockerDashComposeVersion": "latest"
190+
}
191+
},
192+
"containerUser": "vscode"
193+
},
194+
"docker_dash_compose_latest_no_moby": {
195+
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-24.04",
196+
"features": {
197+
"docker-outside-of-docker": {
198+
"moby": false,
199+
"dockerDashComposeVersion": "latest"
200+
}
201+
},
202+
"containerUser": "vscode"
183203
}
184204
}

0 commit comments

Comments
 (0)