Skip to content

Commit 000fd32

Browse files
committed
Updating based on review comments
1 parent a2770b2 commit 000fd32

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

test/node/install_additional_node.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,12 @@ set -e
55
# Optional: Import test library
66
source dev-container-features-test-lib
77

8-
# 'lts' is now some version of node 20...
8+
# 'lts' is now some version of node 22...
99
check "version_on_path" node -v | grep 22
1010
check "pnpm" bash -c "pnpm -v | grep 8.8.0"
1111

12-
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
13-
check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3
14-
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1
12+
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1
13+
check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0
1514

1615

1716
# Report result

test/node/install_additional_node_on_rhel_family.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ set -e
55
# Optional: Import test library
66
source dev-container-features-test-lib
77

8-
# 'lts' is now some version of node 20...
8+
# 'lts' is now some version of node 22...
99
check "version_on_path" node -v | grep 22
1010
check "pnpm" bash -c "pnpm -v | grep 6.16.0"
1111

1212
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
13-
check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3
14-
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1
13+
check "v19_installed" ls -1 /usr/local/share/nvm/versions/node | grep 19.9.0
14+
check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20.19.1
1515

1616

1717
# Report result

test/node/scenarios.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
"version": "lts"
77
}
88
}
9-
},
9+
},
1010
"install_additional_node": {
1111
"image": "debian:11",
1212
"features": {
1313
"node": {
1414
"version": "lts",
15-
"additionalVersions": "v17.9.1,v14.19.3",
15+
"additionalVersions": "v20.19.1,v19.9.0",
1616
"pnpmVersion": "8.8.0"
1717
}
1818
}
@@ -22,7 +22,7 @@
2222
"features": {
2323
"node": {
2424
"version": "lts",
25-
"additionalVersions": "v17.9.1,v14.19.3",
25+
"additionalVersions": "v20.19.1,v19.9.0",
2626
"pnpmVersion": "6.16.0"
2727
}
2828
}

0 commit comments

Comments
 (0)