Skip to content

Commit 86b25b0

Browse files
authored
correct merge
2 parents a9161c9 + 3f22acc commit 86b25b0

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
Notable changes.
44

5+
## April 2023
6+
7+
### [0.37.0]
8+
9+
- Add --config to build command (microsoft/vscode-remote-release#8068)
10+
- Features/Templates: Fix a bug in reading from docker credential helpers (https://github.com/devcontainers/cli/issues/477)
11+
512
## March 2023
613

714
### [0.36.0]

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@devcontainers/cli",
33
"description": "Dev Containers CLI",
4-
"version": "0.36.0",
4+
"version": "0.37.0",
55
"bin": {
66
"devcontainer": "devcontainer.js"
77
},

src/spec-configuration/httpOCIRegistry.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ async function existsInPath(filename: string): Promise<boolean> {
205205
return false;
206206
}
207207

208-
209208
async function getCredentialFromDockerConfigOrCredentialHelper(params: CommonParams, registry: string) {
210209
const { output } = params;
211210

@@ -291,7 +290,7 @@ async function getCredentialFromHelper(params: CommonParams, registry: string, c
291290
try {
292291
const { stdout } = await runCommandNoPty({
293292
exec: plainExec(undefined),
294-
cmd: 'docker-credential-'+credHelperName,
293+
cmd: 'docker-credential-' + credHelperName,
295294
args: ['get'],
296295
stdin: Buffer.from(registry, 'utf-8'),
297296
output,
@@ -306,7 +305,7 @@ async function getCredentialFromHelper(params: CommonParams, registry: string, c
306305
}
307306

308307
let errors: jsonc.ParseError[] = [];
309-
const creds:CredentialHelperResult = jsonc.parse(helperOutput.toString(), errors);
308+
const creds: CredentialHelperResult = jsonc.parse(helperOutput.toString(), errors);
310309
if (errors.length !== 0) {
311310
output.write(`[httpOci] Credential helper ${credHelperName} returned non-JSON response "${helperOutput.toString()}" for registry ${registry}`, LogLevel.Warning);
312311
return undefined;

0 commit comments

Comments
 (0)