Skip to content

Commit 70801d5

Browse files
committed
Address PR review nits
1 parent 8742473 commit 70801d5

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

src/spec-node/utils.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -646,13 +646,15 @@ async function findDevContainerByNormalizedLabels(params: DockerResolverParamete
646646
.find(container => {
647647
const labels = container.Config.Labels || {};
648648
const containerWorkspaceFolder = labels[hostFolderLabel];
649-
if (!containerWorkspaceFolder || normalizeDevContainerLabelPath('win32', containerWorkspaceFolder) !== normalizedWorkspaceFolder) {
649+
const normalizedContainerWorkspaceFolder = containerWorkspaceFolder && normalizeDevContainerLabelPath('win32', containerWorkspaceFolder);
650+
if (!normalizedContainerWorkspaceFolder || normalizedContainerWorkspaceFolder !== normalizedWorkspaceFolder) {
650651
return false;
651652
}
652653

653654
const containerConfigFile = labels[configFileLabel];
654-
return !!containerConfigFile
655-
&& normalizeDevContainerLabelPath('win32', containerConfigFile) === normalizedConfigFile;
655+
const normalizedContainerConfigFile = containerConfigFile && normalizeDevContainerLabelPath('win32', containerConfigFile);
656+
return !!normalizedContainerConfigFile
657+
&& normalizedContainerConfigFile === normalizedConfigFile;
656658
});
657659
}
658660

@@ -672,11 +674,8 @@ async function findLegacyDevContainerByNormalizedWorkspaceFolder(params: DockerR
672674
.find(container => {
673675
const labels = container.Config.Labels || {};
674676
const containerWorkspaceFolder = labels[hostFolderLabel];
675-
if (!containerWorkspaceFolder) {
676-
return false;
677-
}
678-
679-
return normalizeDevContainerLabelPath('win32', containerWorkspaceFolder) === normalizedWorkspaceFolder;
677+
const normalizedContainerWorkspaceFolder = containerWorkspaceFolder && normalizeDevContainerLabelPath('win32', containerWorkspaceFolder);
678+
return normalizedContainerWorkspaceFolder === normalizedWorkspaceFolder;
680679
});
681680
}
682681

@@ -690,8 +689,8 @@ export async function findContainerAndIdLabels(params: DockerResolverParameters
690689

691690
const normalizedWorkspaceFolder = workspaceFolder ? normalizeDevContainerLabelPath(process.platform, workspaceFolder) : workspaceFolder;
692691
const normalizedConfigFile = configFile ? normalizeDevContainerLabelPath(process.platform, configFile) : configFile;
693-
const newLabels = [`${hostFolderLabel}=${normalizedWorkspaceFolder}`, `${configFileLabel}=${normalizedConfigFile}`];
694692
const oldLabels = [`${hostFolderLabel}=${normalizedWorkspaceFolder}`];
693+
const newLabels = [...oldLabels, `${configFileLabel}=${normalizedConfigFile}`];
695694

696695
let container: ContainerDetails | undefined;
697696
if (containerId) {

0 commit comments

Comments
 (0)