Fix PSScriptAnalyzer warnings with Where-Object alias and unused variables

devblackops · devblackops · commit cbeddc5bb65b · 2017-07-25T21:47:37.000-07:00
diff --git a/NetScaler/Public/Add-NSCertKeyPair.ps1 b/NetScaler/Public/Add-NSCertKeyPair.ps1
@@ -108,7 +108,7 @@ function Add-NSCertKeyPair {
                     $unsecurePassword = $creds.GetNetworkCredential().Password
                     $params.Add("passplain",$unsecurePassword)
                 }
-                $response = _InvokeNSRestApi  -Session $Session -Method POST -Type sslcertkey -Payload $params -Action add
+                _InvokeNSRestApi  -Session $Session -Method POST -Type sslcertkey -Payload $params -Action add > Out-Null
             } catch {
                 throw $_
             }
diff --git a/NetScaler/Public/Add-NSDnsNameServer.ps1 b/NetScaler/Public/Add-NSDnsNameServer.ps1
@@ -103,8 +103,7 @@ function Add-NSDnsNameServer {
                         $params.Add('dnsvservername', $DNSVServerName)
                     }
 
-                    $response = _InvokeNSRestApi -Session $Session -Method POST -Type dnsnameserver -Payload $params -Action add
-
+                    _InvokeNSRestApi -Session $Session -Method POST -Type dnsnameserver -Payload $params -Action add > Out-Null
                 } catch {
                     throw $_
                 }
diff --git a/NetScaler/Public/Add-NSDnsSuffix.ps1 b/NetScaler/Public/Add-NSDnsSuffix.ps1
@@ -62,7 +62,7 @@ function Add-NSDnsSuffix {
                     $params = @{
                          dnssuffix = $item;
                     }
-                    $response = _InvokeNSRestApi -Session $Session -Method POST -Type dnssuffix -Payload $params -Action add
+                    _InvokeNSRestApi -Session $Session -Method POST -Type dnssuffix -Payload $params -Action add > Out-Null
                 }
                 catch {
                     throw $_
diff --git a/NetScaler/Public/Add-NSIPResource.ps1 b/NetScaler/Public/Add-NSIPResource.ps1
@@ -31,30 +31,30 @@ function Add-NSIPResource {
         The NetScaler session object.
 
     .PARAMETER IPAddress
-        IPv4 address to create on the NetScaler appliance. 
+        IPv4 address to create on the NetScaler appliance.
 
         Note: Cannot be changed after the IP address is created
 
     .PARAMETER SubnetMask
         Subnet mask associated with the IP address.
 
     .PARAMETER Type
-        Type of the IP address to create on the NetScaler appliance. Cannot be changed after the IP address is created. 
-        
-        The following are the different types of NetScaler owned IP addresses: 
+        Type of the IP address to create on the NetScaler appliance. Cannot be changed after the IP address is created.
+
+        The following are the different types of NetScaler owned IP addresses:
 
         * A Subnet IP (SNIP) address is used by the NetScaler ADC to communicate with the servers.
         The NetScaler also uses the subnet IP address when generating its own packets, such as packets related to dynamic routing
-        protocols, or to send monitor probes to check the health of the servers. 
+        protocols, or to send monitor probes to check the health of the servers.
 
         * A Virtual IP (VIP) address is the IP address associated with a virtual server. It is the IP address to which clients connect.
-        An appliance managing a wide range of traffic may have many VIPs configured. Some of the attributes of the VIP address are 
-        customized to meet the requirements of the virtual server. 
-    
+        An appliance managing a wide range of traffic may have many VIPs configured. Some of the attributes of the VIP address are
+        customized to meet the requirements of the virtual server.
+
         * A GSLB site IP (GSLBIP) address is associated with a GSLB site. It is not mandatory to specify a GSLBIP address when you
-        initially configure the NetScaler appliance. A GSLBIP address is used only when you create a GSLB site. 
-    
-        * A Cluster IP (CLIP) address is the management address of the cluster. All cluster configurations must be performed by 
+        initially configure the NetScaler appliance. A GSLBIP address is used only when you create a GSLB site.
+
+        * A Cluster IP (CLIP) address is the management address of the cluster. All cluster configurations must be performed by
         accessing the cluster through this IP address.
 
         Default value: SNIP
@@ -88,7 +88,7 @@ function Add-NSIPResource {
         [string]$Type = 'SNIP',
 
         [switch]$VServer,
-        
+
         [switch]$MgmtAccess
     )
 
@@ -107,7 +107,7 @@ function Add-NSIPResource {
                         vserver = if ($PSBoundParameters.ContainsKey('VServer')) { 'ENABLED' } else { 'DISABLED' }
                         mgmtaccess = if ($PSBoundParameters.ContainsKey('MgmtAccess')) { 'ENABLED' } else { 'DISABLED' }
                     }
-                    $response = _InvokeNSRestApi -Session $Session -Method POST -Type nsip -Payload $params -Action add
+                    _InvokeNSRestApi -Session $Session -Method POST -Type nsip -Payload $params -Action add > Out-Null
                 } catch {
                     throw $_
                 }
diff --git a/NetScaler/Public/Add-NSSSLCertificateLink.ps1 b/NetScaler/Public/Add-NSSSLCertificateLink.ps1
@@ -58,7 +58,7 @@ function Add-NSSSLCertificateLink {
                     certkey = $CertKeyName
                     linkcertkeyname = $IntermediateCertKeyName
                 }
-                $response = _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action link
+                _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action link > Out-Null
             }
             catch {
                 throw $_
diff --git a/NetScaler/Public/Connect-NetScaler.ps1 b/NetScaler/Public/Connect-NetScaler.ps1
@@ -56,7 +56,7 @@ function Connect-NetScaler {
         [string]$Hostname,
 
         [parameter(Mandatory)]
-        [pscredential]$Credential = (Get-Credential -Message 'NetScaler credential'),
+        [pscredential]$Credential,
 
         [int]$Timeout = 900,
 
@@ -83,14 +83,14 @@ function Connect-NetScaler {
     $session | Add-Member -NotePropertyName Scheme   -NotePropertyValue $scheme -TypeName String
     $session | Add-Member -Name Uri -MemberType ScriptProperty -Value {
         "$($this.scheme)://$($this.endpoint)/nitro/v1"
-    } 
+    }
     $session | Add-Member -Name CreateUri -MemberType ScriptMethod -Value {
         Param(
             [String]$service,
             [String]$type
         )
         "$($this.Uri)/$service/$type"
-    } 
+    }
 
     Write-Verbose -Message "Connecting to $($session.Uri)..."
 
diff --git a/NetScaler/Public/Get-NSAAAGroup.ps1 b/NetScaler/Public/Get-NSAAAGroup.ps1
@@ -22,7 +22,7 @@ function Get-NSAAAGroup {
     .DESCRIPTION
         Gets NetScaler AAA group(s). If no parameters are provided all AAA
         groups are returned. The 'Groupname' and 'Filter' parameters can be
-        used to select a specific group or groups. 
+        used to select a specific group or groups.
 
     .EXAMPLE
         Get-NSAAAGroup
@@ -72,13 +72,13 @@ function Get-NSAAAGroup {
             if (-Not([string]::IsNullOrEmpty($Name))) {
                 foreach ($Group in $Name) {
                     $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaagroup -Resource $Group -Action Get
-                    if ($response.psobject.properties | where name -eq aaagroup) {
+                    if ($response.psobject.properties | Where-Object {$_.name -eq 'aaagroup'}) {
                         $response.aaagroup
                     }
                 }
             } else {
                 $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaagroup -Action Get
-                if ($response.psobject.properties | where name -eq aaagroup) {
+                if ($response.psobject.properties | Where-Object {$_.name -eq 'aaagroup'}) {
                     if (-Not([string]::IsNullOrEmpty($Filter))) {
                         foreach ($item in $response.aaagroup) {
                             if ($item.groupname -match "$Filter") {
diff --git a/NetScaler/Public/Get-NSAAAGroupBinding.ps1 b/NetScaler/Public/Get-NSAAAGroupBinding.ps1
@@ -20,7 +20,7 @@ function Get-NSAAAGroupBinding {
         Gets NetScaler AAA group(s) session policy bindings.
 
     .DESCRIPTION
-        Gets NetScaler AAA group(s) session policy bindings. 
+        Gets NetScaler AAA group(s) session policy bindings.
 
     .EXAMPLE
         Get-NSAAAGroupBinding -Groupname Group1
@@ -61,7 +61,7 @@ function Get-NSAAAGroupBinding {
         Try {
             foreach ($Group in $Name) {
                 $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaagroup_binding -Resource $Group -Action Get
-                if ($response.psobject.properties | where name -eq aaagroup_binding) {
+                if ($response.psobject.properties | Where-Object {$_.name -eq 'aaagroup_binding'}) {
                     $response.aaagroup_binding
                 }
             }
diff --git a/NetScaler/Public/Get-NSAAAUser.ps1 b/NetScaler/Public/Get-NSAAAUser.ps1
@@ -22,7 +22,7 @@ function Get-NSAAAUser {
     .DESCRIPTION
         Gets NetScaler AAA user(s). If no parameters are provided all AAA
         users are returned. The 'Username' and 'Filter' parameters can be
-        used to select a specific user or a subset of users. 
+        used to select a specific user or a subset of users.
 
     .EXAMPLE
         Get-NSAAAUser
@@ -72,13 +72,13 @@ function Get-NSAAAUser {
             if (-Not([string]::IsNullOrEmpty($Name))) {
                 foreach ($User in $Name) {
                     $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaauser -Resource $User -Action Get
-                    if ($response.psobject.properties | where name -eq aaauser) {
+                    if ($response.psobject.properties | Where-Object {$_.name -eq 'aaauser'}) {
                         $response.aaauser
                     }
                 }
             } else {
                 $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaauser -Action Get
-                if ($response.psobject.properties | where name -eq aaauser) {
+                if ($response.psobject.properties | Where-Object {$_.name -eq 'aaauser'}) {
                     if (-Not([string]::IsNullOrEmpty($Filter))) {
                         foreach ($item in $response.aaauser) {
                             if ($item.username -match "$Filter") {
diff --git a/NetScaler/Public/Get-NSAAAUserBinding.ps1 b/NetScaler/Public/Get-NSAAAUserBinding.ps1
@@ -20,7 +20,7 @@ function Get-NSAAAUserBinding {
         Gets NetScaler AAA user(s) session policy bindings.
 
     .DESCRIPTION
-        Gets NetScaler AAA user(s) session policy bindings. 
+        Gets NetScaler AAA user(s) session policy bindings.
 
     .EXAMPLE
         Get-NSAAAUserBinding -Username User1
@@ -61,7 +61,7 @@ function Get-NSAAAUserBinding {
         Try {
             foreach ($User in $Name) {
                 $response = _InvokeNSRestApi -Session $Session -Method Get -Type aaauser_binding -Resource $User -Action Get
-                if ($response.psobject.properties | where name -eq aaauser_binding) {
+                if ($response.psobject.properties | Where-Object {$_.name -eq 'aaauser_binding'}) {
                     $response.aaauser_binding
                 }
             }
diff --git a/NetScaler/Public/Get-NSLBSSLVirtualServer.ps1 b/NetScaler/Public/Get-NSLBSSLVirtualServer.ps1
@@ -66,7 +66,7 @@ function Get-NSLBSSLVirtualServer {
             $response = _InvokeNSRestApi -Session $Session -Method Get -Type sslvserver -Action Get
         }
         if ($response.errorcode -ne 0) { throw $response }
-        if ($response.psobject.properties | where name -eq sslvserver) {
+        if ($response.psobject.properties | Where-Object {$_.name -eq 'sslvserver'}) {
             return $response.sslvserver
         }
     }
diff --git a/NetScaler/Public/Get-NSLBSSLVirtualServerCertificateBinding.ps1 b/NetScaler/Public/Get-NSLBSSLVirtualServerCertificateBinding.ps1
@@ -62,7 +62,7 @@ function Get-NSLBSSLVirtualServerCertificateBinding {
 
         if ($response.errorcode -ne 0) { throw $response }
 
-        if ($response.psobject.properties | where name -eq sslvserver_sslcertkey_binding) {
+        if ($response.psobject.properties | Where-Object {$_.name -eq 'sslvserver_sslcertkey_binding'}) {
             return $response.sslvserver_sslcertkey_binding
         }
     }
diff --git a/NetScaler/Public/Get-NSLBVirtualServer.ps1 b/NetScaler/Public/Get-NSLBVirtualServer.ps1
@@ -29,7 +29,7 @@ function Get-NSLBVirtualServer {
 
     .EXAMPLE
         Get-NSLBVirtualServer -Name 'vserver01'
-    
+
         Get the load balancer virtual server named 'vserver01'.
 
     .PARAMETER Session
@@ -92,7 +92,7 @@ function Get-NSLBVirtualServer {
             $response = _InvokeNSRestApi -Session $Session -Method Get -Type lbvserver -Action Get
         }
         if ($response.errorcode -ne 0) { throw $response }
-        if ($response.psobject.properties | where name -eq lbvserver) {
+        if ($response.psobject.properties | Where-Object {$_.name -eq 'lbvserver'}) {
             return $response.lbvserver
         }
     }
diff --git a/NetScaler/Public/Get-NSResponderAction.ps1 b/NetScaler/Public/Get-NSResponderAction.ps1
@@ -97,15 +97,15 @@ function Get-NSResponderAction {
     process {
         # Contruct a filter hash if we specified any filters
         $filters = @{}
-        "Name","Type","Target","HtmlPage","ResponseStatusCode","Hits","UndefHits","ReferenceCount" | ForEach {
+        "Name","Type","Target","HtmlPage","ResponseStatusCode","Hits","UndefHits","ReferenceCount" | ForEach-Object {
             if ($PSBoundParameters.ContainsKey($_)) {
                 $filters[$_.ToLower()] = (Get-Variable -Name $_).Value
             }
         }
 
         $response = _InvokeNSRestApi -Session $Session -Method Get -Type responderaction -Action Get -Filters $filters
         if ($response.errorcode -ne 0) { throw $response }
-        if ($response.psobject.properties | where name -eq responderaction) {
+        if ($response.psobject.properties | Where-Object {$_.name -eq 'responderaction'}) {
             return $response.responderaction
         }
     }
diff --git a/NetScaler/Public/Get-NSStat.ps1 b/NetScaler/Public/Get-NSStat.ps1
@@ -74,13 +74,13 @@ function Get-NSStat {
             if ($Name.Count -gt 0) {
                 foreach ($item in $Name) {
                     $stats = _InvokeNSRestApi -Session $Session -Method Get -Type $statType -Stat -Resource $item
-                    if ($stats | Get-Member -MemberType NoteProperty | Where Name -eq $statType) {
+                    if ($stats | Get-Member -MemberType NoteProperty | Where-Object {$_.name -eq $statType}) {
                         $stats.$statType
                     }
                 }
             } else {
                 $stats = _InvokeNSRestApi -Session $Session -Method Get -Type $statType -Stat
-                if ($stats | Get-Member -MemberType NoteProperty | Where Name -eq $statType) {
+                if ($stats | Get-Member -MemberType NoteProperty | Where-Object {$_.name -eq $statType}) {
                     $stats.$statType
                 }
             }
diff --git a/NetScaler/Public/Install-NSLicense.ps1 b/NetScaler/Public/Install-NSLicense.ps1
@@ -38,9 +38,8 @@ function Install-NSLicense {
     #>
     [cmdletbinding(SupportsShouldProcess = $true, ConfirmImpact='medium')]
     param(
-        [parameter(Mandatory)]
         $Session = $script:session,
-        
+
         [parameter(Mandatory)]
         [ValidateScript({
             if (Test-Path -Path $_) {
@@ -77,7 +76,7 @@ function Install-NSLicense {
                 $response = _InvokeNSRestApi -Session $Session -Method POST -Type systemfile systemfile -Payload $params -Action add
 
                 if ($PSBoundParameters.ContainsKey('PassThru')) {
-                   return $response 
+                   return $response
                 }
             }
         } catch {
diff --git a/NetScaler/Public/Remove-NSLBVirtualServerBinding.ps1 b/NetScaler/Public/Remove-NSLBVirtualServerBinding.ps1
@@ -29,7 +29,7 @@ function Remove-NSLBVirtualServerBinding {
 
     .EXAMPLE
         'binding01', 'binding02' | Remove-NSLBVirtualServerBinding
-    
+
         Removes the load balancer virtual servers named 'binding01' and 'binding02'.
 
     .PARAMETER Session
@@ -76,11 +76,11 @@ function Remove-NSLBVirtualServerBinding {
                     $params = @{}
 
                     if ($PSBoundParameters.ContainsKey('ServiceGroupName')) {
-                        $match = $bindings | where servicegroupname -eq $ServiceGroupName | Select-Object -First 1
+                        $match = $bindings | Where-Object {$_.servicegroupname -eq $ServiceGroupName} | Select-Object -First 1
                         $params.servicegroupname = $match.servicegroupname
 
                     } elseif ($PSBoundParameters.ContainsKey('ServiceName')) {
-                        $match = @($bindings | where servicename -eq $ServiceName) | Select-Object -First 1
+                        $match = @($bindings | Where-Object {$_.servicename -eq $ServiceName}) | Select-Object -First 1
                         $params.servicename = $match.servicename
                     }
 
diff --git a/NetScaler/Public/Remove-NSSSLCertificateLink.ps1 b/NetScaler/Public/Remove-NSSSLCertificateLink.ps1
@@ -51,7 +51,7 @@ function Remove-NSSSLCertificateLink {
                 $params = @{
                     certkey = $CertKeyName
                 }
-                $response = _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action unlink
+                _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action unlink > $null
             }
             catch {
                 throw $_

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ function Add-NSCertKeyPair {`
`108`	`108`	`$unsecurePassword = $creds.GetNetworkCredential().Password`
`109`	`109`	`$params.Add("passplain",$unsecurePassword)`
`110`	`110`	`}`
`111`		`- $response = _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action add`
	`111`	`+ _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action add > Out-Null`
`112`	`112`	`} catch {`
`113`	`113`	`throw $_`
`114`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -103,8 +103,7 @@ function Add-NSDnsNameServer {`
`103`	`103`	`$params.Add('dnsvservername', $DNSVServerName)`
`104`	`104`	`}`
`105`	`105`
`106`		`- $response = _InvokeNSRestApi -Session $Session -Method POST -Type dnsnameserver -Payload $params -Action add`
`107`		`-`
	`106`	`+ _InvokeNSRestApi -Session $Session -Method POST -Type dnsnameserver -Payload $params -Action add > Out-Null`
`108`	`107`	`} catch {`
`109`	`108`	`throw $_`
`110`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ function Add-NSDnsSuffix {`
`62`	`62`	`$params = @{`
`63`	`63`	`dnssuffix = $item;`
`64`	`64`	`}`
`65`		`- $response = _InvokeNSRestApi -Session $Session -Method POST -Type dnssuffix -Payload $params -Action add`
	`65`	`+ _InvokeNSRestApi -Session $Session -Method POST -Type dnssuffix -Payload $params -Action add > Out-Null`
`66`	`66`	`}`
`67`	`67`	`catch {`
`68`	`68`	`throw $_`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ function Add-NSSSLCertificateLink {`
`58`	`58`	`certkey = $CertKeyName`
`59`	`59`	`linkcertkeyname = $IntermediateCertKeyName`
`60`	`60`	`}`
`61`		`- $response = _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action link`
	`61`	`+ _InvokeNSRestApi -Session $Session -Method POST -Type sslcertkey -Payload $params -Action link > Out-Null`
`62`	`62`	`}`
`63`	`63`	`catch {`
`64`	`64`	`throw $_`