Initial attempt at context aware upgrade testing.

desrosj · desrosj · commit 3c5364c862f3 · 2026-03-13T20:35:50.000-04:00
diff --git a/.github/workflows/upgrade-testing.yml b/.github/workflows/upgrade-testing.yml
@@ -9,20 +9,24 @@ on:
       - trunk
     # Always test the workflow after it's updated.
     paths:
+      - '.version-support-*.json'
       - '.github/workflows/upgrade-testing.yml'
       - '.github/workflows/reusable-upgrade-testing.yml'
+      - '.github/workflows/reusable-support-json-reader-v1.yml'
   pull_request:
     # This workflow is only meant to run from trunk. Pull requests changing this file with different BASE branches should be ignored.
     branches:
       - trunk
     # Always test the workflow when changes are suggested.
     paths:
+      - '.version-support-*.json'
       - '.github/workflows/upgrade-testing.yml'
       - '.github/workflows/reusable-upgrade-testing.yml'
+      - '.github/workflows/reusable-support-json-reader-v1.yml'
   workflow_dispatch:
     inputs:
       new-version:
-        description: 'The version to test installing. Accepts major and minor versions, "latest", or "nightly". Major releases must not end with ".0".'
+        description: 'The version to test upgrading to. Accepts major and minor versions, "latest", or "nightly". Major releases must not end with ".0".'
         type: string
         default: 'latest'
 
@@ -37,6 +41,10 @@ concurrency:
 # Any needed permissions should be configured at the job level.
 permissions: {}
 
+env:
+  CURRENTLY_SUPPORTED_BRANCH: '6.9'
+  OLDEST_SECURITY_BRANCH: '4.7'
+
 # Because the number of jobs spawned can quickly balloon out of control, the following methodology is applied when
 # building out the matrix below:
 #
@@ -57,11 +65,111 @@ permissions: {}
 #    - 5.6.x Docker containers are available and work, but 5.6 only accounts for ~2.3% of installs as of 12/6/2024.defaults:
 #    - 5.7.x accounts for ~20% of installs, so this is used below instead.
 jobs:
+  # Determines whether an older branch is being tested.
+  #
+  # When an older version is specified, a reduced matrix tailored to that branch is run.
+  determine-workflow-type:
+    name: Determine workflow type
+    runs-on: 'ubuntu-24.04'
+    timeout-minutes: 5
+    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    outputs:
+      testing-old-branch: ${{ steps.old-branch-check.outputs.testing-old-branch }}
+    steps:
+      - name: Determine if an older branch is being tested
+        id: old-branch-check
+        env:
+          NEW_VERSION: ${{ inputs.new-version }}
+          CURRENTLY_SUPPORTED_BRANCH: ${{ env.CURRENTLY_SUPPORTED_BRANCH }}
+        run: |
+          case "$NEW_VERSION" in
+            "" | "latest" | "nightly" | "$CURRENTLY_SUPPORTED_BRANCH" | "$CURRENTLY_SUPPORTED_BRANCH".*)
+              echo "testing-old-branch=false" >> "$GITHUB_OUTPUT"
+              ;;
+            *)
+              echo "testing-old-branch=true" >> "$GITHUB_OUTPUT"
+              ;;
+          esac
+
+  # Determines the PHP and database versions to test based on the WordPress version when testing old branches.
+  build-test-matrix:
+    name: Build Test Matrix
+    uses: ./.github/workflows/reusable-support-json-reader-v1.yml
+    permissions:
+      contents: read
+    secrets: inherit
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch == 'true' }}
+    with:
+      wp-version: ${{ inputs.new-version }}
+
+  # Determines the list of WordPress versions to upgrade from when testing an older branch.
+  #
+  # Generates a JSON array of all branches from OLDEST_SECURITY_BRANCH up to, but not
+  # including, the target branch. For example, when the target is 5.0, this produces
+  # ["4.7", "4.8", "4.9"]. WordPress branches are versioned as X.Y, where Y increments
+  # from 0 to 9 before X increments and Y resets to 0.
+  #
+  # Only runs when testing an older branch.
+  determine-from-versions:
+    name: Determine FROM WordPress versions
+    runs-on: 'ubuntu-24.04'
+    timeout-minutes: 5
+    needs: [ determine-workflow-type, build-test-matrix ]
+    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    outputs:
+      from-versions: ${{ steps.from-versions.outputs.from-versions }}
+
+    steps:
+      - name: Determine the FROM WordPress versions
+        id: from-versions
+        env:
+          OLDEST_SECURITY_BRANCH: ${{ env.OLDEST_SECURITY_BRANCH }}
+          MAJOR_WP_VERSION: ${{ needs.build-test-matrix.outputs.major-wp-version }}
+        run: |
+          OLDEST_MAJOR=$(echo "$OLDEST_SECURITY_BRANCH" | cut -d'.' -f1)
+          OLDEST_MINOR=$(echo "$OLDEST_SECURITY_BRANCH" | cut -d'.' -f2)
+
+          # Converts the target branch key (e.g. "5-0") to X.Y format.
+          TARGET=$(echo "$MAJOR_WP_VERSION" | tr '-' '.')
+          TARGET_MAJOR=$(echo "$TARGET" | cut -d'.' -f1)
+          TARGET_MINOR=$(echo "$TARGET" | cut -d'.' -f2)
+
+          # Build a JSON array of all branches from OLDEST_SECURITY_BRANCH up to, but not
+          # including, the target branch. Y increments 0–9, then X increments and Y resets to 0.
+          VERSIONS=""
+          CURRENT_MAJOR=$OLDEST_MAJOR
+          CURRENT_MINOR=$OLDEST_MINOR
+
+          while true; do
+            if [ "$CURRENT_MAJOR" -gt "$TARGET_MAJOR" ] || \
+               { [ "$CURRENT_MAJOR" -eq "$TARGET_MAJOR" ] && [ "$CURRENT_MINOR" -ge "$TARGET_MINOR" ]; }; then
+              break
+            fi
+
+            if [ -n "$VERSIONS" ]; then
+              VERSIONS="${VERSIONS},"
+            fi
+            VERSIONS="${VERSIONS}\"${CURRENT_MAJOR}.${CURRENT_MINOR}\""
+
+            if [ "$CURRENT_MINOR" -eq 9 ]; then
+              CURRENT_MAJOR=$((CURRENT_MAJOR + 1))
+              CURRENT_MINOR=0
+            else
+              CURRENT_MINOR=$((CURRENT_MINOR + 1))
+            fi
+          done
+
+          echo "from-versions=[${VERSIONS}]" >> "$GITHUB_OUTPUT"
+
   # Tests the full list of PHP/MySQL combinations for the two most recent versions of WordPress.
+  #
+  # Only runs when testing the currently supported branch or latest/nightly.
   upgrade-tests-recent-releases:
     name: ${{ matrix.wp }} to ${{ inputs.new-version && inputs.new-version || 'latest' }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
-    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch != 'true' }}
     permissions:
       contents: read
     strategy:
@@ -83,10 +191,13 @@ jobs:
       multisite: ${{ matrix.multisite }}
 
   # Tests 6.x releases where the WordPress database version changed on the oldest and newest supported versions of PHP 7 & 8.
+  #
+  # Only runs when testing the currently supported branch or latest/nightly.
   upgrade-tests-wp-6x-mysql:
     name: ${{ matrix.wp }} to ${{ inputs.new-version && inputs.new-version || 'latest' }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
-    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch != 'true' }}
     permissions:
       contents: read
     strategy:
@@ -108,10 +219,13 @@ jobs:
       multisite: ${{ matrix.multisite }}
 
   # Tests 5.x releases where the WordPress database version changed on the only supported version of PHP 7.
+  #
+  # Only runs when testing the currently supported branch or latest/nightly.
   upgrade-tests-wp-5x-php-7x-mysql:
     name: ${{ matrix.wp }} to ${{ inputs.new-version && inputs.new-version || 'latest' }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
-    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch != 'true' }}
     permissions:
       contents: read
     strategy:
@@ -137,10 +251,13 @@ jobs:
   # WordPress 5.0-5.2 are excluded from PHP 8+ testing because of the following fatal errors:
   # - Use of __autoload().
   # - array/string offset with curly braces.
+  #
+  # Only runs when testing the currently supported branch or latest/nightly.
   upgrade-tests-wp-5x-php-8x-mysql:
     name: ${{ matrix.wp }} to ${{ inputs.new-version && inputs.new-version || 'latest' }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
-    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch != 'true' }}
     permissions:
       contents: read
     strategy:
@@ -167,10 +284,13 @@ jobs:
   # WordPress 4.7 is excluded from PHP 8+ testing because of the following fatal errors:
   # - Use of __autoload().
   # - array/string offset with curly braces.
+  #
+  # Only runs when testing the currently supported branch or latest/nightly.
   upgrade-tests-oldest-wp-mysql:
     name: ${{ matrix.wp }} to ${{ inputs.new-version && inputs.new-version || 'latest' }}
     uses: ./.github/workflows/reusable-upgrade-testing.yml
-    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ determine-workflow-type ]
+    if: ${{ needs.determine-workflow-type.outputs.testing-old-branch != 'true' }}
     permissions:
       contents: read
     strategy:
@@ -191,13 +311,72 @@ jobs:
       new-version: ${{ inputs.new-version && inputs.new-version || 'latest' }}
       multisite: ${{ matrix.multisite }}
 
+  # Tests an older WordPress branch against all PHP and database versions it supports, as
+  # documented in the version support JSON files.
+  #
+  # Uses the X.Y initial release of the branch as the FROM version to test the within-branch
+  # upgrade path. PHP and database versions unsupported by Docker are excluded, as are MySQL
+  # innovation releases other than the most recent.
+  #
+  # Only runs when testing an older branch (i.e. new-version is not empty, 'latest', 'nightly',
+  # or a version of the currently supported branch).
+  upgrade-tests-older-branch-mysql:
+    name: WP ${{ matrix.wp }} to ${{ inputs.new-version }} / PHP ${{ matrix.php }} / MySQL ${{ matrix.db-version }}${{ matrix.multisite && ' multisite' || '' }}
+    uses: ./.github/workflows/reusable-upgrade-testing.yml
+    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
+    needs: [ build-test-matrix, determine-from-versions ]
+    permissions:
+      contents: read
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ 'ubuntu-24.04' ]
+        php: ${{ fromJSON( needs.build-test-matrix.outputs.php-versions ) }}
+        db-type: [ 'mysql' ]
+        db-version: ${{ fromJSON( needs.build-test-matrix.outputs.mysql-versions ) }}
+        wp: ${{ fromJSON( needs.determine-from-versions.outputs.from-versions ) }}
+        multisite: [ false, true ]
+        exclude:
+          # There are no local WordPress Docker environment containers for PHP <= 5.3.
+          - php: '5.2'
+          - php: '5.3'
+          # MySQL containers <= 5.5 do not exist or fail to start properly.
+          - db-version: '5.0'
+          - db-version: '5.1'
+          - db-version: '5.5'
+          # The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
+          - php: '7.2'
+            db-version: '8.4'
+          - php: '7.3'
+            db-version: '8.4'
+          # Only test the latest innovation release.
+          - db-version: '9.0'
+          - db-version: '9.1'
+          - db-version: '9.2'
+          - db-version: '9.3'
+          - db-version: '9.4'
+          - db-version: '9.5'
+          # MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
+          - php: '7.2'
+            db-version: '9.6'
+          - php: '7.3'
+            db-version: '9.6'
+    with:
+      os: ${{ matrix.os }}
+      php: ${{ matrix.php }}
+      db-type: ${{ matrix.db-type }}
+      db-version: ${{ matrix.db-version }}
+      wp: ${{ matrix.wp }}
+      new-version: ${{ inputs.new-version }}
+      multisite: ${{ matrix.multisite }}
+
   slack-notifications:
     name: Slack Notifications
     uses: ./.github/workflows/slack-notifications.yml
     permissions:
       actions: read
       contents: read
-    needs: [ upgrade-tests-recent-releases, upgrade-tests-wp-6x-mysql, upgrade-tests-wp-5x-php-7x-mysql, upgrade-tests-wp-5x-php-8x-mysql, upgrade-tests-oldest-wp-mysql ]
+    needs: [ upgrade-tests-recent-releases, upgrade-tests-wp-6x-mysql, upgrade-tests-wp-5x-php-7x-mysql, upgrade-tests-wp-5x-php-8x-mysql, upgrade-tests-oldest-wp-mysql, upgrade-tests-older-branch-mysql ]
     if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     with:
       calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
@@ -209,7 +388,7 @@ jobs:
 
   failed-workflow:
     name: Failed workflow tasks
-    runs-on: ubuntu-24.04
+    runs-on: 'ubuntu-24.04'
     permissions:
       actions: write
     needs: [ slack-notifications ]
