Skip to content

Commit 42629bd

Browse files
committed
Bug fixes
1 parent bca0009 commit 42629bd

3 files changed

Lines changed: 40 additions & 25 deletions

File tree

controllers/sitesController.js

Lines changed: 30 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ const middlewares = require('../middlewares/auth');
66
const siteServices = require('../services/siteServices');
77

88
const notificationServices = require('../services/notificationServices');
9-
const { APP_CONFIG } = require("../config/app");
9+
const {
10+
APP_CONFIG
11+
} = require("../config/app");
1012
router.get('/create', middlewares.protectedRoute, async (req, res) => {
1113

1214
res.render('sites/create');
@@ -45,30 +47,39 @@ router.post('/create', middlewares.protectedRoute, async (req, res) => {
4547
});
4648

4749
router.get('/:id/manage', middlewares.protectedRoute, async (req, res) => {
48-
let hasAccess = await siteServices.checkUserAccess(req, res);
4950

50-
const siteData = await Site.findById(req.params.id).exec();
51+
try {
52+
const siteData = await Site.findById(req.params.id).exec();
5153

52-
const successedSites = siteData.geolocation_data.find(site => site.ipData.status === 'success');
54+
if (siteData) {
55+
let hasAccess = await siteServices.checkUserAccess(req, res);
56+
const successedSites = siteData.geolocation_data.find(site => site.ipData.status === 'success');
5357

5458

55-
const mapped = JSON.stringify(siteData);
56-
if(APP_CONFIG.DEBUG.DEBUG_ENABLED){
57-
console.log(`${APP_CONFIG.DEBUG.DEBUG_PREFIX} Browser List ${siteData.browser_list}`);
58-
}
59-
if (hasAccess) {
60-
res.render('index', {
61-
siteData: JSON.parse(mapped),
62-
visitorList: siteData.visitors_list,
63-
browserList: siteData.browser_list,
64-
geoLocationData: successedSites
65-
});
66-
return;
59+
const mapped = JSON.stringify(siteData);
60+
if (APP_CONFIG.DEBUG.DEBUG_ENABLED) {
61+
console.log(`${APP_CONFIG.DEBUG.DEBUG_PREFIX} Browser List ${siteData.browser_list}`);
62+
}
63+
if (hasAccess) {
64+
res.render('index', {
65+
siteData: JSON.parse(mapped),
66+
visitorList: siteData.visitors_list,
67+
browserList: siteData.browser_list,
68+
geoLocationData: successedSites
69+
});
70+
return;
71+
}
72+
73+
res.send({
74+
'error': 'You dont have permissions to manage this site !'
75+
})
76+
} else {
77+
res.send({'error': 'This site does not exists !'});
78+
}
79+
} catch (error) {
80+
res.redirect('/')
6781
}
6882

69-
res.send({
70-
'error': 'You dont have permissions to manage this site !'
71-
})
7283
});
7384

7485
module.exports = router;

controllers/userController.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,15 @@ const middlewares = require('../middlewares/auth');
44
const utils = require('../utils/avatars');
55
router.get('/:id', middlewares.protectedRoute, async (req, res) => {
66

7-
const userData = await User.findById(req.params.id).exec();
8-
const mapped = JSON.stringify(userData);
9-
const userDetails = JSON.parse(mapped);
10-
const userImage = await utils.getAvatar(userData.email);
11-
res.render('profiles/index',{userDetails,userImage});
7+
try{
8+
const userData = await User.findById(req.params.id).exec();
9+
const mapped = JSON.stringify(userData);
10+
const userDetails = JSON.parse(mapped);
11+
const userImage = await utils.getAvatar(userData.email);
12+
res.render('profiles/index',{userDetails,userImage});
13+
}catch(error){
14+
res.redirect('/')
15+
}
1216
});
1317

1418
module.exports = router;

views/index.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ document.addEventListener('DOMContentLoaded',(event) => {
5858

5959
<div class="container-fluid p-0">
6060

61-
<h1 class="h3 mb-3"><strong>Analytics</strong> Dashboard</h1>
61+
<h1 class="h3 mb-3"><strong>Analytics</strong> Dashboard - {{siteData.site_name}}</h1>
6262

6363
<div class="row">
6464
<div class="col-xl-6 col-xxl-5 d-flex">

0 commit comments

Comments
 (0)