Skip to content

Commit 961f24a

Browse files
authored
Merge pull request #268 from maxim-belkin/fix-returns
util.py: make functions return NotImplemented
2 parents 894d47f + dd1fce0 commit 961f24a

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

bin/util.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@ def pretty(item):
7474
return location + ': ' + message
7575
elif isinstance(location, tuple):
7676
return '{0}:{1}: '.format(*location) + message
77-
else:
78-
assert False, 'Unknown item "{0}"'.format(item)
77+
78+
print('Unknown item "{0}"'.format(item), file=sys.stderr)
79+
return NotImplemented
7980

8081
@staticmethod
8182
def key(item):
@@ -86,8 +87,9 @@ def key(item):
8687
return (location, -1, message)
8788
elif isinstance(location, tuple):
8889
return (location[0], location[1], message)
89-
else:
90-
assert False, 'Unknown item "{0}"'.format(item)
90+
91+
print('Unknown item "{0}"'.format(item), file=sys.stderr)
92+
return NotImplemented
9193

9294
def report(self, stream=sys.stdout):
9395
"""Report all messages in order."""

0 commit comments

Comments
 (0)