[-] reset session before returning connection to the pool (#589)

Co-authored-by: amihajlovic <[email protected]>
Co-authored-by: Pavlo Golub <[email protected]>

Author: 3 people

internal/pgengine/bootstrap.go

@@ -179,6 +179,17 @@ func (pge *PgEngine) getPgxConnConfig() *pgxpool.Config {
 		pgconn.TypeMap().RegisterType(&pgtype.Type{Name: "timetable.log_type", OID: pge.logTypeOID, Codec: &pgtype.EnumCodec{}})
 		return err
 	}
+	// reset session before returning connection to the pool
+	// after task completion, if the task is not properly finalized (especially when running in autonomous mode),
+	// some objects and/or setting changes will still exist in the session
+	connConfig.AfterRelease = func(pgconn *pgx.Conn) bool {
+		var err error
+		if _, err = pgconn.Exec(context.Background(), "DISCARD ALL"); err == nil {
+			_, err = pgconn.Exec(context.Background(), "LISTEN "+quoteIdent(pge.ClientName))
+		}
+		return err != nil
+	}
+
 	if !pge.Start.Debug { //will handle notification in HandleNotifications directly
 		connConfig.ConnConfig.OnNotification = pge.NotificationHandler
 	}

internal/pgengine/copy_test.go

@@ -15,8 +15,12 @@ func TestCopyFromFile(t *testing.T) {
 	ctx := context.Background()
 	_, err := pge.CopyFromFile(ctx, "fake.csv", "COPY location FROM STDIN")
 	assert.Error(t, err, "Should fail for missing file")
-	_, err = pge.ConfigDb.Exec(ctx, "CREATE TEMP TABLE csv_test(id integer, val text)")
+	_, err = pge.ConfigDb.Exec(ctx, "CREATE UNLOGGED TABLE csv_test(id integer, val text)")
 	assert.NoError(t, err, "Should create temporary table")
+	defer func() {
+		_, err = pge.ConfigDb.Exec(ctx, "DROP TABLE csv_test")
+		assert.NoError(t, err, "Should drop temporary table")
+	}()
 	assert.NoError(t, os.WriteFile("test.csv", []byte("1,foo\n2,bar"), 0666), "Should create source CSV file")
 	cnt, err := pge.CopyFromFile(ctx, "test.csv", "COPY csv_test FROM STDIN (FORMAT csv)")
 	assert.NoError(t, err, "Should copy from file")