Detect volume changes when syncing statefulsets

ants · ants · commit ffa67721e1f2 · 2024-05-31T16:47:40.000+03:00
diff --git a/pkg/cluster/cluster.go b/pkg/cluster/cluster.go
@@ -639,6 +639,9 @@ func (c *Cluster) compareStatefulSetWith(oldSts, newSts *appsv1.StatefulSet) *co
 	if len(oldSts.Spec.Template.Spec.Volumes) != len(newSts.Spec.Template.Spec.Volumes) {
 		needsReplace = true
 		reasons = append(reasons, "new statefulset's volumes contains different number of volumes to the old one")
+	} else if !reflect.DeepEqual(oldSts.Spec.Template.Spec.Volumes, newSts.Spec.Template.Spec.Volumes) {
+		needsReplace = true
+		reasons = append(reasons, "new statefulset's volumes do not match old one")
 	}
 
 	// we assume any change in priority happens by rolling out a new priority class

Original file line number	Diff line number	Diff line change
`@@ -639,6 +639,9 @@ func (c Cluster) compareStatefulSetWith(oldSts, newSts appsv1.StatefulSet) *co`
`639`	`639`	`if len(oldSts.Spec.Template.Spec.Volumes) != len(newSts.Spec.Template.Spec.Volumes) {`
`640`	`640`	`needsReplace = true`
`641`	`641`	`reasons = append(reasons, "new statefulset's volumes contains different number of volumes to the old one")`
	`642`	`+ } else if !reflect.DeepEqual(oldSts.Spec.Template.Spec.Volumes, newSts.Spec.Template.Spec.Volumes) {`
	`643`	`+ needsReplace = true`
	`644`	`+ reasons = append(reasons, "new statefulset's volumes do not match old one")`
`642`	`645`	`}`
`643`	`646`
`644`	`647`	`// we assume any change in priority happens by rolling out a new priority class`