Skip to content

Commit efa6a2e

Browse files
committed
fix conflicts
1 parent cce2249 commit efa6a2e

3 files changed

Lines changed: 10 additions & 18 deletions

File tree

pkg/apis/cpo.opensource.cybertec.at/v1/crds.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1581,6 +1581,9 @@ var PostgresCRDResourceValidation = apiextv1.CustomResourceValidation{
15811581
"image": {
15821582
Type: "string",
15831583
},
1584+
"customQueries": {
1585+
Type: "string",
1586+
},
15841587
"env": {
15851588
Type: "array",
15861589
Nullable: true,

pkg/apis/cpo.opensource.cybertec.at/v1/postgresql_type.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,8 +332,9 @@ type TDE struct {
332332

333333
// Monitoring Sidecar defines a container to be run in the same pod as the Postgres container.
334334
type Monitoring struct {
335-
Image string `json:"image,omitempty"`
336-
Env []v1.EnvVar `json:"env,omitempty"`
335+
Image string `json:"image,omitempty"`
336+
CustomQueries string `json:"customQueries,omitempty"`
337+
Env []v1.EnvVar `json:"env,omitempty"`
337338
}
338339

339340
// Multisite enables cross Kubernetes replication coordinated via etcd

pkg/cluster/sync.go

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ func (c *Cluster) Sync(newSpec *cpov1.Postgresql) error {
230230
return err
231231
}
232232

233-
if err = c.syncPgbackrestRepoHostConfig(&c.Spec); err != nil {
233+
if err = c.syncPgbackrestConfig(); err != nil {
234234
err = fmt.Errorf("could not sync pgbackrest config: %v", err)
235235
return err
236236
}
@@ -358,21 +358,9 @@ func (c *Cluster) Sync(newSpec *cpov1.Postgresql) error {
358358
}
359359
}
360360

361-
if err != nil {
362-
syncFailed = true
363-
}
364-
if !syncFailed {
365-
err = c.executeMajorVersionUpgrade()
366-
if err != nil {
367-
c.logger.Errorf("major version upgrade failed after retries: %v", err)
368-
syncFailed = true
369-
}
370-
}
371-
372-
if syncFailed {
373-
c.logger.Errorf("Update for cluster %s/%s finished with errors..", c.Namespace, c.Name)
374-
} else {
375-
c.logger.Infof("Update for cluster %s/%s completed successfully.", c.Namespace, c.Name)
361+
// Major version upgrade must only run after success of all earlier operations, must remain last item in sync
362+
if err := c.majorVersionUpgrade(); err != nil {
363+
c.logger.Errorf("major version upgrade failed: %v", err)
376364
}
377365

378366
if len(syncErrors) > 0 {

0 commit comments

Comments
 (0)