code optimizations

Author: Schmaetz

pkg/cluster/cluster.go

@@ -2071,7 +2071,9 @@ func (c *Cluster) getPasswordForUser(username string) (string, error) {
 		}
 		c.multisiteClient = client
 	}
-	reqTimeoutCtx, _ := context.WithTimeout(context.TODO(), time.Duration(2)*time.Second)
+	reqTimeoutCtx, cancel := context.WithTimeout(context.TODO(), time.Duration(2)*time.Second)
+	defer cancel()
+
 	credentialsKey := fmt.Sprintf("/multisite/%s/%s/credentials/%s", c.Namespace, c.Name, username)
 	response, err := c.multisiteClient.Get(reqTimeoutCtx, credentialsKey)
 	if err != nil {

pkg/cluster/k8sres.go

@@ -2132,7 +2132,7 @@ func (c *Cluster) generatePodAnnotations(spec *cpov1.PostgresSpec) map[string]st
 	for k, v := range c.OpConfig.CustomPodAnnotations {
 		annotations[k] = v
 	}
-	if spec != nil || spec.PodAnnotations != nil {
+	if spec != nil && spec.PodAnnotations != nil {
 		for k, v := range spec.PodAnnotations {
 			annotations[k] = v
 		}

pkg/cluster/sync.go

@@ -1108,7 +1108,7 @@ func (c *Cluster) updateSecret(
 	}
 
 	if updateSecret {
-		c.logger.Debugln("%s", updateSecretMsg)
+		c.logger.Debugf("%s", updateSecretMsg)
 		if _, err = c.KubeClient.Secrets(secret.Namespace).Update(context.TODO(), secret, metav1.UpdateOptions{}); err != nil {
 			return fmt.Errorf("could not update secret %s: %v", secretName, err)
 		}

pkg/cluster/util.go

@@ -205,7 +205,7 @@ func logNiceDiff(log *logrus.Entry, old, new interface{}) {
 	nice := nicediff.Diff(string(o), string(n), true)
 	for _, s := range strings.Split(nice, "\n") {
 		// " is not needed in the value to understand
-		log.Debugf(strings.ReplaceAll(s, "\"", ""))
+		log.Debugf("%s", strings.ReplaceAll(s, "\"", ""))
 	}
 }
 
@@ -512,8 +512,6 @@ func (c *Cluster) waitForPrimaryLoadBalancerIp() error {
 			}
 			return len(svc.Status.LoadBalancer.Ingress) > 0, nil
 		})
-
-	return nil
 }
 
 func (c *Cluster) getPrimaryLoadBalancerIp() (string, error) {