improve CI (#924)

* improve CI

* cleanup

* fix

Author: romainmenke

.github/bin/list-workspaces/list-workspaces.mjs

@@ -34,7 +34,7 @@ export async function listWorkspaces() {
 
 		for (const packageJSONPath of Array.from(packages)) {
 			const packageJSON = JSON.parse(await fsp.readFile(packageJSONPath));
-			const packagePath = packageJSONPath.slice(0, -1 * '/package.json'.length);
+			const packagePath = path.relative(process.cwd(), path.dirname(packageJSONPath));
 
 			result.push({
 				path: packagePath,

.github/bin/modified-workspaces/modified-workspaces.mjs

@@ -1,8 +1,12 @@
 import { listModifiedFilesInPullRequest } from './list-modified-files.mjs';
 import { listWorkspaces } from '../list-workspaces/list-workspaces.mjs';
 
-const privateRootDependencies = [
-	'packages/postcss-tape',
+const internalDependencies = [
+	'.github/',
+	'package-lock.json',
+	'package.json',
+	'rollup/',
+	'tsconfig.json',
 ];
 
 export async function listModifiedWorkspaces() {
@@ -40,8 +44,9 @@ export async function listModifiedWorkspaces() {
 	const modifiedWorkspaces = new Set();
 
 	for (const modifiedFile of modifiedFiles) {
-		for (const privateRootDependency of privateRootDependencies) {
-			if (modifiedFile.startsWith(privateRootDependency)) {
+		for (const internalDependency of internalDependencies) {
+			if (modifiedFile.startsWith(internalDependency)) {
+				console.error('modified a private dependency', modifiedFile);
 				// this file can influence anything
 				// anything or everything might have changed
 				return {
@@ -54,6 +59,16 @@ export async function listModifiedWorkspaces() {
 
 		let isNonWorkspaceFile = true;
 		for (const workspace of workspaces) {
+			if (modifiedFile.startsWith('e2e/')) {
+				continue;
+			}
+
+			if (modifiedFile.startsWith('sites/')) {
+				continue;
+			}
+
+			console.error('modifiedFile outside of workspaces', modifiedFile);
+
 			if (modifiedFile.startsWith(workspace.path)) {
 				isNonWorkspaceFile = false;
 

.github/workflows/test.yml

@@ -75,7 +75,7 @@ jobs:
         if: matrix.is_base_node_version && matrix.is_base_os_version
 
       - name: docs
-        run: npm run docs --if-present $MODIFIED_WORKSPACES
+        run: npm run docs
         if: matrix.is_base_node_version && matrix.is_base_os_version
 
       - name: repo is clean after "build", "lint" and "docs" steps