Skip to content

Commit e0c4275

Browse files
committed
feat: remove unused certificate and domain parameters from Bicep files
1 parent 890567e commit e0c4275

4 files changed

Lines changed: 8 additions & 36 deletions

File tree

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
using './web.module.bicep'
22

33
param azure_storage_outputs_tableendpoint = '{{ .Env.AZURE_STORAGE_TABLEENDPOINT }}'
4-
param certificateName = '{{ parameter "certificateName" }}'
5-
param domainApex = '{{ parameter "domainApex" }}'
6-
param domainWww = '{{ parameter "domainWww" }}'
74
param outputs_azure_container_apps_environment_default_domain = '{{ .Env.AZURE_CONTAINER_APPS_ENVIRONMENT_DEFAULT_DOMAIN }}'
85
param outputs_azure_container_apps_environment_id = '{{ .Env.AZURE_CONTAINER_APPS_ENVIRONMENT_ID }}'
96
param outputs_azure_container_registry_endpoint = '{{ .Env.AZURE_CONTAINER_REGISTRY_ENDPOINT }}'
@@ -12,4 +9,3 @@ param web_containerimage = '{{ .Image }}'
129
param web_containerport = '{{ targetPortOrDefault 8080 }}'
1310
param web_identity_outputs_clientid = '{{ .Env.WEB_IDENTITY_CLIENTID }}'
1411
param web_identity_outputs_id = '{{ .Env.WEB_IDENTITY_ID }}'
15-
param wwwCertificateName = '{{ parameter "wwwCertificateName" }}'

infra/main.bicep

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,6 @@ param location string
1212
@description('Id of the user or app to assign application roles')
1313
param principalId string = ''
1414

15-
param certificateName string
16-
param domainApex string
17-
param domainWww string
18-
param wwwCertificateName string
19-
2015
var tags = {
2116
'azd-env-name': environmentName
2217
}

infra/main.parameters.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,6 @@
55
"principalId": {
66
"value": "${AZURE_PRINCIPAL_ID}"
77
},
8-
"certificateName": {
9-
"value": "copilotthatjawn.com-cae-uanp-250608192822"
10-
},
11-
"domainApex": {
12-
"value": "copilotthatjawn.com"
13-
},
14-
"domainWww": {
15-
"value": "www.copilotthatjawn.com"
16-
},
17-
"wwwCertificateName": {
18-
"value": "www.copilotthatjawn.com-cae-uanp-250608193349"
19-
},
208
"environmentName": {
219
"value": "${AZURE_ENV_NAME}"
2210
},

infra/web/web.module.bicep

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,6 @@ param azure_storage_outputs_tableendpoint string
1919

2020
param web_identity_outputs_clientid string
2121

22-
param certificateName string
23-
24-
param domainApex string
25-
26-
param wwwCertificateName string
27-
28-
param domainWww string
29-
3022
resource web 'Microsoft.App/containerApps@2024-03-01' = {
3123
name: 'web'
3224
location: location
@@ -37,16 +29,17 @@ resource web 'Microsoft.App/containerApps@2024-03-01' = {
3729
external: true
3830
targetPort: int(web_containerport)
3931
transport: 'http'
32+
allowInsecure: false
4033
customDomains: [
4134
{
42-
name: domainApex
43-
bindingType: (certificateName != '') ? 'SniEnabled' : 'Disabled'
44-
certificateId: (certificateName != '') ? '${outputs_azure_container_apps_environment_id}/managedCertificates/${certificateName}' : null
35+
name: 'copilotthatjawn.com'
36+
bindingType: 'SniEnabled'
37+
certificateId: '/subscriptions/09153f92-3cbc-46f1-8872-1683749eda4b/resourceGroups/rg-copilotthatjawn/providers/Microsoft.App/managedEnvironments/cae-uanpydy4xv63a/managedCertificates/copilotthatjawn.com-cae-uanp-250608192822'
4538
}
4639
{
47-
name: domainWww
48-
bindingType: (wwwCertificateName != '') ? 'SniEnabled' : 'Disabled'
49-
certificateId: (wwwCertificateName != '') ? '${outputs_azure_container_apps_environment_id}/managedCertificates/${wwwCertificateName}' : null
40+
name: 'www.copilotthatjawn.com'
41+
bindingType: 'SniEnabled'
42+
certificateId: '/subscriptions/09153f92-3cbc-46f1-8872-1683749eda4b/resourceGroups/rg-copilotthatjawn/providers/Microsoft.App/managedEnvironments/cae-uanpydy4xv63a/managedCertificates/www.copilotthatjawn.com-cae-uanp-250608193349'
5043
}
5144
]
5245
}
@@ -107,4 +100,4 @@ resource web 'Microsoft.App/containerApps@2024-03-01' = {
107100
'${outputs_azure_container_registry_managed_identity_id}': { }
108101
}
109102
}
110-
}
103+
}

0 commit comments

Comments
 (0)