From 238f7df3abad977c8af956d911454315c95cb81b Mon Sep 17 00:00:00 2001 From: Ben Ye Date: Wed, 6 May 2026 05:51:15 +0000 Subject: [PATCH] fix(integration): Fix flaky TestIngesterMetadata by waiting for missing metrics Add e2e.WaitMissingMetrics option to WaitSumMetricsWithOptions calls so the test retries when cortex_ring_members is not yet exposed, rather than failing immediately with 'metric not found'. Signed-off-by: Ben Ye --- integration/ingester_metadata_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/integration/ingester_metadata_test.go b/integration/ingester_metadata_test.go index 0fbbca609f3..ce6fdf62df4 100644 --- a/integration/ingester_metadata_test.go +++ b/integration/ingester_metadata_test.go @@ -47,12 +47,14 @@ func TestIngesterMetadata(t *testing.T) { // Wait until distributor has updated the ring. require.NoError(t, distributor.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_ring_members"}, e2e.WithLabelMatchers( labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"), - labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")))) + labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")), + e2e.WaitMissingMetrics)) // Wait until querier has updated the ring. require.NoError(t, querier.WaitSumMetricsWithOptions(e2e.Equals(1), []string{"cortex_ring_members"}, e2e.WithLabelMatchers( labels.MustNewMatcher(labels.MatchEqual, "name", "ingester"), - labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")))) + labels.MustNewMatcher(labels.MatchEqual, "state", "ACTIVE")), + e2e.WaitMissingMetrics)) client, err := e2ecortex.NewClient(distributor.HTTPEndpoint(), querier.HTTPEndpoint(), "", "", userID) require.NoError(t, err)