Merge pull request #829 from kenjis/fix-ValidationRules-prepareValidFields

fix: cannot register when you remove email from `$validFields`

Author: kenjis

src/Authentication/Passwords/ValidationRules.php

@@ -102,10 +102,9 @@ protected function buildUserFromData(array $data = []): User
      */
     protected function prepareValidFields(): array
     {
-        $config   = config('Auth');
-        $fields   = array_merge($config->validFields, $config->personalFields);
-        $fields[] = 'password';
+        $config = config('Auth');
+        $fields = array_merge($config->validFields, $config->personalFields, ['email', 'password']);
 
-        return $fields;
+        return array_unique($fields);
     }
 }

tests/Controllers/RegisterTest.php

@@ -82,6 +82,16 @@ public function testRegisterActionSuccess(): void
         $this->assertTrue($user->active);
     }
 
+    public function testRegisterActionSuccessWithNoEmailLogin(): void
+    {
+        /** @var Auth $config */
+        $config = config('Auth');
+        // Use `username` for login
+        $config->validFields = ['username'];
+
+        $this->testRegisterActionSuccess();
+    }
+
     public function testRegisterTooLongPasswordDefault(): void
     {
         $result = $this->withSession()->post('/register', [