refactor: Fix phpstan condNotBoolean (#9368)

neznaika0 · web-flow · commit db12ec3cbfce · 2025-01-04T17:54:40.000+08:00
diff --git a/system/CLI/CLI.php b/system/CLI/CLI.php
@@ -289,7 +289,7 @@ public static function promptByKey($text, array $options, $validation = null): s
 
         CLI::isZeroOptions($options);
 
-        if ($line = array_shift($text)) {
+        if (($line = array_shift($text)) !== null) {
             CLI::write($line);
         }
 
diff --git a/utils/phpstan-baseline/if.condNotBoolean.neon b/utils/phpstan-baseline/if.condNotBoolean.neon
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -21,7 +21,6 @@ includes:
     - generator.returnType.neon
     - generator.valueType.neon
     - greaterOrEqual.invalid.neon
-    - if.condNotBoolean.neon
     - isset.offset.neon
     - isset.property.neon
     - method.alreadyNarrowedType.neon

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ public static function promptByKey($text, array $options, $validation = null): s`
`289`	`289`
`290`	`290`	`CLI::isZeroOptions($options);`
`291`	`291`
`292`		`- if ($line = array_shift($text)) {`
	`292`	`+ if (($line = array_shift($text)) !== null) {`
`293`	`293`	`CLI::write($line);`
`294`	`294`	`}`
`295`	`295`