feat(app): Add config setting to use controller attributes or not

Author: lonnieezell

app/Config/Routing.php

@@ -96,6 +96,15 @@ class Routing extends BaseRouting
      */
     public bool $autoRoute = false;
 
+    /**
+     * If TRUE, the system will look for attributes on controller
+     * class and methods that can run before and after the
+     * controller/method.
+     *
+     * If FALSE, will ignore any attributes.
+     */
+    public bool $useControllerAttributes = true;
+
     /**
      * For Defined Routes.
      * If TRUE, will enable the use of the 'prioritize' option

system/CodeIgniter.php

@@ -502,9 +502,11 @@ protected function handleRequest(?RouteCollectionInterface $routes, Cache $cache
         }
 
         // Execute controller attributes' after() methods AFTER framework filters
-        $this->benchmark->start('route_attributes_after');
-        $this->response = $this->router->executeAfterAttributes($this->request, $this->response);
-        $this->benchmark->stop('route_attributes_after');
+        if (config('routing')->useControllerAttributes === true) {
+            $this->benchmark->start('route_attributes_after');
+            $this->response = $this->router->executeAfterAttributes($this->request, $this->response);
+            $this->benchmark->stop('route_attributes_after');
+        }
 
         // Skip unnecessary processing for special Responses.
         if (
@@ -866,21 +868,23 @@ protected function startController()
 
         // Execute route attributes' before() methods
         // This runs after routing/validation but BEFORE expensive controller instantiation
-        $this->benchmark->start('route_attributes_before');
-        $attributeResponse = $this->router->executeBeforeAttributes($this->request);
-        $this->benchmark->stop('route_attributes_before');
-
-        // If attribute returns a Response, short-circuit
-        if ($attributeResponse instanceof ResponseInterface) {
-            $this->benchmark->stop('controller_constructor');
-            $this->benchmark->stop('controller');
+        if (config('routing')->useControllerAttributes === true) {
+            $this->benchmark->start('route_attributes_before');
+            $attributeResponse = $this->router->executeBeforeAttributes($this->request);
+            $this->benchmark->stop('route_attributes_before');
+
+            // If attribute returns a Response, short-circuit
+            if ($attributeResponse instanceof ResponseInterface) {
+                $this->benchmark->stop('controller_constructor');
+                $this->benchmark->stop('controller');
 
-            return $attributeResponse;
-        }
+                return $attributeResponse;
+            }
 
-        // If attribute returns a modified Request, use it
-        if ($attributeResponse instanceof Request) {
-            $this->request = $attributeResponse;
+            // If attribute returns a modified Request, use it
+            if ($attributeResponse instanceof Request) {
+                $this->request = $attributeResponse;
+            }
         }
 
         return null;

system/Config/Routing.php

@@ -96,6 +96,15 @@ class Routing extends BaseConfig
      */
     public bool $autoRoute = false;
 
+    /**
+     * If TRUE, the system will look for attributes on controller
+     * class and methods that can run before and after the
+     * controller/method.
+     *
+     * If FALSE, will ignore any attributes.
+     */
+    public bool $useControllerAttributes = true;
+
     /**
      * For Defined Routes.
      * If TRUE, will enable the use of the 'prioritize' option

system/Router/Router.php

@@ -779,6 +779,11 @@ private function processRouteAttributes(): void
     {
         $this->routeAttributes = ['class' => [], 'method' => []];
 
+        // Skip if controller attributes are disabled in config
+        if (config('routing')->useControllerAttributes === false) {
+            return;
+        }
+
         // Skip if controller is a Closure
         if ($this->controller instanceof Closure) {
             return;

tests/system/CodeIgniterTest.php

@@ -14,6 +14,7 @@
 namespace CodeIgniter;
 
 use App\Controllers\Home;
+use CodeIgniter\Config\Factories;
 use CodeIgniter\Config\Services;
 use CodeIgniter\Debug\Timer;
 use CodeIgniter\Exceptions\PageNotFoundException;
@@ -43,7 +44,7 @@
  */
 #[BackupGlobals(true)]
 #[Group('Others')]
-#[RunTestsInSeparateProcesses]
+// #[RunTestsInSeparateProcesses]
 final class CodeIgniterTest extends CIUnitTestCase
 {
     private CodeIgniter $codeigniter;
@@ -1187,4 +1188,47 @@ public function testRouteAttributeCustomCacheKeyIntegration(): void
         // Clear cache after test
         cache()->clean();
     }
+
+    public function testRouteAttributesDisabledInConfig(): void
+    {
+        Services::superglobals()->setServer('REQUEST_URI', '/attribute/filtered');
+        Services::superglobals()->setServer('SCRIPT_NAME', '/index.php');
+        Services::superglobals()->setServer('REQUEST_METHOD', 'GET');
+
+        // Disable route attributes in config BEFORE creating CodeIgniter instance
+        $routing = config('routing');
+        $routing->useControllerAttributes = false;
+        Factories::injectMock('config', 'routing', $routing);
+
+        // Register the test filter (even though attributes are disabled,
+        // we need it registered to avoid FilterException)
+        $filterConfig                                 = config('Filters');
+        $filterConfig->aliases['testAttributeFilter'] = TestAttributeFilter::class;
+        service('filters', $filterConfig);
+
+        $routes = service('routes');
+        $routes->setAutoRoute(false);
+
+        // We're testing that a route defined normally will work,
+        // but the attributes on the controller method won't be processed
+        $routes->get('attribute/filtered', '\Tests\Support\Router\Controllers\AttributeController::filtered');
+
+        $router = service('router', $routes, service('incomingrequest'));
+        Services::injectMock('router', $router);
+
+        $config = new App();
+        $codeigniter = new MockCodeIgniter($config);
+
+        ob_start();
+        $codeigniter->run($routes);
+        $output = ob_get_clean();
+
+
+        // When useRouteAttributes is false, the filter attributes should NOT be processed
+        // So the filter should not have run
+        $this->assertStringNotContainsString('before_filter_ran', (string) $output);
+        $this->assertStringNotContainsString('after_filter_ran', (string) $output);
+        // But the controller method should still execute
+        $this->assertStringContainsString('Filtered', (string) $output);
+    }
 }

user_guide_src/source/incoming/controller_attributes.rst

@@ -25,6 +25,11 @@ You can also apply the ``Filters`` attribute to a specific method within a contr
 
 Class-level and method-level attributes can work together to provide a flexible way to manage your routes at the controller level.
 
+Disabling Attributes
+--------------------
+
+If you know that you will not be using attributes in your application, you can disable the feature by setting the ``$useControllerAttributes`` property in your ``app/Config/Routing.php`` file to ``false``.
+
 Provided Attributes
 *******************