fix: Entity::normalizeValue() must handle UnitEnum before toArray() (#5)

* fix: Entity::normalizeValue() must handle UnitEnum before toArray()

Moves the `UnitEnum` instanceof check before `JsonSerializable` and
`method_exists($data, 'toArray')` in Entity::normalizeValue(), so that
enums implementing toArray() are always normalized as enums rather than
as generic objects.

Fixes #10136

Agent-Logs-Url: https://github.com/maniaba/CodeIgniter4/sessions/d5c8c660-329b-4872-8633-dd918674e4ac

Co-authored-by: maniaba <[email protected]>

* fix test: correct toRawArray() assertion for injected enum

toRawArray() returns raw $this->attributes, so an injected enum object
stays as an enum object — not the backing string value. The real
regression is that hasChanged() must return false (normalizeValue()
handles UnitEnum before toArray()).

Fixes the failing test from the previous commit.

Agent-Logs-Url: https://github.com/maniaba/CodeIgniter4/sessions/d86b9a68-aee9-4178-a8b8-cf1bac285359

Co-authored-by: maniaba <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: maniaba <[email protected]>

Author: Copilot

system/Entity/Entity.php

@@ -458,6 +458,11 @@ private function normalizeValue(mixed $data): mixed
             // Check for Entity instance (use raw values, recursive)
             if ($data instanceof self) {
                 $objectData = $data->toRawArray(false, true);
+            } elseif ($data instanceof UnitEnum) {
+                return [
+                    '__class' => $data::class,
+                    '__enum'  => $data instanceof BackedEnum ? $data->value : $data->name,
+                ];
             } elseif ($data instanceof JsonSerializable) {
                 $objectData = $data->jsonSerialize();
             } elseif (method_exists($data, 'toArray')) {
@@ -469,11 +474,6 @@ private function normalizeValue(mixed $data): mixed
                     '__class'    => $data::class,
                     '__datetime' => $data->format(DATE_RFC3339_EXTENDED),
                 ];
-            } elseif ($data instanceof UnitEnum) {
-                return [
-                    '__class' => $data::class,
-                    '__enum'  => $data instanceof BackedEnum ? $data->value : $data->name,
-                ];
             } else {
                 $objectData = get_object_vars($data);
 

tests/_support/Enum/StateEnum.php

@@ -0,0 +1,29 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * This file is part of CodeIgniter 4 framework.
+ *
+ * (c) CodeIgniter Foundation <[email protected]>
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE file that was distributed with this source code.
+ */
+
+namespace Tests\Support\Enum;
+
+/**
+ * An enum that also defines toArray(), used to test that UnitEnum handling
+ * takes precedence over toArray() in Entity::normalizeValue().
+ */
+enum StateEnum: string
+{
+    case DRAFT     = 'draft';
+    case PUBLISHED = 'published';
+
+    public function toArray(): array
+    {
+        return array_column(self::cases(), 'value');
+    }
+}

tests/system/Entity/EntityTest.php

@@ -35,6 +35,7 @@
 use Tests\Support\Entity\Cast\NotExtendsBaseCast;
 use Tests\Support\Enum\ColorEnum;
 use Tests\Support\Enum\RoleEnum;
+use Tests\Support\Enum\StateEnum;
 use Tests\Support\Enum\StatusEnum;
 use Tests\Support\SomeEntity;
 
@@ -1045,6 +1046,24 @@ public function testCastEnumSetWithUnitEnumObject(): void
         $this->assertSame(ColorEnum::RED, $entity->color);
     }
 
+    public function testInjectRawDataWithEnumThatHasToArrayMethod(): void
+    {
+        // Regression test for https://github.com/codeigniter4/CodeIgniter4/issues/10136
+        // Enums implementing toArray() must still be handled by the UnitEnum branch in
+        // normalizeValue(), so hasChanged() does not incorrectly report a change after
+        // injectRawData() stores the same enum value.
+        $entity = new class () extends Entity {};
+
+        $entity->injectRawData(['state' => StateEnum::DRAFT]);
+
+        // toRawArray() returns raw attributes, so the enum object is returned as-is.
+        $this->assertSame(StateEnum::DRAFT, $entity->toRawArray()['state']);
+
+        // The key assertion: normalizeValue() must treat the enum as a UnitEnum
+        // (not call toArray() on it), so the original and current normalized forms match.
+        $this->assertFalse($entity->hasChanged('state'));
+    }
+
     public function testAsArray(): void
     {
         $entity = $this->getEntity();