refactor: Optional DataCaster creation in Entity

Author: neznaika0

system/Entity/Entity.php

@@ -127,7 +127,7 @@ class Entity implements JsonSerializable
     /**
      * The data caster.
      */
-    protected DataCaster $dataCaster;
+    protected ?DataCaster $dataCaster = null;
 
     /**
      * Holds info whenever properties have to be casted.
@@ -146,12 +146,7 @@ class Entity implements JsonSerializable
      */
     public function __construct(?array $data = null)
     {
-        $this->dataCaster = new DataCaster(
-            array_merge($this->defaultCastHandlers, $this->castHandlers),
-            null,
-            null,
-            false,
-        );
+        $this->dataCaster = $this->dataCaster();
 
         $this->syncOriginal();
 
@@ -568,10 +563,37 @@ protected function mutateDate($value)
      */
     protected function castAs($value, string $attribute, string $method = 'get')
     {
-        return $this->dataCaster
-            // @TODO if $casts is readonly, we don't need the setTypes() method.
-            ->setTypes($this->casts)
-            ->castAs($value, $attribute, $method);
+        if ($this->dataCaster() instanceof DataCaster) {
+            return $this->dataCaster
+                // @TODO if $casts is readonly, we don't need the setTypes() method.
+                ->setTypes($this->casts)
+                ->castAs($value, $attribute, $method);
+        }
+
+        return $value;
+    }
+
+    /**
+     * This method allows you to refuse to contain an unnecessary DataCaster if you do not use casting.
+     */
+    protected function dataCaster(): ?DataCaster
+    {
+        if (! $this->_cast) {
+            $this->dataCaster = null;
+
+            return null;
+        }
+
+        if (! $this->dataCaster instanceof DataCaster) {
+            $this->dataCaster = new DataCaster(
+                array_merge($this->defaultCastHandlers, $this->castHandlers),
+                null,
+                null,
+                false,
+            );
+        }
+
+        return $this->dataCaster;
     }
 
     /**
@@ -598,6 +620,9 @@ public function cast(?bool $cast = null)
 
         $this->_cast = $cast;
 
+        // Synchronize option with DataCaster initialization
+        $this->dataCaster();
+
         return $this;
     }
 

tests/system/Entity/EntityTest.php

@@ -16,6 +16,7 @@
 use ArrayIterator;
 use ArrayObject;
 use Closure;
+use CodeIgniter\DataCaster\DataCaster;
 use CodeIgniter\Entity\Exceptions\CastException;
 use CodeIgniter\HTTP\URI;
 use CodeIgniter\I18n\Time;
@@ -1485,6 +1486,39 @@ public function testJsonSerializableEntity(): void
         $this->assertSame(json_encode($entity->toArray()), json_encode($entity));
     }
 
+    public function testDataCasterInit(): void
+    {
+        $entity = new class () extends Entity {
+            protected $attributes = [
+                'first' => '12345',
+            ];
+            protected $casts = [
+                'first' => 'integer',
+            ];
+        };
+
+        $getDataCaster = $this->getPrivateMethodInvoker($entity, 'dataCaster');
+
+        $this->assertInstanceOf(DataCaster::class, $getDataCaster());
+        $this->assertInstanceOf(DataCaster::class, $this->getPrivateProperty($entity, 'dataCaster'));
+        $this->assertSame(12345, $entity->first);
+
+        // Disable casting, do not load DataCaster
+        $entity->cast(false);
+        $this->assertNull($getDataCaster());
+        $this->assertNull($this->getPrivateProperty($entity, 'dataCaster'));
+        $this->assertIsString($entity->first);
+
+        // Method castAs() depends on the $_cast option
+        $this->assertSame('12345', $this->getPrivateMethodInvoker($entity, 'castAs')('12345', 'first'));
+
+        // Restore casting
+        $entity->cast(true);
+        $this->assertInstanceOf(DataCaster::class, $getDataCaster());
+        $this->assertInstanceOf(DataCaster::class, $this->getPrivateProperty($entity, 'dataCaster'));
+        $this->assertSame(12345, $entity->first);
+    }
+
     private function getEntity(): object
     {
         return new class () extends Entity {

user_guide_src/source/changelogs/v4.7.0.rst

@@ -111,6 +111,13 @@ parameter is ``true``. Previously, properties containing arrays were not recursi
 If you were relying on the old behavior where arrays remained unconverted, you will need to update
 your code.
 
+Entity and DataCaster
+---------------------
+
+Previously, the ``DataCaster`` object was always initialized, even if you did not use the ``$_cast = false`` type casting.
+Now, the object is created on-demand and deleted when type casting is disabled.
+In general, the change does not break the existing process, it should be remembered that now in some cases ``$dataCaster`` may be nullable.
+
 Encryption Handlers
 -------------------
 
@@ -302,6 +309,7 @@ Changes
 *******
 
 - **Cookie:** The ``CookieInterface::EXPIRES_FORMAT`` has been changed to ``D, d M Y H:i:s T`` to follow the recommended format in RFC 7231.
+- **Entity:** The protected property ``CodeIgniter\Entity\Entity::$dataCaster`` can be nullable.
 - **Format:** Added support for configuring ``json_encode()`` maximum depth via ``Config\Format::$jsonEncodeDepth``.
 - **Paths:** Added support for changing the location of the ``.env`` file via the ``Paths::$envDirectory`` property.
 - **Toolbar:** Added ``$disableOnHeaders`` property to **app/Config/Toolbar.php**.