move legacy command fixtures

paulbalandan · paulbalandan · commit 849266c772ad · 2026-04-22T21:43:16.000+08:00
diff --git a/rector.php b/rector.php
@@ -83,7 +83,7 @@
         __DIR__ . '/system/ThirdParty',
         __DIR__ . '/tests/system/Config/fixtures',
         __DIR__ . '/tests/system/Filters/fixtures',
-        __DIR__ . '/tests/_support/Commands/Foobar.php',
+        __DIR__ . '/tests/_support/Commands/Legacy/Foobar.php',
         __DIR__ . '/tests/_support/View',
         __DIR__ . '/tests/system/View/Views',
 
diff --git a/tests/_support/Commands/Legacy/AbstractInfo.php b/tests/_support/Commands/Legacy/AbstractInfo.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 
diff --git a/tests/_support/Commands/Legacy/AppInfo.php b/tests/_support/Commands/Legacy/AppInfo.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\CLI;
@@ -50,6 +50,6 @@ public function bomb(): int
 
     public function helpMe(): int
     {
-        return $this->call('help');
+        return $this->call('help:legacy');
     }
 }
diff --git a/tests/_support/Commands/Legacy/DestructiveCommand.php b/tests/_support/Commands/Legacy/DestructiveCommand.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use RuntimeException;
 
diff --git a/tests/_support/Commands/Legacy/Foobar.php b/tests/_support/Commands/Legacy/Foobar.php
diff --git a/tests/_support/Commands/Legacy/InvalidCommand.php b/tests/_support/Commands/Legacy/InvalidCommand.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\CLI;
@@ -26,7 +26,7 @@ class InvalidCommand extends BaseCommand
 
     public function __construct()
     {
-        throw new ReflectionException();
+        throw new ReflectionException('This command is invalid and should not be instantiated.');
     }
 
     public function run(array $params): int
diff --git a/tests/_support/Commands/Legacy/LanguageCommand.php b/tests/_support/Commands/Legacy/LanguageCommand.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\GeneratorTrait;
diff --git a/tests/_support/Commands/Legacy/SignalCommand.php b/tests/_support/Commands/Legacy/SignalCommand.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\SignalTrait;
diff --git a/tests/_support/Commands/Legacy/SignalCommandNoPcntl.php b/tests/_support/Commands/Legacy/SignalCommandNoPcntl.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 /**
  * Mock command that simulates missing PCNTL extension
diff --git a/tests/_support/Commands/Legacy/SignalCommandNoPosix.php b/tests/_support/Commands/Legacy/SignalCommandNoPosix.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 /**
  * Mock command that simulates missing POSIX extension
diff --git a/tests/_support/Commands/Legacy/Unsuffixable.php b/tests/_support/Commands/Legacy/Unsuffixable.php
@@ -11,7 +11,7 @@
  * the LICENSE file that was distributed with this source code.
  */
 
-namespace Tests\Support\Commands;
+namespace Tests\Support\Commands\Legacy;
 
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\GeneratorTrait;
diff --git a/tests/_support/_command/AppInfo.php b/tests/_support/_command/AppInfo.php
@@ -19,7 +19,7 @@
 /**
  * @internal
  */
-final class ListCommands extends BaseCommand
+final class AppInfo extends BaseCommand
 {
     /**
      * @var string
@@ -29,17 +29,17 @@ final class ListCommands extends BaseCommand
     /**
      * @var string
      */
-    protected $name = 'list';
+    protected $name = 'app:info';
 
     /**
      * @var string
      */
-    protected $description = 'This is testing to override `list` command.';
+    protected $description = 'This is testing to override `app:info` command.';
 
     /**
      * @var string
      */
-    protected $usage = 'list';
+    protected $usage = 'app:info';
 
     /**
      * Displays the help for the spark cli script itself.
diff --git a/tests/system/CLI/BaseCommandTest.php b/tests/system/CLI/BaseCommandTest.php
@@ -22,7 +22,7 @@
 use PHPUnit\Framework\Attributes\Before;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Group;
-use Tests\Support\Commands\AppInfo;
+use Tests\Support\Commands\Legacy\AppInfo;
 
 /**
  * @internal
diff --git a/tests/system/CLI/SignalTest.php b/tests/system/CLI/SignalTest.php
@@ -17,9 +17,9 @@
 use CodeIgniter\Test\CIUnitTestCase;
 use CodeIgniter\Test\StreamFilterTrait;
 use PHPUnit\Framework\Attributes\Group;
-use Tests\Support\Commands\SignalCommand;
-use Tests\Support\Commands\SignalCommandNoPcntl;
-use Tests\Support\Commands\SignalCommandNoPosix;
+use Tests\Support\Commands\Legacy\SignalCommand;
+use Tests\Support\Commands\Legacy\SignalCommandNoPcntl;
+use Tests\Support\Commands\Legacy\SignalCommandNoPosix;
 
 /**
  * @internal
diff --git a/tests/system/Commands/ConfigurableSortImportsTest.php b/tests/system/Commands/ConfigurableSortImportsTest.php
@@ -32,7 +32,7 @@ public function testPublishLanguageWithoutOptions(): void
         $file = APPPATH . 'Language/en/Foobar.php';
         $this->assertStringContainsString('File created: ', $this->getStreamFilterBuffer());
         $this->assertFileExists($file);
-        $this->assertNotSame(sha1_file(SUPPORTPATH . 'Commands/Foobar.php'), sha1_file($file));
+        $this->assertNotSame(sha1_file(SUPPORTPATH . 'Commands/Legacy/Foobar.php'), sha1_file($file));
         if (is_file($file)) {
             unlink($file);
         }
@@ -45,7 +45,7 @@ public function testEnabledSortImportsWillDisruptLanguageFilePublish(): void
         $file = APPPATH . 'Language/es/Foobar.php';
         $this->assertStringContainsString('File created: ', $this->getStreamFilterBuffer());
         $this->assertFileExists($file);
-        $this->assertNotSame(sha1_file(SUPPORTPATH . 'Commands/Foobar.php'), sha1_file($file));
+        $this->assertNotSame(sha1_file(SUPPORTPATH . 'Commands/Legacy/Foobar.php'), sha1_file($file));
         if (is_file($file)) {
             unlink($file);
         }
@@ -62,7 +62,7 @@ public function testDisabledSortImportsWillNotAffectLanguageFilesPublish(): void
         $file = APPPATH . 'Language/ar/Foobar.php';
         $this->assertStringContainsString('File created: ', $this->getStreamFilterBuffer());
         $this->assertFileExists($file);
-        $this->assertSame(sha1_file(SUPPORTPATH . 'Commands/Foobar.php'), sha1_file($file));
+        $this->assertSame(sha1_file(SUPPORTPATH . 'Commands/Legacy/Foobar.php'), sha1_file($file));
         if (is_file($file)) {
             unlink($file);
         }
diff --git a/utils/src/PhpCsFixer/CodeIgniterRuleCustomisationPolicy.php b/utils/src/PhpCsFixer/CodeIgniterRuleCustomisationPolicy.php
@@ -43,7 +43,7 @@ public function getRuleCustomisers(): array
             ),
             'ordered_imports' => static fn (SplFileInfo $file): bool => ! $normalisedStrEndsWith(
                 $file->getPathname(),
-                '/tests/_support/Commands/Foobar.php',
+                '/tests/_support/Commands/Legacy/Foobar.php',
             ),
         ];
     }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* the LICENSE file that was distributed with this source code.`
`12`	`12`	`*/`
`13`	`13`
`14`		`-namespace Tests\Support\Commands;`
	`14`	`+namespace Tests\Support\Commands\Legacy;`
`15`	`15`
`16`	`16`	`use CodeIgniter\CLI\BaseCommand;`
`17`	`17`	`use CodeIgniter\CLI\CLI;`
`@@ -50,6 +50,6 @@ public function bomb(): int`
`50`	`50`
`51`	`51`	`public function helpMe(): int`
`52`	`52`	`{`
`53`		`- return $this->call('help');`
	`53`	`+ return $this->call('help:legacy');`
`54`	`54`	`}`
`55`	`55`	`}`