PHPStand baseline

Author: lonnieezell

composer.json

@@ -117,7 +117,7 @@
         "phpstan:baseline": [
             "bash -c \"rm -rf utils/phpstan-baseline/*.neon\"",
             "bash -c \"touch utils/phpstan-baseline/loader.neon\"",
-            "phpstan analyse --ansi --generate-baseline=utils/phpstan-baseline/loader.neon",
+            "phpstan analyse --ansi --memory-limit=512M --generate-baseline=utils/phpstan-baseline/loader.neon",
             "split-phpstan-baseline utils/phpstan-baseline/loader.neon"
         ],
         "phpstan:check": "vendor/bin/phpstan analyse --verbose --ansi --memory-limit=512M",

utils/phpstan-baseline/isset.property.neon

@@ -0,0 +1,43 @@
+# total 8 errors
+
+parameters:
+    ignoreErrors:
+        -
+            message: '#^Property CodeIgniter\\CLI\\BaseCommand\:\:\$description \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../system/CLI/BaseCommand.php
+
+        -
+            message: '#^Property CodeIgniter\\CLI\\BaseCommand\:\:\$usage \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../system/CLI/BaseCommand.php
+
+        -
+            message: '#^Property CodeIgniter\\CLI\\BaseCommand\:\:\$group \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../system/CLI/Commands.php
+
+        -
+            message: '#^Property CodeIgniter\\Database\\BaseConnection\<mysqli,mysqli_result\>\:\:\$strictOn \(bool\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../system/Database/MySQLi/Connection.php
+
+        -
+            message: '#^Property CodeIgniter\\Database\\BaseConnection\<SQLite3,SQLite3Result\>\:\:\$password \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../system/Database/SQLite3/Connection.php
+
+        -
+            message: '#^Property CodeIgniter\\CLI\\BaseCommand\:\:\$group \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/Commands/BaseCommandTest.php
+
+        -
+            message: '#^Property CodeIgniter\\Database\\BaseConnection\<object\|resource,object\|resource\>\:\:\$charset \(string\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/Database/BaseConnectionTest.php
+
+        -
+            message: '#^Property CodeIgniter\\I18n\\TimeDifference\:\:\$days \(float\|int\) in isset\(\) is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/I18n/TimeDifferenceTest.php

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 2795 errors
+# total 2808 errors
 
 includes:
     - argument.type.neon
@@ -10,6 +10,7 @@ includes:
     - codeigniter.superglobalAccessAssign.neon
     - deadCode.unreachable.neon
     - empty.notAllowed.neon
+    - isset.property.neon
     - method.alreadyNarrowedType.neon
     - method.childParameterType.neon
     - method.childReturnType.neon

utils/phpstan-baseline/method.alreadyNarrowedType.neon

@@ -1,4 +1,4 @@
-# total 22 errors
+# total 24 errors
 
 parameters:
     ignoreErrors:
@@ -22,6 +22,11 @@ parameters:
             count: 1
             path: ../../tests/system/CodeIgniterTest.php
 
+        -
+            message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
+            count: 1
+            path: ../../tests/system/Commands/BaseCommandTest.php
+
         -
             message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertIsBool\(\) with bool will always evaluate to true\.$#'
             count: 1
@@ -32,6 +37,11 @@ parameters:
             count: 2
             path: ../../tests/system/Config/FactoriesTest.php
 
+        -
+            message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
+            count: 1
+            path: ../../tests/system/Database/BaseConnectionTest.php
+
         -
             message: '#^Call to method PHPUnit\\Framework\\Assert\:\:assertTrue\(\) with true will always evaluate to true\.$#'
             count: 2

utils/phpstan-baseline/nullCoalesce.property.neon

@@ -1,4 +1,4 @@
-# total 8 errors
+# total 11 errors
 
 parameters:
     ignoreErrors:
@@ -27,6 +27,21 @@ parameters:
             count: 1
             path: ../../system/Throttle/Throttler.php
 
+        -
+            message: '#^Property CodeIgniter\\HomeTest\:\:\$session \(array\<int\|string, mixed\>\) on left side of \?\? is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/HomeTest.php
+
+        -
+            message: '#^Property CodeIgniter\\Test\\FeatureTestAutoRoutingImprovedTest\:\:\$session \(array\<int\|string, mixed\>\) on left side of \?\? is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/Test/FeatureTestAutoRoutingImprovedTest.php
+
+        -
+            message: '#^Property CodeIgniter\\Test\\FeatureTestTraitTest\:\:\$session \(array\<int\|string, mixed\>\) on left side of \?\? is not nullable\.$#'
+            count: 1
+            path: ../../tests/system/Test/FeatureTestTraitTest.php
+
         -
             message: '#^Property CodeIgniter\\Test\\FilterTestTraitTest\:\:\$request \(CodeIgniter\\HTTP\\RequestInterface\) on left side of \?\?\= is not nullable\.$#'
             count: 1