Apply suggested changes

Author: patel-vansh

app/Config/Logger.php

@@ -65,7 +65,7 @@ class Logger extends BaseConfig
      * **NOTE:** This **DOES NOT** include any data that has been marked as hidden
      * using the `setHidden()` method of the Context class.
      */
-    public bool $logGlobalContext = false;
+    public bool $logGlobalContext = true;
 
     /**
      * --------------------------------------------------------------------------

system/Context/Context.php

@@ -13,6 +13,8 @@
 
 namespace CodeIgniter\Context;
 
+use CodeIgniter\Helpers\Array\ArrayHelper;
+
 class Context
 {
     /**
@@ -82,6 +84,7 @@ public function setHidden(array|string $key, mixed $value = null): self
 
     /**
      * Get a value from the context by its key, or return a default value if the key does not exist.
+     * Supports dot notation for nested arrays (e.g., 'user.profile.name' to access $data['user']['profile']['name']).
      *
      * @param string     $key     The key to identify the data.
      * @param mixed|null $default The default value to return if the key does not exist in the context.
@@ -90,7 +93,7 @@ public function setHidden(array|string $key, mixed $value = null): self
      */
     public function get(string $key, mixed $default = null): mixed
     {
-        return $this->data[$key] ?? $default;
+        return ArrayHelper::dotSearch($key, $this->data) ?? $default;
     }
 
     /**
@@ -145,7 +148,7 @@ public function getAll(): array
      */
     public function getHidden(string $key, mixed $default = null): mixed
     {
-        return $this->hiddenData[$key] ?? $default;
+        return ArrayHelper::dotSearch($key, $this->hiddenData) ?? $default;
     }
 
     /**
@@ -190,18 +193,6 @@ public function getAllHidden(): array
         return $this->hiddenData;
     }
 
-    /**
-     * Check if a key does not exist in the context. Exactly the opposite of `has()`.
-     *
-     * @param string $key The key to check for non-existence in the context.
-     *
-     * @return bool True if the key does not exist in the context, false otherwise.
-     */
-    public function missing(string $key): bool
-    {
-        return ! $this->has($key);
-    }
-
     /**
      * Check if a key exists in the context.
      *
@@ -211,19 +202,7 @@ public function missing(string $key): bool
      */
     public function has(string $key): bool
     {
-        return array_key_exists($key, $this->data);
-    }
-
-    /**
-     * Check if a key does not exist in the hidden context. Exactly the opposite of `hasHidden()`.
-     *
-     * @param string $key The key to check for non-existence in the hidden context.
-     *
-     * @return bool True if the key does not exist in the hidden context, false otherwise.
-     */
-    public function missingHidden(string $key): bool
-    {
-        return ! $this->hasHidden($key);
+        return ArrayHelper::dotKeyExists($key, $this->data);
     }
 
     /**
@@ -235,7 +214,7 @@ public function missingHidden(string $key): bool
      */
     public function hasHidden(string $key): bool
     {
-        return array_key_exists($key, $this->hiddenData);
+        return ArrayHelper::dotKeyExists($key, $this->hiddenData);
     }
 
     /**

system/Log/Logger.php

@@ -121,7 +121,7 @@ class Logger implements LoggerInterface
      *
      * @var bool
      */
-    protected $logGlobalContext;
+    protected bool $logGlobalContext = true;
 
     /**
      * Constructor.
@@ -164,7 +164,7 @@ public function __construct($config, bool $debug = CI_DEBUG)
             $this->logCache = [];
         }
 
-        $this->logGlobalContext = $config->logGlobalContext;
+        $this->logGlobalContext = $config->logGlobalContext ?? $this->logGlobalContext;
     }
 
     /**
@@ -265,7 +265,7 @@ public function log($level, string|Stringable $message, array $context = []): vo
 
         if ($this->logGlobalContext) {
             $globalContext = service('context')->getAll();
-            if (is_array($globalContext) && $globalContext !== []) {
+            if ($globalContext !== []) {
                 $message .= ' ' . json_encode($globalContext);
             }
         }

tests/system/Context/ContextTest.php

@@ -328,15 +328,6 @@ public function testHasKey(): void
         $this->assertTrue($context->has('user_id'));
     }
 
-    public function testMissingKey(): void
-    {
-        $context = service('context');
-        $this->assertTrue($context->missing('user_id'));
-
-        $context->set('user_id', 123);
-        $this->assertFalse($context->missing('user_id'));
-    }
-
     public function testHasHiddenKey(): void
     {
         $context = service('context');
@@ -346,15 +337,6 @@ public function testHasHiddenKey(): void
         $this->assertTrue($context->hasHidden('api_key'));
     }
 
-    public function testMissingHiddenKey(): void
-    {
-        $context = service('context');
-        $this->assertTrue($context->missingHidden('api_key'));
-
-        $context->setHidden('api_key', 'secret');
-        $this->assertFalse($context->missingHidden('api_key'));
-    }
-
     public function testRemoveSingleValue(): void
     {
         $context = service('context');

user_guide_src/source/general/context.rst

@@ -94,10 +94,6 @@ You can check if a key exists in the context:
 
 .. literalinclude:: context/010.php
 
-Or check if a key is missing (the opposite of ``has()``):
-
-.. literalinclude:: context/011.php
-
 *********************
 Removing Context Data
 *********************
@@ -107,21 +103,21 @@ Removing a Single Value
 
 You can remove data from the context using the ``remove()`` method:
 
-.. literalinclude:: context/012.php
+.. literalinclude:: context/011.php
 
 Removing Multiple Values
 =========================
 
 To remove multiple keys at once, pass an array:
 
-.. literalinclude:: context/013.php
+.. literalinclude:: context/012.php
 
 Clearing All Data
 =================
 
 To remove all context data:
 
-.. literalinclude:: context/014.php
+.. literalinclude:: context/013.php
 
 *********************
 Hidden Context Data
@@ -136,47 +132,47 @@ Setting Hidden Data
 
 Use the ``setHidden()`` method to store sensitive data:
 
-.. literalinclude:: context/015.php
+.. literalinclude:: context/014.php
 
 You can also set multiple hidden values at once:
 
-.. literalinclude:: context/016.php
+.. literalinclude:: context/015.php
 
 Getting Hidden Data
 ===================
 
 Retrieve hidden data using ``getHidden()``:
 
-.. literalinclude:: context/017.php
+.. literalinclude:: context/016.php
 
 The same methods available for regular data also work with hidden data:
 
-.. literalinclude:: context/018.php
+.. literalinclude:: context/017.php
 
 Checking Hidden Data
 ====================
 
 Check if a hidden key exists:
 
-.. literalinclude:: context/019.php
+.. literalinclude:: context/018.php
 
 Removing Hidden Data
 ====================
 
 Remove hidden data using ``removeHidden()``:
 
-.. literalinclude:: context/020.php
+.. literalinclude:: context/019.php
 
 Clearing Hidden Data
 ====================
 
 To clear all hidden data without affecting regular context data:
 
-.. literalinclude:: context/021.php
+.. literalinclude:: context/020.php
 
 To clear both regular and hidden data:
 
-.. literalinclude:: context/022.php
+.. literalinclude:: context/021.php
 
 .. important:: Regular data and hidden data are stored separately. A key can exist in both regular and hidden storage with different values. Use ``get()`` for regular data and ``getHidden()`` for hidden data.
 
@@ -193,11 +189,11 @@ Enabling Global Context Logging
 To enable automatic logging of context data, set the ``$logGlobalContext`` property to ``true`` in your
 **app/Config/Logger.php** file:
 
-.. literalinclude:: context/023.php
+.. literalinclude:: context/022.php
 
 When enabled, all context data (excluding hidden data) will be automatically appended to your log messages as JSON:
 
-.. literalinclude:: context/024.php
+.. literalinclude:: context/023.php
 
 This would produce a log entry like:
 

user_guide_src/source/general/context/011.php

@@ -1,5 +1,3 @@
 <?php
 
-if ($context->missing('user_id')) {
-    // user_id hasn't been set yet
-}
+$context->remove('user_id');

user_guide_src/source/general/context/012.php

@@ -1,3 +1,3 @@
 <?php
 
-$context->remove('user_id');
+$context->remove(['user_id', 'username', 'request_id']);

user_guide_src/source/general/context/013.php

@@ -1,3 +1,3 @@
 <?php
 
-$context->remove(['user_id', 'username', 'request_id']);
+$context->clear();

user_guide_src/source/general/context/014.php

@@ -1,3 +1,3 @@
 <?php
 
-$context->clear();
+$context->setHidden('api_key', 'sk_live_abc123xyz789');

user_guide_src/source/general/context/015.php

@@ -1,3 +1,7 @@
 <?php
 
-$context->setHidden('api_key', 'sk_live_abc123xyz789');
+$context->setHidden([
+    'api_key'     => 'sk_live_abc123xyz789',
+    'api_secret'  => 'secret_key_here',
+    'db_password' => 'database_password',
+]);