feat: remove deprecated has_downloads and ignore_vulnerability_alerts_during_read variables (#20)

johncblandii · goruha · web-flow · commit f959024a3682 · 2026-04-14T22:25:29.000+03:00
* refactor: remove deprecated has_downloads and ignore_vulnerability_alerts_during_read variables

has_downloads was deprecated by GitHub and previously marked deprecated in this module.
ignore_vulnerability_alerts_during_read is a no-op as the provider now handles
lack of permissions automatically. Both variables and all references removed from
module root, examples, README, and fixtures.

* style: reformat fixtures alignment after variable removal

---------

Co-authored-by: Igor Rodionov &lt;496956+goruha@users.noreply.github.com&gt;
diff --git a/README.md b/README.md
@@ -81,7 +81,6 @@ module "github_repository" {
   has_issues = true
   has_projects = true
   has_wiki = true
-  has_downloads = true
   is_template = false
 }
 ```
@@ -179,13 +178,11 @@ Here is an example of using this module:
 | <a name="input_fork"></a> [fork](#input\_fork) | Configuration for forking an existing repository | <pre>object({<br/>    source_owner = string<br/>    source_repo  = string<br/>  })</pre> | `null` | no |
 | <a name="input_gitignore_template"></a> [gitignore\_template](#input\_gitignore\_template) | Gitignore template | `string` | `null` | no |
 | <a name="input_has_discussions"></a> [has\_discussions](#input\_has\_discussions) | Whether the repository has discussions enabled | `bool` | `false` | no |
-| <a name="input_has_downloads"></a> [has\_downloads](#input\_has\_downloads) | (DEPRECATED) Whether the repository has downloads enabled. This attribute is deprecated by GitHub and will be removed in a future version of this module. | `bool` | `false` | no |
 | <a name="input_has_issues"></a> [has\_issues](#input\_has\_issues) | Whether the repository has issues enabled | `bool` | `false` | no |
 | <a name="input_has_projects"></a> [has\_projects](#input\_has\_projects) | Whether the repository has projects enabled | `bool` | `false` | no |
 | <a name="input_has_wiki"></a> [has\_wiki](#input\_has\_wiki) | Whether the repository has wiki enabled | `bool` | `false` | no |
 | <a name="input_homepage_url"></a> [homepage\_url](#input\_homepage\_url) | Homepage URL of the repository | `string` | `null` | no |
 | <a name="input_id_length_limit"></a> [id\_length\_limit](#input\_id\_length\_limit) | Limit `id` to this many characters (minimum 6).<br/>Set to `0` for unlimited length.<br/>Set to `null` for keep the existing setting, which defaults to `0`.<br/>Does not affect `id_full`. | `number` | `null` | no |
-| <a name="input_ignore_vulnerability_alerts_during_read"></a> [ignore\_vulnerability\_alerts\_during\_read](#input\_ignore\_vulnerability\_alerts\_during\_read) | Ignore vulnerability alerts during read | `bool` | `false` | no |
 | <a name="input_is_template"></a> [is\_template](#input\_is\_template) | Whether the repository is a template | `bool` | `false` | no |
 | <a name="input_label_key_case"></a> [label\_key\_case](#input\_label\_key\_case) | Controls the letter case of the `tags` keys (label names) for tags generated by this module.<br/>Does not affect keys of tags passed in via the `tags` input.<br/>Possible values: `lower`, `title`, `upper`.<br/>Default value: `title`. | `string` | `null` | no |
 | <a name="input_label_order"></a> [label\_order](#input\_label\_order) | The order in which the labels (ID elements) appear in the `id`.<br/>Defaults to ["namespace", "environment", "stage", "name", "attributes"].<br/>You can omit any of the 6 labels ("tenant" is the 6th), but at least one must be present. | `list(string)` | `null` | no |
diff --git a/README.yaml b/README.yaml
@@ -95,7 +95,6 @@ usage: |-
     has_issues = true
     has_projects = true
     has_wiki = true
-    has_downloads = true
     is_template = false
   }
   ```
diff --git a/examples/complete/fixtures.us-east-2.tfvars b/examples/complete/fixtures.us-east-2.tfvars
@@ -1,30 +1,29 @@
 owner = "cloudposse-tests"
 
-description                             = "Terraform acceptance tests"
-homepage_url                            = "http://example.com/"
-archived                                = false
-has_issues                              = true
-has_discussions                         = true
-has_projects                            = true
-has_wiki                                = true
-is_template                             = true
-allow_merge_commit                      = true
-merge_commit_title                      = "MERGE_MESSAGE"
-merge_commit_message                    = "PR_TITLE"
-allow_squash_merge                      = true
-squash_merge_commit_title               = "COMMIT_OR_PR_TITLE"
-squash_merge_commit_message             = "COMMIT_MESSAGES"
-web_commit_signoff_required             = true
-allow_rebase_merge                      = true
-allow_auto_merge                        = true
-delete_branch_on_merge                  = true
-default_branch                          = "main"
-gitignore_template                      = "TeX"
-license_template                        = "GPL-3.0"
-auto_init                               = true
-topics                                  = ["terraform", "github", "test"]
-ignore_vulnerability_alerts_during_read = true
-allow_update_branch                     = true
+description                 = "Terraform acceptance tests"
+homepage_url                = "http://example.com/"
+archived                    = false
+has_issues                  = true
+has_discussions             = true
+has_projects                = true
+has_wiki                    = true
+is_template                 = true
+allow_merge_commit          = true
+merge_commit_title          = "MERGE_MESSAGE"
+merge_commit_message        = "PR_TITLE"
+allow_squash_merge          = true
+squash_merge_commit_title   = "COMMIT_OR_PR_TITLE"
+squash_merge_commit_message = "COMMIT_MESSAGES"
+web_commit_signoff_required = true
+allow_rebase_merge          = true
+allow_auto_merge            = true
+delete_branch_on_merge      = true
+default_branch              = "main"
+gitignore_template          = "TeX"
+license_template            = "GPL-3.0"
+auto_init                   = true
+topics                      = ["terraform", "github", "test"]
+allow_update_branch         = true
 
 security_and_analysis = {
   advanced_security                     = false
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
@@ -44,8 +44,6 @@ module "example" {
 
   web_commit_signoff_required = var.web_commit_signoff_required
 
-  ignore_vulnerability_alerts_during_read = var.ignore_vulnerability_alerts_during_read
-
   autolink_references         = var.autolink_references
   default_branch              = var.default_branch
   enable_vulnerability_alerts = var.enable_vulnerability_alerts
diff --git a/examples/complete/variables.tf b/examples/complete/variables.tf
@@ -191,12 +191,6 @@ variable "auto_init" {
   default     = false
 }
 
-variable "ignore_vulnerability_alerts_during_read" {
-  description = "Ignore vulnerability alerts during read"
-  type        = bool
-  default     = false
-}
-
 variable "enable_vulnerability_alerts" {
   description = "Enable vulnerability alerts"
   type        = bool
diff --git a/examples/minimum/main.tf b/examples/minimum/main.tf
@@ -43,8 +43,6 @@ module "example" {
 
   web_commit_signoff_required = var.web_commit_signoff_required
 
-  ignore_vulnerability_alerts_during_read = var.ignore_vulnerability_alerts_during_read
-
   autolink_references         = var.autolink_references
   default_branch              = var.default_branch
   enable_vulnerability_alerts = var.enable_vulnerability_alerts
diff --git a/examples/minimum/variables.tf b/examples/minimum/variables.tf
@@ -182,12 +182,6 @@ variable "auto_init" {
   default     = false
 }
 
-variable "ignore_vulnerability_alerts_during_read" {
-  description = "Ignore vulnerability alerts during read"
-  type        = bool
-  default     = false
-}
-
 variable "enable_vulnerability_alerts" {
   description = "Enable vulnerability alerts"
   type        = bool
diff --git a/main.tf b/main.tf
@@ -55,8 +55,6 @@ resource "github_repository" "default" {
 
   vulnerability_alerts = var.visibility != "public" ? var.enable_vulnerability_alerts : true
 
-  ignore_vulnerability_alerts_during_read = var.ignore_vulnerability_alerts_during_read
-
   dynamic "security_and_analysis" {
     for_each = var.security_and_analysis != null ? [var.security_and_analysis] : []
     content {
@@ -621,10 +619,3 @@ resource "github_repository_ruleset" "default" {
     github_repository_environment.default
   ]
 }
-
-check "has_downloads_deprecation" {
-  assert {
-    condition     = var.has_downloads == false
-    error_message = "DEPRECATION WARNING: The 'has_downloads' variable is deprecated. GitHub has removed this feature and this variable will be removed in a future version of this module. Please remove 'has_downloads' from your configuration."
-  }
-}
diff --git a/variables.tf b/variables.tf
@@ -70,12 +70,6 @@ variable "has_wiki" {
   default     = false
 }
 
-variable "has_downloads" {
-  description = "(DEPRECATED) Whether the repository has downloads enabled. This attribute is deprecated by GitHub and will be removed in a future version of this module."
-  type        = bool
-  default     = false
-}
-
 variable "is_template" {
   description = "Whether the repository is a template"
   type        = bool
@@ -192,12 +186,6 @@ variable "auto_init" {
   default     = false
 }
 
-variable "ignore_vulnerability_alerts_during_read" {
-  description = "Ignore vulnerability alerts during read"
-  type        = bool
-  default     = false
-}
-
 variable "enable_vulnerability_alerts" {
   description = "Enable vulnerability alerts"
   type        = bool

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,6 @@ usage: \|-`
`95`	`95`	`has_issues = true`
`96`	`96`	`has_projects = true`
`97`	`97`	`has_wiki = true`
`98`		`- has_downloads = true`
`99`	`98`	`is_template = false`
`100`	`99`	`}`
`101`	`100`	```