Address more Shellcheck findings

Author: claui

libexec/dataset_id.bash

@@ -16,6 +16,7 @@ export -f __dataset_id__cleanup
 
 function __dataset_id__load_dataset_record {
   local pid exitstatus fifodir fifoname
+  export dataset dataset_id
 
   trap __dataset_id__cleanup EXIT INT HUP TERM
   fifodir="$(mktemp -d)"
@@ -24,7 +25,7 @@ function __dataset_id__load_dataset_record {
 
   (__dataset_id__dataset_record "$@") > "${fifoname}" &
   pid="$!"
-  IFS=$'\t' read -d $'\n' dataset dataset_id < "${fifoname}" \
+  IFS=$'\t' read -r -d $'\n' dataset dataset_id < "${fifoname}" \
     || true
 
   wait "${pid}" || exitstatus="$?"
@@ -62,7 +63,7 @@ function __dataset_id__dataset_record {
     esac
   done
 
-  shift "$(($OPTIND-1))"
+  shift "$((OPTIND-1))"
 
   parent_dataset="$1"
 

libexec/znaphodl.bash

@@ -78,7 +78,7 @@ function __znaphodl__load_target_dataset_record {
 
   (__znaphodl__target_dataset_record) > "${fifoname}" &
   pid="$!"
-  IFS=$'\t' read -d $'\n' target_dataset target_hostname \
+  IFS=$'\t' read -r -d $'\n' target_dataset target_hostname \
     < "${fifoname}" \
     || true
 
@@ -180,7 +180,7 @@ function __znaphodl {
     esac
   done
 
-  shift "$(($OPTIND-1))"
+  shift "$((OPTIND-1))"
 
   source_dataset="${1?}"
   target_dataset_key="${2?}"

libexec/znaphodlz.bash

@@ -6,13 +6,12 @@ function __znaphodlz {
   local home_poolname
   local poolnames
 
-  __zpoolz__load_poolnames
-  if [[ "$?" -ne 0 ]]; then
+  if ! __zpoolz__load_poolnames; then
     echo >&2 "Unable to identify pool names"
     return 1
   fi
 
-  if [[ ! "${poolnames[@]}" ]]; then
+  if [[ ! "${poolnames}" ]]; then
     echo >&2 "No pools found"
     return 1
   fi

libexec/znaplizt.bash

@@ -65,19 +65,18 @@ function __znaplizt {
     esac
   done
 
-  shift "$(($OPTIND-1))"
+  shift "$((OPTIND-1))"
 
-  if [[ "$@" ]]; then
+  if [[ "$#" -gt 0 ]]; then
     poolnames=("$@")
   else
-    __zpoolz__load_poolnames
-    if [[ "$?" -ne 0 ]]; then
+    if ! __zpoolz__load_poolnames; then
       echo >&2 "Unable to identify pool names"
       return 1
     fi
   fi
 
-  if [[ ! "${poolnames[@]}" ]]; then
+  if [[ "${#poolnames[@]}" -eq 0 ]]; then
     echo >&2 "No pools found"
     return 1
   fi

libexec/zpoolz.bash

@@ -15,7 +15,7 @@ function __zpoolz__load_poolnames {
 
   (zpool list -H -o name) > "${fifoname}" &
   zpool_pid="$!"
-  IFS=$'\n' read -a poolnames -d '' < "${fifoname}" || true
+  IFS=$'\n' read -r -a poolnames -d '' < "${fifoname}" || true
 
   wait "${zpool_pid}" || zpool_status="$?"