Skip to content

Commit 4355a57

Browse files
Build specific versions of vscode (#11)
* REF set code version to older version. * BLD fix the version of code server. * BLD debugging * BLD this fixes it. * REF restore this * DOC add comment * BLD remove CODE_RELEASE value in version naming & bump version. This makes the versioning scheme more complicated than it needs to be. We can increment major versions when updating the version of vscode and maintain backwards compatibility. * BLD use CODE_RELEASE in release version docker tag * BLD PR feedback
1 parent 7c3e2e2 commit 4355a57

5 files changed

Lines changed: 12 additions & 3 deletions

File tree

Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ ENV PATH=/opt/R/${R_VERSION}/bin:${PATH}
5252
FROM docker-code-server-python
5353
ARG BUILD_DATE
5454
ARG VERSION
55+
# NOTE: This is set in `./default.env`. Update the version there when updating the vscode version.
5556
ARG CODE_RELEASE
5657

5758
LABEL build_version="Linuxserver.io version:- ${VERSION} Build-date:- ${BUILD_DATE}"

buildspec/merge_master.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@ phases:
88
- aws ecr get-login-password --region ${AWS_DEFAULT_REGION} | docker login --username AWS --password-stdin ${FIPS_REPOSITORY_URI}
99
build:
1010
commands:
11-
- echo Building the Docker image...
11+
- . ./default.env
12+
- echo Building the Docker image for code-server v${CODE_RELEASE}...
1213
- >
1314
docker build
1415
--build-arg ECR_ACCOUNT_ID=${ECR_ACCOUNT_ID}
16+
--build-arg CODE_RELEASE=${CODE_RELEASE}
1517
--tag ${FIPS_REPOSITORY_URI}:latest
1618
.
1719

buildspec/push.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ phases:
88
- aws ecr get-login-password --region ${AWS_DEFAULT_REGION} | docker login --username AWS --password-stdin ${FIPS_REPOSITORY_URI}
99
build:
1010
commands:
11-
- echo Building the Docker image...
11+
- . ./default.env
12+
- echo Building the Docker image for code-server v${CODE_RELEASE}...
1213
- echo $FIPS_REPOSITORY_URI
1314
- echo $COMMIT_HASH_SHORT
1415
- echo $BRANCH_NAME
1516
- >
1617
docker build
1718
--build-arg ECR_ACCOUNT_ID=${ECR_ACCOUNT_ID}
19+
--build-arg CODE_RELEASE=${CODE_RELEASE}
1820
--tag ${FIPS_REPOSITORY_URI}:${COMMIT_HASH_SHORT}
1921
--tag ${FIPS_REPOSITORY_URI}:${BRANCH_NAME}
2022
.

buildspec/release.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@ phases:
77
- aws ecr get-login-password --region ${AWS_DEFAULT_REGION} | docker login --username AWS --password-stdin ${FIPS_REPOSITORY_URI}
88
build:
99
commands:
10-
- echo Building the Docker image...
10+
- . ./default.env
11+
- echo Building the Docker image for code-server v${CODE_RELEASE}...
1112
- PATCH_TAG=${TAG_NAME#"v"}
1213
- MINOR_TAG=${PATCH_TAG%.*}
1314
- MAJOR_TAG=${MINOR_TAG%.*}
1415
- >
1516
docker build
1617
--build-arg ECR_ACCOUNT_ID=${ECR_ACCOUNT_ID}
18+
--build-arg CODE_RELEASE=${CODE_RELEASE}
1719
--tag ${FIPS_REPOSITORY_URI}:${PATCH_TAG}
1820
--tag ${FIPS_REPOSITORY_URI}:${MINOR_TAG}
1921
--tag ${FIPS_REPOSITORY_URI}:${MAJOR_TAG}

default.env

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Determines the version of code-server to build
2+
export CODE_RELEASE=4.104.3

0 commit comments

Comments
 (0)