Skip to content

Commit 6e18b3c

Browse files
authored
Merge pull request #72 from ciatph/fix/ciatph-70
fix: actions artifacts version
2 parents 948f7f8 + a78d111 commit 6e18b3c

2 files changed

Lines changed: 26 additions & 16 deletions

File tree

.github/workflows/lint.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ name: Lint Files
22

33
on:
44
push:
5-
branches:
6-
- '*'
5+
branches-ignore:
6+
- 'master'
77

88
jobs:
99
lint-client:
@@ -14,9 +14,9 @@ jobs:
1414
node-version: [14.x]
1515
steps:
1616
- name: Checkout the repository
17-
uses: actions/checkout@v1
17+
uses: actions/checkout@v3
1818
- name: Use NodeJS ${{ matrix.node-version }}
19-
uses: actions/setup-node@v2
19+
uses: actions/setup-node@v3
2020
with:
2121
node-version: ${{ matrix.node-version }}
2222
- name: Install Dependencies and lint
@@ -33,13 +33,13 @@ jobs:
3333
node-version: [14.x]
3434
steps:
3535
- name: Checkout the repository
36-
uses: actions/checkout@v1
36+
uses: actions/checkout@v3
3737
- name: Use NodeJS ${{ matrix.node-version }}
38-
uses: actions/setup-node@v2
38+
uses: actions/setup-node@v3
3939
with:
4040
node-version: ${{ matrix.node-version }}
4141
- name: Install Dependencies and lint
4242
run: |
4343
cd server
4444
npm install
45-
npm run lint
45+
npm run lint

.github/workflows/release.yml

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ jobs:
1717
node-version: [14.x]
1818
steps:
1919
- name: Checkout the repository
20-
uses: actions/checkout@v1
20+
uses: actions/checkout@v3
21+
with:
22+
ref: ${{ github.event.release.tag_name }}
2123
- name: Use NodeJS ${{ matrix.node-version }}
22-
uses: actions/setup-node@v2
24+
uses: actions/setup-node@v3
2325
with:
2426
node-version: ${{ matrix.node-version }}
2527
- name: Install dependencies and lint
@@ -32,9 +34,10 @@ jobs:
3234
cd client
3335
npm run build
3436
- name: Archive Development Artifact
35-
uses: actions/upload-artifact@v3
37+
uses: actions/upload-artifact@v4
3638
with:
3739
name: build
40+
include-hidden-files: true
3841
path: |
3942
client/build
4043
client/.firebaserc
@@ -49,9 +52,11 @@ jobs:
4952
node-version: [14.x]
5053
steps:
5154
- name: Checkout the repository
52-
uses: actions/checkout@v1
55+
uses: actions/checkout@v3
56+
with:
57+
ref: ${{ github.event.release.tag_name }}
5358
- name: Use NodeJS ${{ matrix.node-version }}
54-
uses: actions/setup-node@v2
59+
uses: actions/setup-node@v3
5560
with:
5661
node-version: ${{ matrix.node-version }}
5762
- name: Install Dependencies and lint
@@ -66,7 +71,7 @@ jobs:
6671
runs-on: ubuntu-latest
6772
steps:
6873
- name: Download Artifact
69-
uses: actions/download-artifact@v3
74+
uses: actions/download-artifact@v4
7075
with:
7176
name: build
7277
- name: Deploy to Firebase
@@ -77,6 +82,7 @@ jobs:
7782
FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
7883

7984
deploy-server:
85+
if: ${{ vars.IS_DEPLOY_SERVER == 'heroku' }}
8086
name: Deploy Server to Heroku
8187
needs: lint-server
8288
runs-on: ubuntu-latest
@@ -86,7 +92,9 @@ jobs:
8692
HEROKU_APP: ${{ secrets.HEROKU_APP }}
8793
steps:
8894
- name: Checkout the repository
89-
uses: actions/checkout@v1
95+
uses: actions/checkout@v3
96+
with:
97+
ref: ${{ github.event.release.tag_name }}
9098
- run: |
9199
cat >~/.netrc <<EOF
92100
machine api.heroku.com
@@ -105,12 +113,14 @@ jobs:
105113
runs-on: ubuntu-latest
106114
steps:
107115
- name: Login to Docker Hub
108-
uses: docker/login-action@v2
116+
uses: docker/login-action@v3
109117
with:
110118
username: ${{ secrets.DOCKERHUB_USERNAME }}
111119
password: ${{ secrets.DOCKERHUB_TOKEN }}
112120
- name: Checkout the repository
113-
uses: actions/checkout@v1
121+
uses: actions/checkout@v3
122+
with:
123+
ref: ${{ github.event.release.tag_name }}
114124
- name: Create temporary env variables
115125
# Replace these files with actual values during
116126
# runtime on 'docker-compose up'

0 commit comments

Comments
 (0)