Skip to content

Commit 359c748

Browse files
authored
Merge pull request #79 from ciatph/dev
v1.1.5
2 parents 0d20f60 + 1bc5a8c commit 359c748

11 files changed

Lines changed: 156 additions & 82 deletions

File tree

.github/workflows/release.yml

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
jobs:
1010
lint-client:
1111
name: Lint and Build client
12+
if: github.event.release.target_commitish == 'master'
1213
runs-on: ubuntu-latest
1314
env:
1415
REACT_APP_BASE_URL: ${{ secrets.REACT_APP_BASE_URL }}
@@ -46,6 +47,7 @@ jobs:
4647

4748
lint-server:
4849
name: Lint Server
50+
if: github.event.release.target_commitish == 'master'
4951
runs-on: ubuntu-latest
5052
strategy:
5153
matrix:
@@ -67,6 +69,7 @@ jobs:
6769
6870
deploy-client:
6971
name: Deploy Client to Firebase Hosting
72+
if: github.event.release.target_commitish == 'master'
7073
needs: lint-client
7174
runs-on: ubuntu-latest
7275
steps:
@@ -108,8 +111,10 @@ jobs:
108111
- run: git push heroku HEAD:refs/heads/master
109112
- run: rm -r -f .netrc
110113

114+
# Push the complete "app" Docker image
111115
docker-build-push:
112-
name: Deploy to Docker Hub
116+
name: Deploy App to Docker Hub
117+
if: github.event.release.target_commitish == 'master'
113118
runs-on: ubuntu-latest
114119
steps:
115120
- name: Login to Docker Hub
@@ -133,3 +138,27 @@ jobs:
133138
run: docker compose -f docker-compose.app.yml build
134139
- name: Push Images to Docker Hub
135140
run: docker compose -f docker-compose.app.yml push
141+
142+
# Push the development (client/server) Docker images
143+
docker-build-push-dev:
144+
name: Deploy Development to Docker Hub
145+
if: github.event.release.target_commitish == 'master'
146+
runs-on: ubuntu-latest
147+
steps:
148+
- name: Login to Docker Hub
149+
uses: docker/login-action@v3
150+
with:
151+
username: ${{ secrets.DOCKERHUB_USERNAME }}
152+
password: ${{ secrets.DOCKERHUB_TOKEN }}
153+
- name: Checkout the repository
154+
uses: actions/checkout@v3
155+
with:
156+
ref: ${{ github.event.release.tag_name }}
157+
- name: Create temporary env variables
158+
run: |
159+
cp client/.env.example client/.env
160+
cp server/.env.example server/.env
161+
- name: Build Images
162+
run: docker compose -f docker-compose.dev.yml build
163+
- name: Push Images to Docker Hub
164+
run: docker compose -f docker-compose.dev.yml push

README.md

Lines changed: 88 additions & 48 deletions
Large diffs are not rendered by default.

client/.env.example

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,8 @@
1-
REACT_APP_BASE_URL=http://localhost:3001/api
1+
REACT_APP_BASE_URL=http://localhost:3001/api
2+
REACT_APP_FIREBASE_API_KEY=AIzaSyB1SivNCSCPXFV4v4FhE-Ll2av8nHEWr-8
3+
REACT_APP_FIREBASE_AUTHDOMAIN=users-admin-firebase.firebaseapp.com
4+
REACT_APP_FIREBASE_PROJECT_ID=users-admin-firebase
5+
REACT_APP_FIREBASE_STORAGE_BUCKET=users-admin-firebase.appspot.com
6+
REACT_APP_FIREBASE_MESSAGING_SENDER_ID=761515421472
7+
REACT_APP_FIREBASE_APP_ID=1:761515421472:web:d7c737ba274515297f3145
8+
REACT_APP_FIREBASE_MEASUREMENT_ID=G-ZCWY6YX0P0

client/src/components/common/navigation/userbutton.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Link } from 'react-router-dom'
2-
import { auth, signOut } from '../../../utils/firebase/firebase.config'
2+
import { auth, signOut } from '../../../config/firebase.config'
33

44
function UserButton (hasUser) {
55
const logout = async () => {

client/src/utils/firebase/firebase.config.js renamed to client/src/config/firebase.config.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ import { getAuth, signOut, signInWithEmailAndPassword } from 'firebase/auth'
77
// Your web app's Firebase configuration
88
// For Firebase JS SDK v7.20.0 and later, measurementId is optional
99
const firebaseConfig = {
10-
apiKey: 'AIzaSyB1SivNCSCPXFV4v4FhE-Ll2av8nHEWr-8',
11-
authDomain: 'users-admin-firebase.firebaseapp.com',
12-
projectId: 'users-admin-firebase',
13-
storageBucket: 'users-admin-firebase.appspot.com',
14-
messagingSenderId: '761515421472',
15-
appId: '1:761515421472:web:d7c737ba274515297f3145',
16-
measurementId: 'G-ZCWY6YX0P0'
10+
apiKey: process.env.REACT_APP_FIREBASE_API_KEY,
11+
authDomain: process.env.REACT_APP_FIREBASE_AUTHDOMAIN,
12+
projectId: process.env.REACT_APP_FIREBASE_PROJECT_ID,
13+
storageBucket: process.env.REACT_APP_FIREBASE_STORAGE_BUCKET,
14+
messagingSenderId: process.env.REACT_APP_FIREBASE_MESSAGING_SENDER_ID,
15+
appId: process.env.REACT_APP_FIREBASE_APP_ID,
16+
measurementId: process.env.REACT_APP_FIREBASE_MEASUREMENT_ID
1717
}
1818

1919
// Initialize Firebase

client/src/containers/login/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { useState, useEffect } from 'react'
22
import PropTypes from 'prop-types'
3-
import { auth, signInWithEmailAndPassword } from '../../utils/firebase/firebase.config'
3+
import { auth, signInWithEmailAndPassword } from '../../config/firebase.config'
44
import Login from '../../components/common/form'
55
import AlertMessage from '../../components/common/alert_message'
66

client/src/containers/login/withauth.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useState, useEffect } from 'react'
2-
import { auth, signOut } from '../../utils/firebase/firebase.config'
2+
import { auth, signOut } from '../../config/firebase.config'
33

44
const WithAuth = (Component) => {
55
function AuthAwareComponent (props) {

client/src/utils/service/service.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import axios from 'axios'
2-
import { auth } from '../firebase/firebase.config'
2+
import { auth } from '../../config/firebase.config'
33

44
export default class Service {
55
constructor () {

docker-compose.app.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
# - Express backend that restarts itself on errors running on pm2
33
# - Create React App (CRA) client served from a static directory (using express.static() middleware)
44
# Requirements: Disable CORS to allow Same Origin headers on client and server APIs
5-
version: "3"
5+
66
services:
77
# Built Create React App (CRA) website running on nginx
8-
firebase-users-admin-app:
9-
container_name: firebase-users-admin-app
10-
image: ciatphdev/firebase-users-admin-app:latest
8+
firebase-users-app:
9+
container_name: firebase-users-app
10+
image: ciatphdev/firebase-users-app:latest
1111
restart: always
1212
env_file:
1313
- ./server/.env
@@ -17,11 +17,11 @@ services:
1717
dockerfile: Dockerfile.app
1818
target: production
1919
networks:
20-
- firebase-users-admin-app
20+
- firebase-users-app
2121
ports:
2222
- "3001:3001"
2323

2424
networks:
25-
firebase-users-admin-app:
26-
name: firebase-users-admin-app
25+
firebase-users-app:
26+
name: firebase-users-app
2727
external: false

docker-compose.dev.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
version: "3"
21
services:
32
# Create React App (CRA) running on development mode
43
client-dev:
54
container_name: client-dev
6-
image: ciatphdev/firebase-users-admin-client:dev
5+
image: ciatphdev/firebase-users-client:dev
76
env_file:
87
- ./client/.env
98
build:
109
context: ./client
1110
dockerfile: Dockerfile
1211
target: development
1312
networks:
14-
- firebase-users-admin-dev
13+
- firebase-users-dev
1514
volumes:
1615
- ./client/public:/opt/client/public
1716
- ./client/src:/opt/client/src
@@ -21,21 +20,21 @@ services:
2120
# Express app running in development mode with auto reload using nodemon
2221
server-dev:
2322
container_name: server-dev
24-
image: ciatphdev/firebase-users-admin-server:dev
23+
image: ciatphdev/firebase-users-server:dev
2524
env_file:
2625
- ./server/.env
2726
build:
2827
context: ./server
2928
dockerfile: Dockerfile
3029
target: development
3130
networks:
32-
- firebase-users-admin-dev
31+
- firebase-users-dev
3332
volumes:
3433
- ./server/src:/opt/server/src
3534
ports:
3635
- "3001:3001"
3736

3837
networks:
39-
firebase-users-admin-dev:
40-
name: firebase-users-admin-dev
38+
firebase-users-dev:
39+
name: firebase-users-dev
4140
external: false

0 commit comments

Comments
 (0)