Skip to content

Commit 1c84ce4

Browse files
committed
Fix: remove bugsnag.buildReport(exception); & remove bugsnag.setTimeout
1 parent 71d87db commit 1c84ce4

3 files changed

Lines changed: 12 additions & 19 deletions

File tree

bugsnag/src/main/java/com/bugsnag/BugsnagAppender.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,6 @@ private Bugsnag createBugsnag() {
250250
bugsnag.setReleaseStage(releaseStage);
251251
}
252252

253-
if (timeout > 0) {
254-
bugsnag.setTimeout(timeout);
255-
}
256253

257254
if (filteredProperties.size() > 0) {
258255
bugsnag.setFilters(filteredProperties.toArray(new String[0]));
@@ -503,10 +500,6 @@ public void setSendThreads(boolean sendThreads) {
503500
*/
504501
public void setTimeout(int timeout) {
505502
this.timeout = timeout;
506-
507-
if (bugsnag != null) {
508-
bugsnag.setTimeout(timeout);
509-
}
510503
}
511504

512505
/**

bugsnag/src/test/java/com/bugsnag/JakartaServletCallbackTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ public void closeBugsnag() {
8181
@SuppressWarnings("unchecked")
8282
@Test
8383
public void testRequestMetadataAdded() {
84-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
84+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
85+
Report report = new Report(bugsnag.getConfig(), exception);
8586
JakartaServletCallback callback = new JakartaServletCallback();
8687
callback.beforeNotify(report);
8788

@@ -118,7 +119,8 @@ public void testRequestMetadataAdded() {
118119

119120
@Test
120121
public void testRequestContextSet() {
121-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
122+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
123+
Report report = new Report(bugsnag.getConfig(), exception);
122124
JakartaServletCallback callback = new JakartaServletCallback();
123125
callback.beforeNotify(report);
124126

@@ -127,17 +129,15 @@ public void testRequestContextSet() {
127129

128130
@Test
129131
public void testExistingContextNotOverridden() {
130-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
132+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
133+
Report report = new Report(bugsnag.getConfig(), exception);
131134
report.setContext("Honey nut corn flakes");
132135
JakartaServletCallback callback = new JakartaServletCallback();
133136
callback.beforeNotify(report);
134137

135138
assertEquals("Honey nut corn flakes", report.getContext());
136139
}
137140

138-
private Report generateReport(java.lang.Exception exception) {
139-
return bugsnag.buildReport(exception);
140-
}
141141

142142
private Enumeration<String> stringsToEnumeration(String... strings) {
143143
return Collections.enumeration(Arrays.asList(strings));

bugsnag/src/test/java/com/bugsnag/JavaxServletCallbackTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ public void closeBugsnag() {
8181
@SuppressWarnings("unchecked")
8282
@Test
8383
public void testRequestMetadataAdded() {
84-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
84+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
85+
Report report = new Report(bugsnag.getConfig(), exception);
8586
JavaxServletCallback callback = new JavaxServletCallback();
8687
callback.beforeNotify(report);
8788

@@ -118,7 +119,8 @@ public void testRequestMetadataAdded() {
118119

119120
@Test
120121
public void testRequestContextSet() {
121-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
122+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
123+
Report report = new Report(bugsnag.getConfig(), exception);
122124
JavaxServletCallback callback = new JavaxServletCallback();
123125
callback.beforeNotify(report);
124126

@@ -127,17 +129,15 @@ public void testRequestContextSet() {
127129

128130
@Test
129131
public void testExistingContextNotOverridden() {
130-
Report report = generateReport(new java.lang.Exception("Spline reticulation failed"));
132+
java.lang.Exception exception = new java.lang.Exception("Spline reticulation failed");
133+
Report report = new Report(bugsnag.getConfig(), exception);
131134
report.setContext("Honey nut corn flakes");
132135
JavaxServletCallback callback = new JavaxServletCallback();
133136
callback.beforeNotify(report);
134137

135138
assertEquals("Honey nut corn flakes", report.getContext());
136139
}
137140

138-
private Report generateReport(java.lang.Exception exception) {
139-
return bugsnag.buildReport(exception);
140-
}
141141

142142
private Enumeration<String> stringsToEnumeration(String... strings) {
143143
return Collections.enumeration(Arrays.asList(strings));

0 commit comments

Comments
 (0)