Update logon message script and improve logging

Signed-off-by: LUIZ HAMILTON ROBERTO DA SILVA <[email protected]>

Author: brazilianscriptguy

SysAdmin-Tools/SystemConfiguration-and-Deployment/Broadcast-ADUser-LogonMessage-viaGPO.ps1

@@ -1,4 +1,4 @@
-<#
+<#
 .SYNOPSIS
     Post-logon script to display a standard message via an HTA file.
 
@@ -12,14 +12,13 @@
     Luiz Hamilton Silva - @brazilianscriptguy (adapted & generalized)
 
 .VERSION
-    Last Updated: 2025-10-02
+    Last Updated: 2025-01-23
 #>
 
 param (
     [string]$messagePath = "\\forest-logonserver\NETLOGON\broadcast-logonmessage\Broadcast-UserLogonMessageViaGPO.hta"
 )
 
-# Fail quietly by default (caller environment controlled)
 $ErrorActionPreference = "SilentlyContinue"
 
 # --- Hide the console window ---
@@ -31,62 +30,41 @@ public class Win32 {
     [DllImport("user32.dll")] public static extern bool ShowWindow(IntPtr hWnd, int nCmdShow);
 }
 "@
-try {
-    $consolePtr = [Win32]::GetConsoleWindow()
-    # 0 = SW_HIDE
-    [Win32]::ShowWindow($consolePtr, 0) | Out-Null
-} catch {
-    # If hiding fails, continue but log the condition below (if logging is available)
-}
-# ---------------------------------
+$consolePtr = [Win32]::GetConsoleWindow()
+[Win32]::ShowWindow($consolePtr, 0) | Out-Null
+# --------------------------------
 
-# Prepare logging
-$scriptName = [System.IO.Path]::GetFileNameWithoutExtension($MyInvocation.MyCommand.Name)
-$logDir = "C:\Scripts-LOGS"
+# Logging configuration
+$scriptName  = [System.IO.Path]::GetFileNameWithoutExtension($MyInvocation.MyCommand.Name)
+$logDir      = "C:\Scripts-LOGS"
 $logFileName = "${scriptName}.log"
-$logPath = Join-Path $logDir $logFileName
+$logPath     = Join-Path $logDir $logFileName
 
 function Log-Message {
     param (
-        [Parameter(Mandatory = $true)][string]$Message,
+        [string]$Message,
         [string]$Severity = "INFO"
     )
-    try {
-        if (-not (Test-Path $logDir)) {
-            New-Item -Path $logDir -ItemType Directory -Force | Out-Null
-        }
-        $timestamp = Get-Date -Format "yyyy-MM-dd HH:mm:ss"
-        $entry = "[$timestamp] [$Severity] $Message"
-        Add-Content -Path $logPath -Value $entry -ErrorAction Stop
-    } catch {
-        # If logging fails, we cannot do much in a hidden logon script; swallow to avoid blocking logon
-    }
+    $timestamp = Get-Date -Format "yyyy-MM-dd HH:mm:ss"
+    Add-Content -Path $logPath -Value "[$timestamp] [$Severity] $Message"
 }
 
-# Start
-Log-Message "Script started. Target HTA: $messagePath"
+# Ensure log directory exists
+if (-not (Test-Path $logDir)) { New-Item -Path $logDir -ItemType Directory -Force | Out-Null }
 
-# Validate the HTA path and run it via mshta.exe
-if (Test-Path $messagePath -PathType Leaf) {
-    Log-Message "HTA file found at: $messagePath"
+# Execute .hta with mshta.exe
+if (Test-Path $messagePath) {
+    Log-Message "File found: $messagePath"
     try {
-        $mshta = Join-Path $env:windir "System32\mshta.exe"
-        if (-not (Test-Path $mshta)) {
-            Log-Message "mshta.exe not found at expected location: $mshta" "ERROR"
-        } else {
-            # Use Start-Process to launch mshta.exe with the HTA file; run hidden
-            $args = "`"$messagePath`""
-            Start-Process -FilePath $mshta -ArgumentList $args -WindowStyle Hidden -NoNewWindow
-            Log-Message "mshta.exe launched (hidden) for: $messagePath"
-        }
+        Start-Process -FilePath "$env:windir\System32\mshta.exe" -ArgumentList "`"$messagePath`"" -WindowStyle Hidden
+        Log-Message "HTA execution triggered."
     } catch {
-        Log-Message "Error launching mshta.exe for HTA: $_" "ERROR"
+        Log-Message "Error executing HTA: $_" "ERROR"
     }
 } else {
-    Log-Message "HTA file not found at: $messagePath" "ERROR"
+    Log-Message "File not found: $messagePath" "ERROR"
 }
 
-Log-Message "Script finished."
 exit 0
 
-# End of script
+# --- End of script ---