Skip to content

Commit c2e9f18

Browse files
bmuenzenmeyerbmuenzenmeyer
committed
fix: resolve simple typescript lints
1 parent b67c686 commit c2e9f18

11 files changed

Lines changed: 38 additions & 36 deletions

File tree

‎components/Article/Codebox/__tests__/index.test.tsx‎

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ describe('Codebox component (one lang)', (): void => {
2828
const user = userEvent.setup();
2929

3030
const { container } = render(
31-
<IntlProvider locale="en" onError={() => {}}>
31+
<IntlProvider locale="en" onError={jest.fn()}>
3232
<Codebox>
3333
<pre className="language-js">{code}</pre>
3434
</Codebox>
@@ -42,9 +42,9 @@ describe('Codebox component (one lang)', (): void => {
4242

4343
const buttonElement = container.querySelector('[aria-hidden=true]');
4444

45-
expect(buttonElement).not.toBeNull();
46-
47-
await user.click(buttonElement!);
45+
if (buttonElement !== null) {
46+
await user.click(buttonElement);
47+
}
4848

4949
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledTimes(1);
5050
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledWith(code);
@@ -56,7 +56,7 @@ describe('Codebox component (one lang)', (): void => {
5656
const textToCopy = ['Example code'];
5757

5858
const { container } = render(
59-
<IntlProvider locale="en" onError={() => {}}>
59+
<IntlProvider locale="en" onError={jest.fn()}>
6060
<Codebox textToCopy={textToCopy}>
6161
<pre className="language-js">{code}</pre>
6262
</Codebox>
@@ -70,9 +70,9 @@ describe('Codebox component (one lang)', (): void => {
7070

7171
const buttonElement = container.querySelector('button[aria-hidden=true]');
7272

73-
expect(buttonElement).not.toBeNull();
74-
75-
await user.click(buttonElement!);
73+
if (buttonElement !== null) {
74+
await user.click(buttonElement);
75+
}
7676

7777
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledTimes(1);
7878
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledWith(textToCopy[0]);
@@ -88,7 +88,7 @@ import http from 'http';`;
8888
const user = userEvent.setup();
8989

9090
render(
91-
<IntlProvider locale="en" onError={() => {}}>
91+
<IntlProvider locale="en" onError={jest.fn()}>
9292
<Codebox>
9393
<pre className="language-cjs|language-mjs">{code}</pre>
9494
</Codebox>
@@ -114,7 +114,7 @@ import http from 'http';`;
114114
const textToCopy = ['Example code 1', 'Example code 2'];
115115

116116
const { container } = render(
117-
<IntlProvider locale="en" onError={() => {}}>
117+
<IntlProvider locale="en" onError={jest.fn()}>
118118
<Codebox textToCopy={textToCopy}>
119119
<pre className="language-cjs|language-mjs">{code}</pre>
120120
</Codebox>
@@ -128,17 +128,19 @@ import http from 'http';`;
128128

129129
const copyButton = container.querySelector('button[aria-hidden=true]');
130130

131-
expect(copyButton).not.toBeNull();
132-
133-
await user.click(copyButton!);
131+
if (copyButton !== null) {
132+
await user.click(copyButton);
133+
}
134134

135135
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledTimes(1);
136136
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledWith(textToCopy[0]);
137137

138138
const buttonElement = await screen.findByText('mjs');
139139
await user.click(buttonElement);
140140

141-
await user.click(copyButton!);
141+
if (copyButton !== null) {
142+
await user.click(copyButton);
143+
}
142144

143145
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledTimes(2);
144146
expect(navigatorClipboardWriteTextSpy).toHaveBeenCalledWith(textToCopy[1]);

‎components/Article/EditLink/__tests__/index.test.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const editPath = 'pages/en/get-involved/contribute.md';
1616
describe('EditLink component', () => {
1717
it('produces correct relative path', () => {
1818
render(
19-
<IntlProvider locale="en" onError={() => {}}>
19+
<IntlProvider locale="en" onError={jest.fn()}>
2020
<EditLink relativePath={relativePath} />
2121
</IntlProvider>
2222
);
@@ -25,7 +25,7 @@ describe('EditLink component', () => {
2525

2626
it('produces correct edit path', () => {
2727
render(
28-
<IntlProvider locale="en" onError={() => {}}>
28+
<IntlProvider locale="en" onError={jest.fn()}>
2929
<EditLink editPath={editPath} />
3030
</IntlProvider>
3131
);

‎components/Common/ActiveLocalizedLink/__tests__/index.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jest.mock('next/router', () => ({
1414
describe('ActiveLocalizedLink', () => {
1515
it('renders as localized link', () => {
1616
render(
17-
<IntlProvider locale="en" onError={() => {}}>
17+
<IntlProvider locale="en" onError={jest.fn()}>
1818
<ActiveLocalizedLink
1919
className="link"
2020
activeClassName="active"
@@ -33,7 +33,7 @@ describe('ActiveLocalizedLink', () => {
3333

3434
it('ignores active class when href not matches location.href', () => {
3535
render(
36-
<IntlProvider locale="en" onError={() => {}}>
36+
<IntlProvider locale="en" onError={jest.fn()}>
3737
<ActiveLocalizedLink
3838
className="link"
3939
activeClassName="active"
@@ -49,7 +49,7 @@ describe('ActiveLocalizedLink', () => {
4949

5050
it('sets active class when href matches location.href', () => {
5151
render(
52-
<IntlProvider locale="en" onError={() => {}}>
52+
<IntlProvider locale="en" onError={jest.fn()}>
5353
<ActiveLocalizedLink
5454
className="link"
5555
activeClassName="active"

‎components/Common/Banner/__tests__/index.test.tsx‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('Tests for Header component', () => {
2121
bannersIndex.endDate = afterToday.toISOString();
2222

2323
render(
24-
<IntlProvider locale="en" onError={() => {}}>
24+
<IntlProvider locale="en" onError={jest.fn()}>
2525
<Banner bannersIndex={bannersIndex} />
2626
</IntlProvider>
2727
);
@@ -40,7 +40,7 @@ describe('Tests for Header component', () => {
4040
bannersIndex.endDate = afterToday.toISOString();
4141

4242
render(
43-
<IntlProvider locale="en" onError={() => {}}>
43+
<IntlProvider locale="en" onError={jest.fn()}>
4444
<Banner bannersIndex={bannersIndex} />
4545
</IntlProvider>
4646
);
@@ -59,7 +59,7 @@ describe('Tests for Header component', () => {
5959
bannersIndex.endDate = afterToday.toISOString();
6060

6161
render(
62-
<IntlProvider locale="en" onError={() => {}}>
62+
<IntlProvider locale="en" onError={jest.fn()}>
6363
<Banner bannersIndex={bannersIndex} />
6464
</IntlProvider>
6565
);
@@ -79,7 +79,7 @@ describe('Tests for Header component', () => {
7979
bannersIndex.link = 'foo/bar';
8080

8181
render(
82-
<IntlProvider locale="en" onError={() => {}}>
82+
<IntlProvider locale="en" onError={jest.fn()}>
8383
<Banner bannersIndex={bannersIndex} />
8484
</IntlProvider>
8585
);
@@ -102,7 +102,7 @@ describe('Tests for Header component', () => {
102102
bannersIndex.link = 'https://nodejs.org/en/an-absolute-content';
103103

104104
render(
105-
<IntlProvider locale="en" onError={() => {}}>
105+
<IntlProvider locale="en" onError={jest.fn()}>
106106
<Banner bannersIndex={bannersIndex} />
107107
</IntlProvider>
108108
);
@@ -128,7 +128,7 @@ describe('Tests for Header component', () => {
128128
'<img src="https://nodejs.org/static/images/logo.svg" alt="Node.js" data-testid="test-image" />';
129129

130130
render(
131-
<IntlProvider locale="en" onError={() => {}}>
131+
<IntlProvider locale="en" onError={jest.fn()}>
132132
<Banner bannersIndex={bannersIndex} />
133133
</IntlProvider>
134134
);

‎components/Common/DarkModeToggle/__tests__/index.test.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('DarkModeToggle Component', () => {
2121
const user = userEvent.setup();
2222
mockCurrentTheme = 'dark';
2323
render(
24-
<IntlProvider locale="en" onError={() => {}}>
24+
<IntlProvider locale="en" onError={jest.fn()}>
2525
<DarkModeToggle />
2626
</IntlProvider>
2727
);
@@ -34,7 +34,7 @@ describe('DarkModeToggle Component', () => {
3434
const user = userEvent.setup();
3535
mockCurrentTheme = 'light';
3636
render(
37-
<IntlProvider locale="en" onError={() => {}}>
37+
<IntlProvider locale="en" onError={jest.fn()}>
3838
<DarkModeToggle />
3939
</IntlProvider>
4040
);

‎components/Common/Dropdown/index.stories.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const items = [...Array(10).keys()].map(item => ({
88
title: `Item ${item + 1}`,
99
label: `item-${item + 1}`,
1010
active: false,
11-
onClick: () => {},
11+
onClick: () => jest.fn(),
1212
}));
1313

1414
items[2].active = true;

‎components/Common/LanguageSelector/__tests__/index.test.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jest.mock('../../../../hooks/useLocale', () => ({
1515
describe('LanguageSelector', () => {
1616
test('clicking the language switch button toggles the dropdown display', () => {
1717
render(
18-
<IntlProvider locale="en" onError={() => {}}>
18+
<IntlProvider locale="en" onError={jest.fn()}>
1919
<LanguageSelector />
2020
</IntlProvider>
2121
);
@@ -29,7 +29,7 @@ describe('LanguageSelector', () => {
2929

3030
test('renders the Dropdown component with correct style', () => {
3131
render(
32-
<IntlProvider locale="en" onError={() => {}}>
32+
<IntlProvider locale="en" onError={jest.fn()}>
3333
<LanguageSelector />
3434
</IntlProvider>
3535
);

‎components/Downloads/DownloadToggle/__tests__/index.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe('DownloadToggle component', (): void => {
88
const mockHandler = jest.fn();
99

1010
render(
11-
<IntlProvider locale="en" onError={() => {}}>
11+
<IntlProvider locale="en" onError={jest.fn()}>
1212
<DownloadToggle selected="LTS" handleClick={mockHandler} />
1313
</IntlProvider>
1414
);

‎components/Learn/PreviousNextLink/__tests__/index.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('PrevNextLink component', () => {
2121
test('renders previous link if previous is provided', () => {
2222
const previous = { slug: '/previous-page' };
2323
render(
24-
<IntlProvider locale="en" onError={() => {}}>
24+
<IntlProvider locale="en" onError={jest.fn()}>
2525
<PrevNextLink previous={previous} />
2626
</IntlProvider>
2727
);
@@ -32,7 +32,7 @@ describe('PrevNextLink component', () => {
3232
test('renders next link if next is provided', () => {
3333
const next = { slug: '/next-page' };
3434
render(
35-
<IntlProvider locale="en" onError={() => {}}>
35+
<IntlProvider locale="en" onError={jest.fn()}>
3636
<PrevNextLink next={next} />
3737
</IntlProvider>
3838
);
@@ -44,7 +44,7 @@ describe('PrevNextLink component', () => {
4444
const previous = { slug: '/previous-page' };
4545
const next = { slug: '/next-page' };
4646
render(
47-
<IntlProvider locale="en" onError={() => {}}>
47+
<IntlProvider locale="en" onError={jest.fn()}>
4848
<PrevNextLink previous={previous} next={next} />
4949
</IntlProvider>
5050
);

‎components/Sections/NewHeader/__tests__/index.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ describe('Tests for Header component', () => {
3939
it('switches logo between light & dark', async () => {
4040
mockCurrentTheme = 'light';
4141
render(
42-
<IntlProvider locale="en" onError={() => {}}>
42+
<IntlProvider locale="en" onError={jest.fn()}>
4343
<Header />
4444
</IntlProvider>
4545
);

0 commit comments

Comments
 (0)