Code cleanup and minor optimizations

Cleaned up compute_sqrt.c and done some minor optimizations.

Author: basilegithub

src/compute_sqrt.c

@@ -6,38 +6,37 @@
 
 void build_sqrt(mpz_t n,unsigned long dim, bool vector[dim], dyn_array_classic primes, mpz_t x, mpz_t y, dyn_array relations, dyn_array smooth)
 {
-    mpz_t tmp,tmp2;
-    mpz_init(tmp);
-    mpz_init(tmp2);
+    mpz_t tmp_mpz, tmp_mpz_2;
+    mpz_inits(tmp_mpz, tmp_mpz_2, NULL);
+
     mpz_set_ui(y, 1);
     mpz_set_ui(x, 1);
-    unsigned long vector_y[primes.len];
+    unsigned long *vector_y = calloc(primes.len, sizeof(unsigned long));
+
     for (size_t i = 0 ; i < primes.len ; i++) vector_y[i] = 0;
+
     for (size_t e = 0 ; e < dim ; e++)
     {
         if (vector[e])
         {
-            mpz_mul(x, x, *(smooth.start+e));
-            mpz_mod(x, x, n);
+            mpz_mul(tmp_mpz, x, smooth.start[e]);
+            mpz_mod(x, tmp_mpz, n);
+
             for (size_t i = 0 ; i < primes.len ; i++)
             {
-                mpz_set_ui(tmp, *(primes.start+i));
-                while(mpz_divisible_p(*(relations.start+e), tmp))
-                {
-                    vector_y[i]++;
-                    mpz_mul_ui(tmp, tmp, *(primes.start+i));
-                }
+                mpz_set_ui(tmp_mpz, primes.start[i]);
+                vector_y[i] += mpz_remove(tmp_mpz_2, relations.start[e], tmp_mpz);
             }
         }
     }
+    
     for (size_t k = 0 ; k < primes.len ; k++)
     {
-        mpz_set_ui(tmp2, vector_y[k]);
-        mpz_div_2exp(tmp2, tmp2, 1);
-        mpz_set_ui(tmp, *(primes.start+k));
-        mpz_powm(tmp, tmp, tmp2, n);
-        mpz_mul(y, y, tmp);
-        mpz_mod(y, y, n);
+        mpz_set_ui(tmp_mpz, primes.start[k]);
+        mpz_powm_ui(tmp_mpz, tmp_mpz, vector_y[k]>>1, n);
+        mpz_mul(tmp_mpz_2, y, tmp_mpz);
+        mpz_mod(y, tmp_mpz_2, n);
     }
-    mpz_clears(tmp, tmp2, NULL);
+    mpz_clears(tmp_mpz, tmp_mpz_2, NULL);
+    free(vector_y);
 }