✨ Mejora: Ajustar el tamaño de NVARCHAR y NCHAR en SQLServerColumn; normalizar nombres de columnas en pruebas unitarias

Author: axellpadilla

dbt/adapters/sqlserver/sqlserver_column.py

@@ -49,11 +49,10 @@ def string_type_instance(self, size: int) -> str:
         Instance-level string type selection that respects NVARCHAR/NCHAR.
         """
         dtype = (self.dtype or "").lower()
-        # n types use half the byte size for character count
         if dtype == "nvarchar":
-            return f"nvarchar({size//2 if size > 0 else '4000'})"
+            return f"nvarchar({size if size > 0 else '4000'})"
         if dtype == "nchar":
-            return f"nchar({size//2 if size > 1 else '1'})"
+            return f"nchar({size if size > 0 else '1'})"
         # default to varchar/char behaviour
         return f"varchar({size if size > 0 else '8000'})"
 

dbt/include/sqlserver/macros/materializations/models/unit_test/unit_test_create_table_as.sql

@@ -50,9 +50,7 @@
 
     {%- else %}
 
-        {%- set query_label_option = query_label.replace("'", "''") -%}
-        {%- set sql_with_quotes = sql.replace("'", "''") -%}
-        EXEC('CREATE TABLE {{relation}} AS {{sql_with_quotes}} {{ query_label_option }}');
+        {{ sqlserver__create_table_as(temporary, relation, sql) }}
 
     {% endif %}
 {% endmacro %}

dbt/include/sqlserver/macros/materializations/unit_test/unit_test_table.sql

@@ -19,7 +19,7 @@
 
   {%- set expected_column_names_quoted = [] -%}
   {%- for column_name in tested_expected_column_names -%}
-  {%-   do expected_column_names_quoted.append(column_name_to_quoted[column_name]) -%}
+  {%-   do expected_column_names_quoted.append(column_name_to_quoted[column_name|lower]) -%}
   {%- endfor -%}
 
   {% if not expected_sql %}

dbt/include/sqlserver/macros/unit_test_sql/get_fixture_sql.sql

@@ -1,10 +1,24 @@
+{% macro sqlserver__normalize_unit_test_row(row, column_name_to_data_types) %}
+{%- set normalized_row = {} -%}
+{%- for column_name, column_value in row.items() -%}
+    {%- set normalized_column_name = column_name | lower -%}
+    {%- if normalized_column_name in column_name_to_data_types -%}
+        {%- do normalized_row.update({normalized_column_name: column_value}) -%}
+    {%- else -%}
+        {%- do normalized_row.update({column_name: column_value}) -%}
+    {%- endif -%}
+{%- endfor -%}
+{{ return(normalized_row) }}
+{% endmacro %}
+
 {% macro get_expected_sql(rows, column_name_to_data_types, column_name_to_quoted) %}
 
 {%- if (rows | length) == 0 -%}
     select top 0 * from dbt_internal_unit_test_actual where 1=0
 {%- else -%}
 {%- for row in rows -%}
-{%- set formatted_row = format_row(row, column_name_to_data_types) -%}
+{%- set normalized_row = sqlserver__normalize_unit_test_row(row, column_name_to_data_types) -%}
+{%- set formatted_row = format_row(normalized_row, column_name_to_data_types) -%}
 select
 {%- for column_name, column_value in formatted_row.items() %} {{ column_value }} as {{ column_name_to_quoted[column_name] }}{% if not loop.last -%}, {%- endif %}
 {%- endfor %}