fix(commons): don't overwrite existing value with undefined in deepMerge (#5141)

Co-authored-by: Andrea Amorosi <[email protected]>
Co-authored-by: Stefano Vozza <[email protected]>

Author: 3 people

packages/commons/src/deepMerge.ts

@@ -45,7 +45,9 @@ const mergeArrayItemsByIndex = (
     }
 
     // Otherwise, replace the target item with source item
-    targetArray[i] = srcItem;
+    if (srcItem !== undefined || tgtItem === undefined) {
+      targetArray[i] = srcItem;
+    }
   }
 };
 
@@ -123,7 +125,9 @@ const mergeRecursive = (
       continue;
     }
 
-    target[key] = sourceValue;
+    if (sourceValue !== undefined || targetValue === undefined) {
+      target[key] = sourceValue;
+    }
   }
 };
 

packages/commons/tests/unit/deepMerge.test.ts

@@ -428,16 +428,43 @@ describe('Function: deepMerge', () => {
       expect(result).toEqual({ a: null });
     });
 
-    it('handles undefined values in source', () => {
+    it('handles undefined values in source (does not overwrite existing value with `undefined`)', () => {
       // Prepare
       const target = { a: 1, b: 2 };
-      const source = { a: undefined };
+      const source = { a: undefined, c: undefined };
 
       // Act
       const result = deepMerge(target, source);
 
       // Assess
-      expect(result).toEqual({ a: undefined, b: 2 });
+      expect(result).toStrictEqual({ a: 1, b: 2, c: undefined });
+    });
+
+    it('handles undefined values in array of source (does not overwrite existing value with `undefined`)', () => {
+      // Prepare
+      const target = { arr: [4, 5, 6] };
+      const source = { arr: [1, undefined, 3, undefined] };
+      source.arr[1] = undefined;
+
+      // Act
+      const result = deepMerge(target, source);
+
+      // Assess
+      expect(result).toStrictEqual({ arr: [1, 5, 3, undefined] });
+    });
+
+    it('handles missing values in array of source (does not overwrite existing value with `undefined`)', () => {
+      // Prepare
+      const target = { arr: [4, 5, 6] };
+      const source = { arr: new Array(4) };
+      source.arr[0] = 1;
+      source.arr[2] = 3;
+
+      // Act
+      const result = deepMerge(target, source);
+
+      // Assess
+      expect(result).toStrictEqual({ arr: [1, 5, 3, undefined] });
     });
 
     it('handles Symbol keys (ignores them)', () => {