File tree Expand file tree Collapse file tree
src/Microsoft.CodeDom.Providers.DotNetCompilerPlatform Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -165,12 +165,13 @@ private string GetCompilationArgumentString(CompilerParameters options) {
165165 // CodeDom sets TreatWarningAsErrors to true whenever warningLevel is non-zero.
166166 // However, TreatWarningAsErrors should be false by default.
167167 // And users should be able to set the value by set the value of option "WarnAsError".
168- // ASP.Net does fix this "WarnAsError" option in a like named function, but only for old CodeDom providers (CSharp/VB).
169- // The ASP.Net fix was to set TreatWarningAsErrors to false anytime '/warnaserror' was
168+ // ASP.Net does fix this option in a like named function, but only for old CodeDom providers (CSharp/VB).
169+ // The old ASP.Net fix was to set TreatWarningAsErrors to false anytime '/warnaserror' was
170170 // detected in the compiler command line options, thus allowing the user-specified
171171 // option to prevail. In these CodeDom providers though, users have control through
172172 // the 'WarnAsError' provider option as well as manual control over the command
173- // line args. So just go with the 'WarnAsError' provider option here.
173+ // line args. 'WarnAsError' will default to false but can be set by the user.
174+ // So just go with the 'WarnAsError' provider option here.
174175 private void FixTreatWarningsAsErrors ( CompilerParameters parameters ) {
175176 parameters . TreatWarningsAsErrors = _providerOptions . WarnAsError ;
176177 }
You can’t perform that action at this time.
0 commit comments