[SDL] Must onboard to FxCop Rosyln Analyzer

[TimothyMothra]

TODO

• https://www.nuget.org/packages/Microsoft.CodeAnalysis.FxCopAnalyzers/

STRETCH GOAL

• Fail on Warnings

    <Choose>
      <When Condition=" '$(Configuration)' == 'Release' ">
        <PropertyGroup>
          <!-- Microsoft recommends that we disable CodeAnalysis in favor of FxCop Analyzers. aka.ms/fxcopanalyzers -->
          <RunCodeAnalysis>false</RunCodeAnalysis>
          <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
        </PropertyGroup>
      </When>
      <When Condition=" '$(Configuration)' != 'Release' ">
        <PropertyGroup>
          <RunCodeAnalysis>false</RunCodeAnalysis>
          <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
        </PropertyGroup>
      </When>
    </Choose>

For reference: https://github.com/microsoft/ApplicationInsights-dotnet/blob/develop/BASE/src/Microsoft.ApplicationInsights/Microsoft.ApplicationInsights.csproj