Update versions to allow integration tests to run on 17.14 (#796)

* Update versions to allow integration tests to run on 17.14

* Small updates
Fixes build on CI, remove another warning related to XML comments

* switch back to LTS

Author: phil-allen-msft

Directory.Packages.props

@@ -1,19 +1,19 @@
 <Project>
-
+  
   <PropertyGroup>
     <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
     <!-- This is due to noise caused from the Minimatch package, tracked at https://github.com/SLaks/Minimatch/issues/12 -->
     <NoWarn>$(NoWarn);NU1603</NoWarn>
     <WebToolsPackageVersion>17.7.273</WebToolsPackageVersion>
   </PropertyGroup>
-
+  
   <ItemGroup>
-    <PackageVersion Include="MessagePack" Version="2.5.187"/>
+    <PackageVersion Include="MessagePack" Version="2.5.187" />
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
-    <PackageVersion Include="Microsoft.Build.Framework" Version="17.8.3" />
-    <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.8.3" />
-    <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.8.3" />
+    <PackageVersion Include="Microsoft.Build.Framework" Version="17.8.29" />
+    <PackageVersion Include="Microsoft.Build.Tasks.Core" Version="17.8.29" />
+    <PackageVersion Include="Microsoft.Build.Utilities.Core" Version="17.8.29" />
     <PackageVersion Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" />
     <PackageVersion Include="Microsoft.IO.Redist" Version="6.0.1" />
     <PackageVersion Include="Microsoft.VisualStudio.Editor" Version="17.7.188" />
@@ -35,7 +35,7 @@
     <PackageVersion Include="NerdBank.GitVersioning" Version="3.6.133" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageVersion Include="Nuget.VisualStudio" Version="17.7.1" />
-
+    
     <PackageVersion Include="System.Collections.Immutable" Version="7.0.0" />
     <PackageVersion Include="System.Formats.Asn1" Version="8.0.1" />
     <PackageVersion Include="System.Memory" Version="4.5.5" />
@@ -46,20 +46,20 @@
     <PackageVersion Include="System.Security.Cryptography.ProtectedData" Version="7.0.0" />
     <PackageVersion Include="System.Security.Permissions" Version="7.0.0" />
     <PackageVersion Include="System.Text.Json" Version="8.0.5" />
-    <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4"/>
+    <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
     <PackageVersion Include="System.ValueTuple" Version="4.5.0" />
-
+    
     <!-- Test references -->
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.7.0" />
-    <PackageVersion Include="Microsoft.Test.Apex.VisualStudio" Version="17.10.34923.60" />
+    <PackageVersion Include="Microsoft.Test.Apex.VisualStudio" Version="17.14.36217.32" />
     <PackageVersion Include="MSTest.TestAdapter" Version="3.0.3" />
     <PackageVersion Include="MSTest.TestFramework" Version="3.0.3" />
-
+    
     <!-- CommandLine utils -->
     <!-- This version should be kept in sync with the value of RuntimeFrameworkVersion where this package is consumed -->
     <PackageVersion Include="Microsoft.Extensions.CommandLineUtils.Sources" Version="2.1.0" />
     <PackageVersion Include="Microsoft.NETCore.DotnetAppHost" Version="2.1.0" />
-
+    
   </ItemGroup>
-
+  
 </Project>

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.200",
-    "rollForward": "latestFeature"
+    "version": "8.0.411",
+    "rollForward": "latestMajor"
   }
 }

src/LibraryManager/Providers/BaseProvider.cs

@@ -319,7 +319,7 @@ protected virtual string GetCachedFileLocalPath(ILibraryInstallationState state,
         /// <summary>
         /// Copies ILibraryInstallationState files to cache
         /// </summary>
-        /// <param name="state">Desired install state to cache</param>
+        /// <param name="goalState">Desired install state to cache</param>
         /// <param name="library">Library resolved from provider</param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>

src/LibraryManager/SemanticVersion.cs

@@ -52,6 +52,11 @@ private SemanticVersion(string originalText)
             OriginalText = originalText;
         }
 
+        /// <summary>
+        /// Parses a string into a SemanticVersion object.  If the string is not a valid semantic version, the object will be created with the originalText value.
+        /// </summary>
+        /// <param name="value"></param>
+        /// <returns></returns>
         public static SemanticVersion Parse(string value)
         {
             SemanticVersion ver = new SemanticVersion(value);