Correct deserialization of SessionStateAction for Cosmos provider. (#72)

Author: StephenMolloy

src/CosmosDBSessionStateProviderAsync/SessionStateActionsConverter.cs

@@ -26,6 +26,7 @@ public override bool CanConvert(Type typeToConvert)
                 throw new ArgumentException("reader");
             }
 
+            // See the note below in the writer for how to map this flags enum from a boolean.
             return reader.GetBoolean() ? SessionStateActions.InitializeItem : SessionStateActions.None;
         }
 
@@ -37,7 +38,12 @@ public override void Write(Utf8JsonWriter writer, SessionStateActions? action, J
                 return;
             }
 
-            writer.WriteBooleanValue((action == SessionStateActions.None));
+            // SessionStateActions is a [Flags] enum. The SQL providers serialize it as flags. I don't know why we didn't
+            //      just go with int or something flag-like here instead of true/false.
+            // 'None' means that the initialization of this state item has already been done and
+            //      thus the item is considered initialized. We serialize this item with the field name
+            //      "uninitialized", so 'None' should map to false.
+            writer.WriteBooleanValue((action != SessionStateActions.None));
         }
     }
 }

test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/SessionStateItemTest.cs

@@ -28,7 +28,7 @@ public void SessionStateItem_Can_Be_Serialized_With_Null_LockAge()
                 Timeout = 10
             };
             var json = JsonSerializer.Serialize<SessionStateItem>(item);
-            var expected = string.Format(JsonTemplate, item.SessionId, "null", item.LockCookie, item.Timeout, item.Locked, "AQE=", true); 
+            var expected = string.Format(JsonTemplate, item.SessionId, "null", item.LockCookie, item.Timeout, item.Locked, "AQE=", false); 
 
             Assert.Equal(expected, json, true);
         }
@@ -47,7 +47,7 @@ public void SessionStateItem_Can_Be_Serialized_With_LockAge()
                 Timeout = 10
             };
             var json = JsonSerializer.Serialize(item);
-            var expected = string.Format(JsonTemplate, item.SessionId, 60 * 1, item.LockCookie, item.Timeout, item.Locked, "AQE=", false);
+            var expected = string.Format(JsonTemplate, item.SessionId, 60 * 1, item.LockCookie, item.Timeout, item.Locked, "AQE=", true);
 
             Assert.Equal(expected, json, true);
         }