You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
delete npm_import(link_packages) - it seems to just duplicate content into the npm__${pkg}__${version}//${link_package}/{BUILD.bazel,package_json.bzl} with nothing link specific in it? these targets should be available via @npm//{link_package/:node_modules/{pkg}/package_json.bzl instead which has a more predictable location then the npm__${pkg}__${version} repo (refactor: remove npm_import(link_packages) #2486)
simplify internal package store rules and make circular-dep handling opt-in? remove support for circular deps on packages with lifecycle hooks (this could remove some complications with /pkg vs /ref targets etc)?
split npm_link_all_packages store vs link targets into different marcos: store targets (root only), :node_modules/{pkg} targets within each package directory such as @npm//my/project:defs.bzl
BREAKING CHANGES for next major release of rules_js:
npm_import/npm_package_store(dev)([Bug]:dev = Truesupport missing from pnpm version 9 lockfiles #2013, refactor: remove support for pnpm <v9 #2456)npm_translate_lock(root_package)(refactor: remove npm_translate_lock(root_package) #2552)npm_translate_lock(link_workspace)(refactor: remove npm_translate_lock(link_workspace) #2551)npm_translate_lock(addition_build_content)(refactor: remove npm_translate_lock(additional_file_contents) #2555)npm_link_package(root_package, link)(refactor: simplify npm_link_package() util macro #2553)npm/private/versions.bzl(refactor: remove support for pnpm <v9 #2456)requiresBuild(refactor: remove support for pnpm <v9 #2456)remove legacy runfiles code for older versions of bazel(refactor: update legacy runfiles MANIFEST comment #2532)hasattr(nodeinfo, "node")calls, ...) (chore: upgrade rules_nodejs to 6.6 #2467)abortcontroller-polyfilletc) (refactor: remove use of abortcontroller-polyfill for legacy node versions #2504, chore: remove node16+18 testing #2530)exclude_types_from_npm_packages_flag(refactor: remove exclude_types_from_npm_packages flag #2464)TODO(3.0)commentsnpm_translate_lock(dev/prod)with single "no dev" flag, see [Bug]:dev = Truesupport missing from pnpm version 9 lockfiles #2013 (refactor: replace npm_translate_lock(prod,dev) with no_dev flag similar to no_optional #2487 ?)npm_translate_lock(defs_bzl_filename)- does this really need to be customized? (refactor: remove npm_translate_lock(defs_bzl_filename) #2466)yq_toolchain_prefixwith a bzlmod alternative (refactor: directly use yq.bzl module #2501)npm_import(link_packages)- it seems to just duplicate content into thenpm__${pkg}__${version}//${link_package}/{BUILD.bazel,package_json.bzl}with nothing link specific in it? these targets should be available via@npm//{link_package/:node_modules/{pkg}/package_json.bzlinstead which has a more predictable location then thenpm__${pkg}__${version}repo (refactor: remove npm_import(link_packages) #2486)yarn autocleanexcludes by default (opt-in: feat: add opt-in default npm package excludes from yarn #2136) (feat: add package exclusion presets, enable default exclusion list #2652 or feat: enable default npm_exclude_package_contents #2636)MAYBE:
remove bazel v7 supportnpm_link_all_packagesstore vs link targets into different marcos: store targets (root only),:node_modules/{pkg}targets within each package directory such as@npm//my/project:defs.bzlremoveused internally still, but no longer publicnpm_import(extract_full_archive)?LARGE (but should be non-breaking):
transitive_closurefor packages with non-circular deps (refactor: do not use transitive_closure for lifecycle hooks #2559, refactor: only use transitive_closure when circular deps or lifecycle hooks exist #2543)