test: add additional esm sandbox assertions

Author: jbedard

.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU=

@@ -16,8 +16,8 @@ examples/npm_deps/patches/[email protected]=-442666336
 examples/npm_package/libs/lib_a/package.json=-1377103079
 examples/npm_package/packages/pkg_a/package.json=1006424040
 examples/npm_package/packages/pkg_b/package.json=1041247977
-examples/npm_package/packages/pkg_d/package.json=1110895851
-examples/npm_package/packages/pkg_e/package.json=-2145239245
+examples/npm_package/packages/pkg_d/package.json=1259011357
+examples/npm_package/packages/pkg_e/package.json=-1634325215
 examples/runfiles/package.json=-1545884645
 examples/stack_traces/package.json=2011229626
 examples/webpack_cli/package.json=1911342006

examples/macro/mocha.bzl

@@ -22,5 +22,7 @@ def mocha_test(name, srcs, args = [], data = [], env = {}, **kwargs):
             # to the location Bazel expects.
             "MOCHA_FILE": "$$XML_OUTPUT_FILE",
         }),
+        preserve_symlinks_main = False,
+        copy_data_to_bin = False,
         **kwargs
     )

examples/macro/test.js

@@ -1,4 +1,5 @@
 const assert = require('assert')
+const { dirname } = require('node:path')
 
 describe('mocha', () => {
     it('integrates with Bazel', () => {
@@ -8,4 +9,13 @@ describe('mocha', () => {
     it('is in bazel-out', () => {
         assert.match(__dirname, /bazel-out/)
     })
+
+    it('is sandboxed', () => {
+        assert.match(__dirname, /examples\/macro\/test_\/test\.runfiles/)
+        assert.match(
+            __filename,
+            /-sandbox\/\d+\/execroot\/_main\/bazel-out\/[^/]+\/bin\/examples\/macro\/test_\/test.runfiles\/_main\/examples\/macro\/test\.js/
+        )
+        assert.equal(__dirname, dirname(__filename))
+    })
 })

examples/npm_deps/BUILD.bazel

@@ -265,31 +265,37 @@ js_test(
 
 write_file(
     name = "write9",
-    out = "case9.js",
-    content = ["require('@mycorp/pkg-d')"],
+    out = "case9.mjs",
+    content = [
+        "import { sandboxAssert } from '@mycorp/pkg-d'",
+        "sandboxAssert()",
+    ],
 )
 
 js_test(
     name = "test9",
     data = [
         ":node_modules/@mycorp/pkg-d",
     ],
-    entry_point = "case9.js",
+    entry_point = "case9.mjs",
 )
 
 #######################################
 # Case 10: use a first-party npm package a transitive dependency on a monorepo workspace from a js_library target
 
 write_file(
     name = "write10",
-    out = "case10.js",
-    content = ["require('@mycorp/pkg-e')"],
+    out = "case10.mjs",
+    content = [
+        "import { sandboxAssert } from '@mycorp/pkg-e'",
+        "sandboxAssert()",
+    ],
 )
 
 js_test(
     name = "test10",
     data = [
         ":node_modules/@mycorp/pkg-e",
     ],
-    entry_point = "case10.js",
+    entry_point = "case10.mjs",
 )

examples/npm_package/packages/pkg_d/BUILD.bazel

@@ -9,6 +9,7 @@ js_library(
         "index.js",
         "package.json",
     ],
+    copy_data_to_bin = False,
     visibility = ["//visibility:public"],
     # because we're linking this js_library, we must explictly add our npm dependendies to `deps` so
     # they are picked up my the linker. npm dependendies in `data` are not propogated through the

examples/npm_package/packages/pkg_d/index.js

@@ -1,19 +1,28 @@
 /**
  * @fileoverview minimal test program that requires a third-party package from npm
  */
-const acorn = require('acorn')
-const { v4: uuid } = require('uuid')
+import * as acorn from 'acorn'
+import { fileURLToPath } from 'node:url'
+export { v4 as uuid } from 'uuid'
 
-function toAst(program) {
+export function toAst(program) {
     return JSON.stringify(acorn.parse(program, { ecmaVersion: 2020 })) + '\n'
 }
 
-function getAcornVersion() {
+export function getAcornVersion() {
     return acorn.version
 }
 
-module.exports = {
-    toAst,
-    getAcornVersion,
-    uuid,
+export function sandboxAssert() {
+    const __filename = fileURLToPath(import.meta.url)
+
+    if (
+        !/-sandbox\/\d+\/execroot\/_main\/bazel-out\/[^/]+\/bin\/.*\.runfiles\/.*\/index.js$/.test(
+            __filename
+        )
+    ) {
+        throw new Error(`Not in sandbox: ${__filename}`)
+    }
 }
+
+sandboxAssert()

examples/npm_package/packages/pkg_d/package.json

@@ -1,5 +1,11 @@
 {
     "name": "@mycorp/pkg-d",
+    "type": "module",
+    "exports": {
+        ".": {
+            "import": "./index.js"
+        }
+    },
     "private": true,
     "dependencies": {
         "uuid": "8.3.2"

examples/npm_package/packages/pkg_e/BUILD.bazel

@@ -9,6 +9,7 @@ js_library(
         "index.js",
         "package.json",
     ],
+    copy_data_to_bin = False,
     visibility = ["//visibility:public"],
     # because we're linking this js_library, we must explictly add our npm dependendies to `deps` so
     # they are picked up my the linker. npm dependendies in `data` are not propogated through the

examples/npm_package/packages/pkg_e/index.js

@@ -3,4 +3,23 @@
  * that defines its package using js_library.
  */
 
-module.exports = require('@mycorp/pkg-d')
+import { fileURLToPath } from 'node:url'
+
+import { sandboxAssert as dSandboxAssert } from '@mycorp/pkg-d'
+export { getAcornVersion, toAst, uuid } from '@mycorp/pkg-d'
+
+export function sandboxAssert() {
+    const __filename = fileURLToPath(import.meta.url)
+
+    if (
+        !/-sandbox\/\d+\/execroot\/_main\/bazel-out\/[^/]+\/bin\/.*\.runfiles\/.*\/index.js$/.test(
+            __filename
+        )
+    ) {
+        throw new Error(`Not in sandbox: ${__filename}`)
+    }
+
+    dSandboxAssert()
+}
+
+sandboxAssert()

examples/npm_package/packages/pkg_e/package.json

@@ -1,6 +1,12 @@
 {
     "name": "@mycorp/pkg-e",
+    "type": "module",
     "private": true,
+    "exports": {
+        ".": {
+            "import": "./index.js"
+        }
+    },
     "dependencies": {
         "@mycorp/pkg-d": "workspace:*"
     }