fix: npm deps on git+https urls (#2592)

Found while adding more tests for
#2403

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

Author: jbedard

e2e/git_dep_metadata/MODULE.bazel

@@ -26,8 +26,8 @@ npm.npm_import(
     commit = "c245af8ea73ce3345d92bbda6c684092a841e262",
     package = "syncpack",
     root_package = "",
-    url = "https://codeload.github.com/JamieMason/syncpack/tar.gz/c245af8ea73ce3345d92bbda6c684092a841e262",
-    version = "github.com/JamieMason/syncpack/c245af8ea73ce3345d92bbda6c684092a841e262",
+    url = "https://git@github.com/JamieMason/syncpack.git",
+    version = "c245af8ea73ce3345d92bbda6c684092a841e262",
 )
 use_repo(npm, "syncpack")
 use_repo(npm, "syncpack__links")

e2e/git_dep_metadata/WORKSPACE

@@ -36,6 +36,6 @@ npm_import(
     commit = "c245af8ea73ce3345d92bbda6c684092a841e262",
     package = "syncpack",
     root_package = "",
-    url = "https://codeload.github.com/JamieMason/syncpack/tar.gz/c245af8ea73ce3345d92bbda6c684092a841e262",
-    version = "github.com/JamieMason/syncpack/c245af8ea73ce3345d92bbda6c684092a841e262",
+    url = "https://git@github.com/JamieMason/syncpack.git",
+    version = "c245af8ea73ce3345d92bbda6c684092a841e262",
 )

e2e/pnpm_lockfiles/base/package.json

@@ -11,9 +11,13 @@
         "@isaacs/cliui": "8.0.2",
         "debug": "ngokevin/debug#9742c5f383a6f8046241920156236ade8ec30d53",
         "esbuild": "0.27.0",
+        "highlightjs-git-https-notar": "git+https://gitea.osmocom.org/vyanitskiy/highlight.js.git#58dc5961f6f2bb8bc8bb1e7ce39f268a2fdd874f",
         "jsonify": "https://github.com/aspect-build/test-packages/releases/download/0.0.0/@foo-jsonify-0.0.0.tgz",
+        "jquery-github": "github:jquery/jquery",
         "jquery-git-ssh-e61fccb": "git+ssh://[email protected]/jquery/jquery.git#e61fccb9d736235b4b011f89cba6866bc0b8997d",
         "jquery-git-ssh-399b201": "git+ssh://[email protected]:jquery/jquery#399b201bb3143a3952894cf3489b4848fc003967",
+        "jquery-git-https-763ade6": "git+https://[email protected]:jquery/jquery#763ade6dda092709b36d97491951bcae415d91d1",
+        "jquery-http-git-f85d521": "https://github.com/jquery/jquery.git#f85d521cdeeb3c6d3f4563a06dba8be793e26ef0",
         "rollup": "2.14.0",
         "rollup3": "npm:[email protected]",
         "rollup-plugin-with-peers": "npm:@rollup/[email protected]",

e2e/pnpm_lockfiles/lockfile-test.bzl

@@ -165,8 +165,12 @@ def lockfile_test(npm_link_all_packages, name = None):
             # Odd git/http versions
             ":node_modules/debug",
             ":node_modules/jsonify",
+            ":node_modules/highlightjs-git-https-notar",
+            ":node_modules/jquery-github",
             ":node_modules/jquery-git-ssh-e61fccb",
             ":node_modules/jquery-git-ssh-399b201",
+            ":node_modules/jquery-http-git-f85d521",
+            ":node_modules/jquery-git-https-763ade6",
 
             # npm: alias
             ":node_modules/@aspect-test/a2",