Skip to content

Commit dc0205c

Browse files
acozzetteclaude
andauthored
test: reduce Bazel module count by consolidating e2e tests into examples (#2791)
Remove 5 standalone e2e Bazel modules (44 → 39) by merging or moving tests that don't require their own module-level configuration: - e2e/npm_link_package-esm: merged into e2e/npm_link_package by adding .mjs ESM variants alongside existing .js files - e2e/package_json_module: moved to examples/package_json_module; the "type: module" scoping is per-directory so it works as a sub-package - e2e/runfiles: merged into examples/runfiles; added module-name path tests (module_name_test.js), nested binary runfiles propagation tests (outer.js), and js_run_binary tests (resolve-args.js) - e2e/stamped_package_json: moved to examples/stamped_package_json; added jq.bzl as a dev dep to examples/MODULE.bazel; excluded from pnpm workspace since package.json contains a stamp template version - e2e/worker: moved to examples/worker; no npm deps and bazel_lib + rules_nodejs are already available in examples I also moved the protobuf examples from examples/protobuf into e2e/ for consistency. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases --------- Co-authored-by: Claude Sonnet 4.6 <[email protected]>
1 parent 4960a9e commit dc0205c

110 files changed

Lines changed: 251 additions & 1435 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.aspect/workflows/config.yaml

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,6 @@ workspaces:
4444
e2e/npm_link_package:
4545
icon: npm
4646
tasks: *e2e_tasks
47-
e2e/npm_link_package-esm:
48-
icon: npm
49-
tasks: *e2e_tasks
5047
e2e/npm_link_package-rerooted:
5148
icon: npm
5249
tasks: *e2e_tasks
@@ -86,9 +83,6 @@ workspaces:
8683
e2e/npm_translate_yarn_lock:
8784
icon: yarn
8885
tasks: *e2e_tasks
89-
e2e/package_json_module:
90-
icon: npm
91-
tasks: *e2e_tasks
9286
e2e/patch_from_repo:
9387
icon: npm
9488
tasks:
@@ -121,18 +115,18 @@ workspaces:
121115
e2e/pnpm_version:
122116
icon: pnpm
123117
tasks: *e2e_tasks
118+
e2e/protobuf-es:
119+
icon: proto
120+
tasks: *e2e_tasks
121+
e2e/protobuf-google:
122+
icon: proto
123+
tasks: *e2e_tasks
124124
e2e/repo_mapping:
125125
icon: js
126126
tasks: *e2e_tasks
127127
e2e/output_paths:
128128
icon: js
129129
tasks: *e2e_tasks
130-
e2e/runfiles:
131-
icon: js
132-
tasks: *e2e_tasks
133-
e2e/stamped_package_json:
134-
icon: npm
135-
tasks: *e2e_tasks
136130
e2e/vendored_node:
137131
icon: js
138132
tasks: *e2e_tasks
@@ -142,9 +136,6 @@ workspaces:
142136
e2e/verify_patches:
143137
icon: js
144138
tasks: *e2e_tasks
145-
e2e/worker:
146-
icon: js
147-
tasks: *e2e_tasks
148139
# No test targets. Requires running test.sh.
149140
# e2e/update_pnpm_lock:
150141
# e2e/update_pnpm_lock_with_import:
@@ -153,12 +144,6 @@ workspaces:
153144
examples:
154145
icon: js
155146
tasks: *e2e_tasks
156-
examples/protobuf/bufbuild-es:
157-
icon: proto
158-
tasks: *e2e_tasks
159-
examples/protobuf/google-protobuf:
160-
icon: proto
161-
tasks: *e2e_tasks
162147
bazel:
163148
flags:
164149
- --config=ci

e2e/npm_link_package-esm/.bazelignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

e2e/npm_link_package-esm/.bazelrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

e2e/npm_link_package-esm/.bazelversion

Lines changed: 0 additions & 1 deletion
This file was deleted.

e2e/npm_link_package-esm/.npmrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

e2e/npm_link_package-esm/MODULE.bazel

Lines changed: 0 additions & 22 deletions
This file was deleted.

e2e/npm_link_package-esm/package.json

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)