revert back to rules_nodejs 6.3

Author: jbedard

MODULE.bazel

@@ -14,7 +14,7 @@ bazel_dep(name = "bazel_features", version = "1.9.0")
 bazel_dep(name = "bazel_lib", version = "3.0.0")
 bazel_dep(name = "bazel_skylib", version = "1.5.0")
 bazel_dep(name = "platforms", version = "0.0.5")
-bazel_dep(name = "rules_nodejs", version = "6.4.0")
+bazel_dep(name = "rules_nodejs", version = "6.3.0")
 bazel_dep(name = "yq.bzl", version = "0.3.2")
 
 tel = use_extension("@aspect_tools_telemetry//:extension.bzl", "telemetry")

js/private/test/node-patches/BUILD.bazel

@@ -1,6 +1,6 @@
 load("@aspect_bazel_lib//lib:copy_to_bin.bzl", "copy_to_bin")
 load("@npm//:@babel/cli/package_json.bzl", babel_bin = "bin")
-load("//js:defs.bzl", "js_test")
+load("//js:defs.bzl", "js_library", "js_test")
 
 TESTS = [
     "escape.js",
@@ -160,3 +160,29 @@ babel_bin.babel(
         TOOLCHAINS_VERSIONS,
     )
 ]
+
+# TODO: this doesn't fail with patch_node_esm_loader=False, need failing test!!
+[
+    js_test(
+        name = "esm_test_%s" % toolchain_name,
+        data = [":lib"],
+        entry_point = "esm.mjs",
+        node_toolchain = toolchain,
+        patch_node_esm_loader = True,
+        patch_node_fs = True,
+    )
+    for toolchain_name, toolchain in zip(
+        TOOLCHAINS_NAMES,
+        TOOLCHAINS_VERSIONS,
+    )
+    if toolchain_name != "node16"  # ESM json loading not supported on Node 16
+]
+
+# A basic library with esm imports, esm json data etc
+js_library(
+    name = "lib",
+    srcs = [
+        "data.json",
+        "lib.mjs",
+    ],
+)

js/private/test/node-patches/data.json

@@ -0,0 +1,4 @@
+{
+    "name": "json-data",
+    "answer": 42
+}

js/private/test/node-patches/esm.mjs

@@ -0,0 +1,29 @@
+import { fileURLToPath } from 'url'
+import { dirname } from 'node:path'
+import { data2, data3, my__dirname, my__filename, my__pwd } from './lib.mjs'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = dirname(__filename)
+
+console.log('process.cwd():', my__pwd)
+console.log('data2:', data2)
+console.log('data3:', data3)
+
+if (my__dirname !== __dirname) {
+    throw new Error('__dirname does not match expected value')
+}
+
+if (my__pwd !== process.cwd()) {
+    throw new Error('process.cwd() does not match expected value')
+}
+
+if (dirname(my__filename) !== dirname(__filename)) {
+    throw new Error('__filename does not match expected value')
+}
+
+if (
+    dirname(__filename) !=
+    dirname(fileURLToPath(import.meta.resolve('./lib2.mjs')))
+) {
+    throw new Error('import.meta.resolve does not match expected value')
+}

js/private/test/node-patches/lib.mjs

@@ -0,0 +1,13 @@
+import { fileURLToPath } from 'url'
+import { dirname } from 'path'
+import data from './data.json' with { type: 'json' }
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = dirname(__filename)
+
+export const my__dirname = __dirname
+export const my__filename = __filename
+export const my__pwd = process.cwd()
+
+export const data2 = data
+export const data3 = { ...data, addedKey: 'addedValue' }