broken: js_library() => npm_package() loads the npm_package() files twice

Author: jbedard

.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU=

@@ -2,7 +2,7 @@
 # Input hashes for repository rule npm_translate_lock(name = "npm", pnpm_lock = "@@//:pnpm-lock.yaml").
 # This file should be checked into version control along with the pnpm-lock.yaml file.
 .npmrc=-2065072158
-examples/js_binary/package.json=-41174383
+examples/js_binary/package.json=1355509971
 examples/js_lib_pkg/a/package.json=740602849
 examples/js_lib_pkg/b/package.json=-561926249
 examples/linked_consumer/package.json=-1109186228
@@ -34,5 +34,5 @@ npm/private/test/vendored/is-odd/package.json=1041695223
 npm/private/test/vendored/lodash-4.17.21.tgz=-1206623349
 npm/private/test/vendored/semver-max/package.json=578664053
 package.json=-2040565922
-pnpm-lock.yaml=231890567
+pnpm-lock.yaml=881679841
 pnpm-workspace.yaml=-1336981113

examples/js_binary/BUILD.bazel

@@ -181,7 +181,7 @@ js_test(
 ###############################
 # Use case 4
 # A first-party library which we want to run as a program.
-# This relies on @mycorp/pkg-a and @mycorp/pkg-b which are packages within this monorepo.
+# This relies on @mycorp/pkg-{a,b,d} which are packages within this monorepo.
 
 write_file(
     name = "write4_cjs",
@@ -212,6 +212,7 @@ write_file(
             name = "bin4_%s" % t,
             data = [
                 ":node_modules/@mycorp/pkg-a",
+                ":node_modules/@mycorp/pkg-e",
                 "//:node_modules/@mycorp/pkg-b",
             ],
             entry_point = "case4.%s" % t,
@@ -263,6 +264,27 @@ write_file(
             file1 = "//examples:expected_one_ast.json",
             file2 = ":out4-b_%s" % t,
         ),
+        js_run_binary(
+            name = "run4-e_%s" % t,
+            outs = ["out4-e_%s" % t],
+            args = [
+                "out4-e_%s" % t,
+                "@mycorp/pkg-e",
+            ],
+            chdir = package_name(),
+            # This specifically tests that a `select` and `|` operator can be used when setting `env`.
+            env = {} | select({
+                "//conditions:default": {
+                    "NODE_ENV": "production",
+                },
+            }),
+            tool = ":bin4_%s" % t,
+        ),
+        diff_test(
+            name = "test4-e_%s" % t,
+            file1 = "//examples:expected_one_ast.json",
+            file2 = ":out4-e_%s" % t,
+        ),
     ]
     for t in [
         "mjs",

examples/js_binary/package.json

@@ -1,6 +1,7 @@
 {
     "private": true,
     "devDependencies": {
-        "@mycorp/pkg-a": "workspace:*"
+        "@mycorp/pkg-a": "workspace:*",
+        "@mycorp/pkg-e": "workspace:*"
     }
 }

examples/npm_package/packages/pkg_e/BUILD.bazel

@@ -17,5 +17,8 @@ js_library(
     # linker when linking a js_libary.
     deps = [
         ":node_modules",
+
+        # Manually linked and not in :node_modules
+        "//:node_modules/@mycorp/pkg-b",
     ],
 )

examples/npm_package/packages/pkg_e/index.cjs

@@ -1,4 +1,5 @@
-const { sandboxAssert: dSandboxAssert } = require('@mycorp/pkg-d')
+const { sandboxAssert: bSandboxAssert } = require('@mycorp/pkg-b')
+const { sandboxAssert: dSandboxAssert, toAst } = require('@mycorp/pkg-d')
 
 function sandboxAssert() {
     if (!/-sandbox\/\d+\/execroot\//.test(__filename)) {
@@ -11,10 +12,13 @@ function sandboxAssert() {
         throw new Error(`Not runfiles: ${__filename}`)
     }
 
+    bSandboxAssert()
     dSandboxAssert()
+    require('@mycorp/pkg-b').sandboxAssert()
     require('@mycorp/pkg-d').sandboxAssert()
 }
 
 sandboxAssert()
 
+module.exports.toAst = toAst
 module.exports.sandboxAssert = sandboxAssert

examples/npm_package/packages/pkg_e/index.mjs

@@ -5,6 +5,7 @@
 
 import { fileURLToPath } from 'node:url'
 
+import { sandboxAssert as bSandboxAssert } from '@mycorp/pkg-b'
 import { sandboxAssert as dSandboxAssert } from '@mycorp/pkg-d'
 export { getAcornVersion, toAst, uuid } from '@mycorp/pkg-d'
 
@@ -23,8 +24,10 @@ export async function sandboxAssert() {
 
     // Static import of pkg-d
     dSandboxAssert()
+    bSandboxAssert()
 
-    // Dynamic import of pkg-d
+    // Dynamic import of pkg-{b,d}
+    await import('@mycorp/pkg-b').then(({ sandboxAssert }) => sandboxAssert())
     await import('@mycorp/pkg-d').then(({ sandboxAssert }) => sandboxAssert())
 }