Skip to content

Commit 442874b

Browse files
acozzetteclaude
andcommitted
ci: move hoist_runfiles_to_exec_cfg coverage to Bazel 7 Buildkite job
Tests the opt-in flag path via Aspect Workflows rather than a separate GitHub Actions job. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
1 parent 10711d3 commit 442874b

2 files changed

Lines changed: 3 additions & 29 deletions

File tree

.aspect/workflows/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ tasks:
154154
name: Bazel 7
155155
id: bazel-7
156156
bazel:
157-
flags: ['--test_tag_filters=-skip-on-bazel7']
157+
flags: ['--test_tag_filters=-skip-on-bazel7', '--@aspect_rules_js//js:_hoist_runfiles_to_exec_cfg=true']
158158
env:
159159
USE_BAZEL_VERSION: '7.x'
160160
- test:

.github/workflows/ci.yaml

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -120,32 +120,6 @@ jobs:
120120
echo "No test.sh in ${PWD}; skipping"
121121
fi
122122
123-
# Ubuntu smoke test for e2e/bzlmod with hoist_runfiles_to_exec_cfg=true to verify
124-
# that the flag-controlled opt-in path works correctly.
125-
test-hoist-runfiles:
126-
runs-on: ubuntu-22.04
127-
defaults:
128-
run:
129-
working-directory: e2e/bzlmod
130-
env:
131-
ASPECT_RULES_JS_FROZEN_PNPM_LOCK: 1
132-
steps:
133-
- uses: actions/checkout@v6
134-
135-
- uses: bazel-contrib/[email protected]
136-
with:
137-
bazelisk-cache: true
138-
disk-cache: hoist-runfiles-bzlmod
139-
repository-cache: true
140-
141-
- name: bazel test //... with hoist_runfiles_to_exec_cfg=true
142-
run: |
143-
bazel test \
144-
--test_tag_filters=-skip-on-bazel7 \
145-
--build_tag_filters=-skip-on-bazel7 \
146-
--@aspect_rules_js//js:_hoist_runfiles_to_exec_cfg=true \
147-
//...
148-
149123
# Mac/Windows smoke tests - only e2e/bzlmod
150124
# Only run on main branch (not PRs) to minimize minutes (billed at 10X and 2X respectively)
151125
# https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions#included-storage-and-minutes
@@ -181,12 +155,12 @@ jobs:
181155
# For branch protection settings, this job provides a "stable" name that can be used to gate PR merges
182156
# on "all matrix jobs were successful".
183157
conclusion:
184-
needs: [test, smoke, test-hoist-runfiles]
158+
needs: [test, smoke]
185159
runs-on: ubuntu-latest
186160
if: always()
187161
steps:
188162
- run: |
189-
if [[ "${{ needs.test.result }}" == "success" && ("${{ needs.smoke.result }}" == "success" || "${{ needs.smoke.result }}" == "skipped") && "${{ needs.test-hoist-runfiles.result }}" == "success" ]]; then
163+
if [[ "${{ needs.test.result }}" == "success" && ("${{ needs.smoke.result }}" == "success" || "${{ needs.smoke.result }}" == "skipped") ]]; then
190164
exit 0
191165
else
192166
exit 1

0 commit comments

Comments
 (0)