fix: support lstatSync throwIfNoEntry

Author: jbedard

js/private/node-patches/fs.js

@@ -135,7 +135,7 @@ export const patcher = (fs: any = _fs, roots: string[]) => {
     ) {
         const stats = origLstatSync(...args)
 
-        if (!stats.isSymbolicLink()) {
+        if (!stats?.isSymbolicLink()) {
             // the file is not a symbolic link so there is nothing more to do
             return stats
         }

js/private/node-patches/src/fs.ts

@@ -135,7 +135,7 @@ export const patcher = (fs: any = _fs, roots: string[]) => {
     ) {
         const stats = origLstatSync(...args)
 
-        if (!stats.isSymbolicLink()) {
+        if (!stats?.isSymbolicLink()) {
             // the file is not a symbolic link so there is nothing more to do
             return stats
         }

js/private/node-patches_legacy/fs.js

@@ -1,2 +1,2 @@
 9546c440ffbbe36177f305a1aec4bf89fa08eea5926fe828c8e9edd8e08a16a7
-f68066745a57eff40fc49b4600cdde860dfa86ab231ebe4ed65097c98cc2df4f
+d26b897f8c3e3c3464f5acfd50ad56793f82f1f362e2bc2a78bc6a77204561cc

js/private/node-patches_legacy/src/fs.ts

@@ -70,6 +70,33 @@ describe('testing lstat', async () => {
         )
     })
 
+    await it('can lstatSync throwIfNoEntry:false', async () => {
+        await withFixtures(
+            {
+                a: { g: {} },
+                b: { file: 'contents' },
+            },
+            async (fixturesDir) => {
+                fixturesDir = fs.realpathSync(fixturesDir)
+
+                const patchedFs = Object.assign({}, fs)
+                patchedFs.promises = Object.assign({}, fs.promises)
+                patcher(patchedFs, [
+                    path.join(fixturesDir),
+                    path.join(fixturesDir, 'a', 'g'),
+                ])
+
+                assert.equal(
+                    undefined,
+                    patchedFs.lstatSync(
+                        path.join(fixturesDir, 'doesnt-exist'),
+                        { throwIfNoEntry: false }
+                    )
+                )
+            }
+        )
+    })
+
     await it('can lstat symlink in guard is file', async () => {
         await withFixtures(
             {

js/private/test/image/structure/digests.sum

@@ -70,6 +70,33 @@ describe('testing lstat', async () => {
         )
     })
 
+    await it('can lstatSync throwIfNoEntry:false', async () => {
+        await withFixtures(
+            {
+                a: { g: {} },
+                b: { file: 'contents' },
+            },
+            async (fixturesDir) => {
+                fixturesDir = fs.realpathSync(fixturesDir)
+
+                const patchedFs = Object.assign({}, fs)
+                patchedFs.promises = Object.assign({}, fs.promises)
+                patcher(patchedFs, [
+                    path.join(fixturesDir),
+                    path.join(fixturesDir, 'a', 'g'),
+                ])
+
+                assert.equal(
+                    undefined,
+                    patchedFs.lstatSync(
+                        path.join(fixturesDir, 'doesnt-exist'),
+                        { throwIfNoEntry: false }
+                    )
+                )
+            }
+        )
+    })
+
     await it('can lstat symlink in guard is file', async () => {
         await withFixtures(
             {