refactor: don't add js proto aspect on js_binary/test data (#2768)

Belated code review comment

Author: alexeagle

examples/proto/BUILD.bazel

@@ -1,4 +1,4 @@
-load("@aspect_rules_js//js:defs.bzl", "js_test")
+load("@aspect_rules_js//js:defs.bzl", "js_library", "js_test")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 load("@protobuf//bazel:proto_library.bzl", "proto_library")
 
@@ -13,8 +13,14 @@ proto_library(
     deps = ["@protobuf//:timestamp_proto"],
 )
 
+js_library(
+    name = "foo_js_lib",
+    # This edge runs an aspect to produce a JsInfo provider with protobuf .js/.d.ts files.
+    deps = [":foo_proto"],
+)
+
 js_test(
     name = "test",
-    data = [":foo_proto"],
+    data = [":foo_js_lib"],
     entry_point = "test_proto.js",
 )

js/private/js_binary.bzl

@@ -21,7 +21,6 @@ load("@bazel_lib//lib:expand_make_vars.bzl", "expand_locations", "expand_variabl
 load("@bazel_lib//lib:windows_utils.bzl", "create_windows_native_launcher_script")
 load(":bash.bzl", "BASH_INITIALIZE_RUNFILES")
 load(":js_helpers.bzl", "LOG_LEVELS", "envs_for_log_level", "gather_files_from_js_infos", "gather_runfiles")
-load(":proto.bzl", "js_proto_aspect")
 
 _DOC = """Execute a program in the Node.js runtime.
 
@@ -100,7 +99,6 @@ _ATTRS = {
         NB: `data` files are copied to the Bazel output tree before being passed
         as inputs to runfiles. See `copy_data_to_bin` docstring for more info.
         """,
-        aspects = [js_proto_aspect],
     ),
     "entry_point": attr.label(
         allow_files = True,