Skip to content

Commit 092dd78

Browse files
authored
refactor: js_image_layer to output with .tar extension when uncompressed (#2585)
Fixes #2584 ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: no ### Test plan `bazel test //...` passes
1 parent cde56b1 commit 092dd78

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

js/private/js_image_layer.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ def _js_image_layer_impl(ctx):
568568
output_groups = dict()
569569
compress = "" if ctx.attr.compression == "none" else ctx.attr.compression
570570
for typ, mtree, unused_inputs in layer_groups_gen:
571-
ext = tar_lib.common.compression_to_extension[compress] if compress else ""
571+
ext = tar_lib.common.compression_to_extension[compress] if compress else ".tar"
572572
output = ctx.actions.declare_file("%s_%s%s" % (ctx.label.name, typ, ext))
573573

574574
# add the layer group to outputgroupinfo and defaultinfo
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
b1b723afb1aac593e55cc5050909103650a13306d1f0366c5405dcc6cf73461f js/private/test/image/cksum_node
2-
052600f3a82ab6a4cc12cab7384971c960f9c589fdbfcf21bca563c36ff7d16e js/private/test/image/cksum_package_store_3p
3-
971f291232f3ab63aff37fb66c96fbf0eddc05ea9564b9673d0d2c9bfe958994 js/private/test/image/cksum_package_store_1p
4-
febf95a6d554c9bda3f0515bfd5ef273ac67d31c231d8162beaef8c4b7bc72f3 js/private/test/image/cksum_node_modules
1+
b1b723afb1aac593e55cc5050909103650a13306d1f0366c5405dcc6cf73461f js/private/test/image/cksum_node.tar
2+
052600f3a82ab6a4cc12cab7384971c960f9c589fdbfcf21bca563c36ff7d16e js/private/test/image/cksum_package_store_3p.tar
3+
971f291232f3ab63aff37fb66c96fbf0eddc05ea9564b9673d0d2c9bfe958994 js/private/test/image/cksum_package_store_1p.tar
4+
febf95a6d554c9bda3f0515bfd5ef273ac67d31c231d8162beaef8c4b7bc72f3 js/private/test/image/cksum_node_modules.tar

0 commit comments

Comments
 (0)