Skip to content

Commit 991e155

Browse files
committed
fix pressing delete on the keyboard also now deletes associated rotation and delete buttons
1 parent 5e51cdf commit 991e155

1 file changed

Lines changed: 17 additions & 8 deletions

File tree

app/features/selectable.js

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ export function Selectable(visbug) {
2525
let selectedCallbacks = []
2626
let labels = []
2727
let handles = []
28+
let rotationBtn = null
29+
let deleteBtn = null
2830

2931
const hover_state = {
3032
target: null,
@@ -502,12 +504,19 @@ export function Selectable(visbug) {
502504
else if (el.parentNode) return el.parentNode
503505
})
504506

505-
Array.from([...selected, ...labels, ...handles]).forEach(el =>
506-
el.remove())
507-
508-
labels = []
509-
handles = []
510-
selected = []
507+
Array.from([
508+
...selected,
509+
...labels,
510+
...handles,
511+
rotationBtn,
512+
deleteBtn
513+
]).forEach(el => el.remove())
514+
515+
labels = []
516+
handles = []
517+
selected = []
518+
rotationBtn = null
519+
deleteBtn = null
511520

512521
selected_after_delete.forEach(el =>
513522
select(el))
@@ -578,8 +587,8 @@ export function Selectable(visbug) {
578587
template: handleLabelText(el, visbug.activeTool)
579588
})
580589

581-
const deleteBtn = document.createElement('visbug-delete')
582-
const rotationBtn = document.createElement('visbug-rotation')
590+
deleteBtn = document.createElement('visbug-delete')
591+
rotationBtn = document.createElement('visbug-rotation')
583592
rotationBtn.position = {el}
584593
rotationBtn.setAttribute('data-label-id', id)
585594

0 commit comments

Comments
 (0)